]> www.infradead.org Git - users/hch/misc.git/commitdiff
gpiolib: acpi: initialize acpi_gpio_info struct
authorSébastien Szymanski <sebastien.szymanski@armadeus.com>
Fri, 12 Sep 2025 20:18:50 +0000 (22:18 +0200)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 15 Sep 2025 06:55:40 +0000 (08:55 +0200)
Since commit 7c010d463372 ("gpiolib: acpi: Make sure we fill struct
acpi_gpio_info"), uninitialized acpi_gpio_info struct are passed to
__acpi_find_gpio() and later in the call stack info->quirks is used in
acpi_populate_gpio_lookup. This breaks the i2c_hid_cpi driver:

[   58.122916] i2c_hid_acpi i2c-UNIW0001:00: HID over i2c has not been provided an Int IRQ
[   58.123097] i2c_hid_acpi i2c-UNIW0001:00: probe with driver i2c_hid_acpi failed with error -22

Fix this by initializing the acpi_gpio_info pass to __acpi_find_gpio()

Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220388
Fixes: 7c010d463372 ("gpiolib: acpi: Make sure we fill struct acpi_gpio_info")
Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
Tested-by: Hans de Goede <hansg@kernel.org>
Reviewed-by: Hans de Goede <hansg@kernel.org>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Tested-By: Calvin Owens <calvin@wbinvd.org>
Cc: stable@vger.kernel.org
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/gpio/gpiolib-acpi-core.c

index e81a29902bb2746940e7d752a6cf3449b5a88dc7..284e762d92c4d48d9b55973b3bd1069ecadd2ee6 100644 (file)
@@ -942,7 +942,7 @@ struct gpio_desc *acpi_find_gpio(struct fwnode_handle *fwnode,
 {
        struct acpi_device *adev = to_acpi_device_node(fwnode);
        bool can_fallback = acpi_can_fallback_to_crs(adev, con_id);
-       struct acpi_gpio_info info;
+       struct acpi_gpio_info info = {};
        struct gpio_desc *desc;
        int ret;
 
@@ -999,7 +999,7 @@ int acpi_dev_gpio_irq_wake_get_by(struct acpi_device *adev, const char *con_id,
        int ret;
 
        for (i = 0, idx = 0; idx <= index; i++) {
-               struct acpi_gpio_info info;
+               struct acpi_gpio_info info = {};
                struct gpio_desc *desc;
 
                /* Ignore -EPROBE_DEFER, it only matters if idx matches */