]> www.infradead.org Git - users/hch/misc.git/commitdiff
irqchip/aspeed-scu-ic: Fix an IS_ERR() vs NULL check
authorDan Carpenter <dan.carpenter@linaro.org>
Sat, 27 Sep 2025 12:26:05 +0000 (15:26 +0300)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 7 Oct 2025 08:23:22 +0000 (10:23 +0200)
of_iomap() doesn't return error pointers, it returns NULL.  Fix the error
checking to check for NULL pointers.

Fixes: 86cd4301c285 ("irqchip/aspeed-scu-ic: Refactor driver to support variant-based initialization")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
drivers/irqchip/irq-aspeed-scu-ic.c

index 5584e0f82cce83fbe4d29497c5875e3840c104ec..bee59c8c4c932c947d58b779aa904d07b0e2314c 100644 (file)
@@ -215,8 +215,8 @@ static int aspeed_scu_ic_of_init_common(struct aspeed_scu_ic *scu_ic,
        int irq, rc = 0;
 
        scu_ic->base = of_iomap(node, 0);
-       if (IS_ERR(scu_ic->base)) {
-               rc = PTR_ERR(scu_ic->base);
+       if (!scu_ic->base) {
+               rc = -ENOMEM;
                goto err;
        }