]> www.infradead.org Git - linux.git/commitdiff
ASoC: tegra20_ac97: Add missing unwind goto in tegra20_ac97_platform_probe()
authorZihao Wang <u202012060@hust.edu.cn>
Tue, 4 Apr 2023 08:46:22 +0000 (16:46 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 4 Apr 2023 11:46:42 +0000 (12:46 +0100)
Smatch Warns:
sound/soc/tegra/tegra20_ac97.c:321 tegra20_ac97_platform_probe()
warn: missing unwind goto?

The goto will set the "soc_ac97_ops" and "soc_ac97_bus" operations to
NULL.  But they are already NULL at this point so it is a no-op.
However, just for consistency, change the direct return to a goto.  No
functional change.

Signed-off-by: Zihao Wang <u202012060@hust.edu.cn>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/r/20230404084622.1202-1-u202012060@hust.edu.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/tegra/tegra20_ac97.c

index fea6955f7f4368bc68ace47704126aa5f8a1cfe6..c498145e76e05a6d874ae2ea23158652c9db5acb 100644 (file)
@@ -318,7 +318,8 @@ static int tegra20_ac97_platform_probe(struct platform_device *pdev)
        ac97->reset = devm_reset_control_get_exclusive(&pdev->dev, "ac97");
        if (IS_ERR(ac97->reset)) {
                dev_err(&pdev->dev, "Can't retrieve ac97 reset\n");
-               return PTR_ERR(ac97->reset);
+               ret = PTR_ERR(ac97->reset);
+               goto err;
        }
 
        ac97->clk_ac97 = devm_clk_get(&pdev->dev, NULL);