]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
Drivers: hv: vss: run only on supported host versions
authorOlaf Hering <olaf@aepfle.de>
Tue, 15 Dec 2015 00:01:42 +0000 (16:01 -0800)
committerJack Vogel <jack.vogel@oracle.com>
Thu, 1 Feb 2018 23:17:19 +0000 (15:17 -0800)
The Backup integration service on WS2012 has appearently trouble to
negotiate with a guest which does not support the provided util version.
Currently the VSS driver supports only version 5/0. A WS2012 offers only
version 1/x and 3/x, and vmbus_prep_negotiate_resp correctly returns an
empty icframe_vercnt/icmsg_vercnt. But the host ignores that and
continues to send ICMSGTYPE_NEGOTIATE messages. The result are weird
errors during boot and general misbehaviour.

Check the Windows version to work around the host bug, skip hv_vss_init
on WS2012 and older.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Orabug: 27426063
(cherry picked from commit ed9ba608e4851144af8c7061cbb19f751c73e998)
Signed-off-by: Jack Vogel <jack.vogel@oracle.com>
Reviewed-by: Ashok Vairavan <ashok.vairavan@oracle.com>
drivers/hv/hv_snapshot.c

index 5efb7a2350f9ffe6100dee8bafc2cb466de3f16d..3fba14e88f038ffeee4f256c87bdc66fafc01b07 100644 (file)
@@ -330,6 +330,11 @@ static void vss_on_reset(void)
 int
 hv_vss_init(struct hv_util_service *srv)
 {
+       if (vmbus_proto_version < VERSION_WIN8_1) {
+               pr_warn("Integration service 'Backup (volume snapshot)'"
+                       " not supported on this host version.\n");
+               return -ENOTSUPP;
+       }
        recv_buffer = srv->recv_buffer;
        vss_transaction.recv_channel = srv->channel;