]> www.infradead.org Git - linux.git/commitdiff
gcc-plugins: Remove duplicate included header file stringpool.h
authorThorsten Blum <thorsten.blum@toblux.com>
Sat, 29 Jun 2024 23:36:09 +0000 (01:36 +0200)
committerKees Cook <kees@kernel.org>
Mon, 8 Jul 2024 19:20:32 +0000 (12:20 -0700)
The header file stringpool.h is included for GCC version >= 8 and then
again for all versions.

Since the header file stringpool.h was added in GCC 4.9 and the kernel
currently requires GCC 5.1 as a minimum, remove the conditional include.

Including the header file only once removes the following warning
reported by make includecheck:

  stringpool.h is included more than once

However, it's important to include stringpool.h before attribs.h
because attribs.h uses some of its functions.

Compile-tested with GCC 14.

Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
Link: https://lore.kernel.org/r/20240629233608.278028-2-thorsten.blum@toblux.com
Signed-off-by: Kees Cook <kees@kernel.org>
scripts/gcc-plugins/gcc-common.h

index 1ae39b9f4a95effebba186e43ed2c9ce755a7f5f..3222c1070444fa260e7073cc80dcd37c85f1150f 100644 (file)
 #include "pass_manager.h"
 #include "predict.h"
 #include "ipa-utils.h"
-
-#if BUILDING_GCC_VERSION >= 8000
 #include "stringpool.h"
-#endif
-
 #include "attribs.h"
 #include "varasm.h"
 #include "stor-layout.h"
@@ -78,7 +74,6 @@
 #include "context.h"
 #include "tree-ssa-alias.h"
 #include "tree-ssa.h"
-#include "stringpool.h"
 #if BUILDING_GCC_VERSION >= 7000
 #include "tree-vrp.h"
 #endif