mlxsw: spectrum_matchall: Restrict sample action to be allowed only on ingress

HW supports packet sampling on ingress only. Check and fail if user
is adding sample on egress.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_matchall.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_matchall.c
index da1c05f44cec2d5d6cc1ac52ace2899e73eba1c9..c75661521bbc98301744fdefc417df684c183dd0 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_matchall.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_matchall.c
@@ -212,6 +212,11 @@ int mlxsw_sp_mall_replace(struct mlxsw_sp_flow_block *block,
                mall_entry->mirror.to_dev = act->dev;
        } else if (act->id == FLOW_ACTION_SAMPLE &&
                   protocol == htons(ETH_P_ALL)) {
+               if (!mall_entry->ingress) {
+                       NL_SET_ERR_MSG(f->common.extack, "Sample is not supported on egress");
+                       err = -EOPNOTSUPP;
+                       goto errout;
+               }
                if (act->sample.rate > MLXSW_REG_MPSC_RATE_MAX) {
                        NL_SET_ERR_MSG(f->common.extack, "Sample rate not supported");
                        err = -EOPNOTSUPP;