wifi: iwlwifi: carefully select the PNVM source

For newer device, and from API 100 (core 97), the PNVM should be taken
from the .ucode file, and not from an external .pnvm file.

In the current logic, if the PNVM doesn't exist in the .ucode file, we
fallback to fetching the .ucode file. This is wrong and hides bugs.

This fallback was needed for (a) old devices and (b) for newer
devices with an old API.

Since we no longer support those old APIs, (b) is not longer relevant.
We can, according to the device, select the right PNVM source
and fail if we couldn't find the PNVM there.

Add clear logic to select the expected PNVM source, and print an error
if we couldn't get the PNVM from there.

Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Reviewed-by: Daniel Gabay <daniel.gabay@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20250828111032.7e75d33e3c28.I87fbcd25bbee733d2612206b76c2d8593d0cbd39@changeid

diff --git a/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c b/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c
index 0421a84a44a8466a0428193b791ad7e7ae098fb1..f297e82d63d23468715b1b84085399d98497abe1 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c
+++ b/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c
@@ -266,17 +266,60 @@ static u8 *iwl_pnvm_get_from_fs(struct iwl_trans *trans, size_t *len)
        return data;
 }
 
+/**
+ * enum iwl_pnvm_source - different PNVM possible sources
+ *
+ * @IWL_PNVM_SOURCE_NONE: No PNVM.
+ * @IWL_PNVM_SOURCE_BIOS: PNVM should be read from BIOS.
+ * @IWL_PNVM_SOURCE_EXTERNAL: read .pnvm external file
+ * @IWL_PNVM_SOURCE_EMBEDDED: PNVM is embedded in the .ucode file.
+ */
+enum iwl_pnvm_source {
+       IWL_PNVM_SOURCE_NONE,
+       IWL_PNVM_SOURCE_BIOS,
+       IWL_PNVM_SOURCE_EXTERNAL,
+       IWL_PNVM_SOURCE_EMBEDDED
+};
+
+static enum iwl_pnvm_source iwl_select_pnvm_source(struct iwl_trans *trans,
+                                                  bool intel_sku)
+{
+
+       /* Get PNVM from BIOS for non-Intel SKU */
+       if (!intel_sku)
+               return IWL_PNVM_SOURCE_BIOS;
+
+       /* Before those devices, PNVM didn't exist at all */
+       if (trans->mac_cfg->device_family < IWL_DEVICE_FAMILY_AX210)
+               return IWL_PNVM_SOURCE_NONE;
+
+       /* After those devices, we moved to embedded PNVM */
+       if (trans->mac_cfg->device_family > IWL_DEVICE_FAMILY_AX210)
+               return IWL_PNVM_SOURCE_EMBEDDED;
+
+       /* For IWL_DEVICE_FAMILY_AX210, depends on the CRF */
+       if (CSR_HW_RFID_TYPE(trans->info.hw_rf_id) == IWL_CFG_RF_TYPE_GF)
+               return IWL_PNVM_SOURCE_EXTERNAL;
+
+       return IWL_PNVM_SOURCE_NONE;
+}
+
 static const u8 *iwl_get_pnvm_image(struct iwl_trans *trans_p, size_t *len,
                                    __le32 sku_id[3], const struct iwl_fw *fw)
 {
        struct pnvm_sku_package *package;
+       enum iwl_pnvm_source pnvm_src =
+               iwl_select_pnvm_source(trans_p, sku_id[2] == 0);
+       u8 *image = NULL;
 
-       /* Get PNVM from BIOS for non-Intel SKU */
-       if (sku_id[2]) {
+       IWL_DEBUG_FW(trans_p, "PNVM source %d\n", pnvm_src);
+
+       if (pnvm_src == IWL_PNVM_SOURCE_NONE)
+               return NULL;
+
+       if (pnvm_src == IWL_PNVM_SOURCE_BIOS) {
                package = iwl_uefi_get_pnvm(trans_p, len);
                if (!IS_ERR_OR_NULL(package)) {
-                       u8 *image = NULL;
-
                        if (*len >= sizeof(*package)) {
                                /* we need only the data */
                                *len -= sizeof(*package);
@@ -291,16 +334,26 @@ static const u8 *iwl_get_pnvm_image(struct iwl_trans *trans_p, size_t *len,
                        if (image)
                                return image;
                }
+
+               /* PNVM doesn't exist in BIOS. Find the fallback source */
+               pnvm_src = iwl_select_pnvm_source(trans_p, true);
+               IWL_DEBUG_FW(trans_p, "PNVM in BIOS doesn't exist, try %d\n",
+                            pnvm_src);
        }
 
-       if (fw->pnvm_data) {
-               *len = fw->pnvm_size;
+       if (pnvm_src == IWL_PNVM_SOURCE_EXTERNAL) {
+               image = iwl_pnvm_get_from_fs(trans_p, len);
+               if (image)
+                       return image;
+       }
 
+       if (pnvm_src == IWL_PNVM_SOURCE_EMBEDDED && fw->pnvm_data) {
+               *len = fw->pnvm_size;
                return fw->pnvm_data;
        }
 
-       /* If it's not available, or for Intel SKU, try from the filesystem */
-       return iwl_pnvm_get_from_fs(trans_p, len);
+       IWL_ERR(trans_p, "Couldn't get PNVM from required source: %d\n", pnvm_src);
+       return NULL;
 }
 
 static void