]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
bridge: mcast: Place netlink policy before validation functions
authorIdo Schimmel <idosch@nvidia.com>
Sat, 10 Dec 2022 14:56:22 +0000 (16:56 +0200)
committerJakub Kicinski <kuba@kernel.org>
Mon, 12 Dec 2022 23:33:36 +0000 (15:33 -0800)
Subsequent patches are going to add additional validation functions and
netlink policies. Some of these functions will need to perform parsing
using nla_parse_nested() and the new policies.

In order to keep all the policies next to each other, move the current
policy to before the validation functions.

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/bridge/br_mdb.c

index e3bd2122d5592aa11d7b1159c82aee40ebec989b..fcdd464cf99747fc767640cfbd137ba14a89a546 100644 (file)
@@ -663,6 +663,12 @@ errout:
        rtnl_set_sk_err(net, RTNLGRP_MDB, err);
 }
 
+static const struct nla_policy br_mdbe_attrs_pol[MDBE_ATTR_MAX + 1] = {
+       [MDBE_ATTR_SOURCE] = NLA_POLICY_RANGE(NLA_BINARY,
+                                             sizeof(struct in_addr),
+                                             sizeof(struct in6_addr)),
+};
+
 static bool is_valid_mdb_entry(struct br_mdb_entry *entry,
                               struct netlink_ext_ack *extack)
 {
@@ -748,12 +754,6 @@ static bool is_valid_mdb_source(struct nlattr *attr, __be16 proto,
        return true;
 }
 
-static const struct nla_policy br_mdbe_attrs_pol[MDBE_ATTR_MAX + 1] = {
-       [MDBE_ATTR_SOURCE] = NLA_POLICY_RANGE(NLA_BINARY,
-                                             sizeof(struct in_addr),
-                                             sizeof(struct in6_addr)),
-};
-
 static struct net_bridge_mcast *
 __br_mdb_choose_context(struct net_bridge *br,
                        const struct br_mdb_entry *entry,