]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
HID: hid-ntrig: fix unable to handle page fault in ntrig_report_version()
authorMinjong Kim <minbell.kim@samsung.com>
Wed, 13 Aug 2025 10:30:22 +0000 (19:30 +0900)
committerBenjamin Tissoires <bentiss@kernel.org>
Wed, 13 Aug 2025 11:12:51 +0000 (13:12 +0200)
in ntrig_report_version(), hdev parameter passed from hid_probe().
sending descriptor to /dev/uhid can make hdev->dev.parent->parent to null
if hdev->dev.parent->parent is null, usb_dev has
invalid address(0xffffffffffffff58) that hid_to_usb_dev(hdev) returned
when usb_rcvctrlpipe() use usb_dev,it trigger
page fault error for address(0xffffffffffffff58)

add null check logic to ntrig_report_version()
before calling hid_to_usb_dev()

Signed-off-by: Minjong Kim <minbell.kim@samsung.com>
Link: https://patch.msgid.link/20250813-hid-ntrig-page-fault-fix-v2-1-f98581f35106@samsung.com
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
drivers/hid/hid-ntrig.c

index 2738ce947434f904f32e9a1979b1681c66972ff9..0f76e241e0afb4adb38885a008a05edb24169ea9 100644 (file)
@@ -144,6 +144,9 @@ static void ntrig_report_version(struct hid_device *hdev)
        struct usb_device *usb_dev = hid_to_usb_dev(hdev);
        unsigned char *data = kmalloc(8, GFP_KERNEL);
 
+       if (!hid_is_usb(hdev))
+               return;
+
        if (!data)
                goto err_free;