drivers: pnp: proc.c: Removed unnecessary varibles

de, e are two variables of the type 'struct proc_dir_entry'
which can be removed to save memory. This also fixes a coding style
issue reported by checkpatch where we are suggested to make assignment
outside the if statement.

Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Anupama K Patil <anupamakpatil123@gmail.com>
Link: https://lore.kernel.org/r/20210422180322.7wlyg63kv3n2k6id@ubuntu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/pnp/isapnp/proc.c b/drivers/pnp/isapnp/proc.c
index 785a796430fa7963e0f40bdfa8b94184ddc9f90c..1ae458c02656cb152ec1cd7fea49d1f0d108446e 100644 (file)
--- a/drivers/pnp/isapnp/proc.c
+++ b/drivers/pnp/isapnp/proc.c
@@ -57,21 +57,20 @@ static const struct proc_ops isapnp_proc_bus_proc_ops = {
 static int isapnp_proc_attach_device(struct pnp_dev *dev)
 {
        struct pnp_card *bus = dev->card;
-       struct proc_dir_entry *de, *e;
        char name[16];
 
-       if (!(de = bus->procdir)) {
+       if (!bus->procdir) {
                sprintf(name, "%02x", bus->number);
-               de = bus->procdir = proc_mkdir(name, isapnp_proc_bus_dir);
-               if (!de)
+               bus->procdir = proc_mkdir(name, isapnp_proc_bus_dir);
+               if (!bus->procdir)
                        return -ENOMEM;
        }
        sprintf(name, "%02x", dev->number);
-       e = dev->procent = proc_create_data(name, S_IFREG | S_IRUGO, de,
+       dev->procent = proc_create_data(name, S_IFREG | S_IRUGO, bus->procdir,
                                            &isapnp_proc_bus_proc_ops, dev);
-       if (!e)
+       if (!dev->procent)
                return -ENOMEM;
-       proc_set_size(e, 256);
+       proc_set_size(dev->procent, 256);
        return 0;
 }