]> www.infradead.org Git - linux.git/commitdiff
perf stat: Disable metric thresholds for CSV and JSON metric-only mode
authorIan Rogers <irogers@google.com>
Thu, 17 Oct 2024 17:53:56 +0000 (10:53 -0700)
committerNamhyung Kim <namhyung@kernel.org>
Thu, 17 Oct 2024 19:44:26 +0000 (12:44 -0700)
These modes don't use the threshold, so don't compute it saving time
and potentially reducing events.

Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Yicong Yang <yangyicong@hisilicon.com>
Cc: Weilin Wang <weilin.wang@intel.com>
Cc: Will Deacon <will@kernel.org>
Cc: James Clark <james.clark@linaro.org>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Leo Yan <leo.yan@linux.dev>
Cc: Sumanth Korikkar <sumanthk@linux.ibm.com>
Cc: Thomas Richter <tmricht@linux.ibm.com>
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: John Garry <john.g.garry@oracle.com>
Link: https://lore.kernel.org/r/20241017175356.783793-8-irogers@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/builtin-stat.c

index b5e18853982cdb0f5a7186bef19eac56e5f10319..7639ecda6c05f000cac8c10d4d30a0acb65578e2 100644 (file)
@@ -2561,6 +2561,14 @@ int cmd_stat(int argc, const char **argv)
                goto out;
        }
 
+       if (stat_config.csv_output || (stat_config.metric_only && stat_config.json_output)) {
+               /*
+                * Current CSV and metric-only JSON output doesn't display the
+                * metric threshold so don't compute it.
+                */
+               stat_config.metric_no_threshold = true;
+       }
+
        if (stat_config.walltime_run_table && stat_config.run_count <= 1) {
                fprintf(stderr, "--table is only supported with -r\n");
                parse_options_usage(stat_usage, stat_options, "r", 1);