]> www.infradead.org Git - users/hch/misc.git/commitdiff
selftests: ncdevmem: remove sleep on rx
authorStanislav Fomichev <sdf@fomichev.me>
Fri, 12 Sep 2025 17:06:11 +0000 (10:06 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 16 Sep 2025 01:14:48 +0000 (18:14 -0700)
RX devmem sometimes fails on NIPA:

https://netdev-3.bots.linux.dev/vmksft-fbnic-qemu-dbg/results/294402/7-devmem-py/

Both RSS and flow steering are properly installed, but the wait_port_listen
fails. Try to remove sleep(1) to see if the cause of the failure is
spending too much time during RX setup. I don't see a good reason to
have sleep in the first place. If there needs to be a delay between
installing the rules and receiving the traffic, let's add it to the
callers (devmem.py) instead.

Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>
Reviewed-by: Mina Almasry <almasrymina@google.com>
Link: https://patch.msgid.link/20250912170611.676110-1-sdf@fomichev.me
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/drivers/net/hw/ncdevmem.c

index c0a22938bed2d5e2c2554c8ceed16b1dee530821..3288ed04ce0853a706ee91f0223edbcd4844747c 100644 (file)
@@ -872,8 +872,6 @@ static int do_server(struct memory_buffer *mem)
                goto err_reset_rss;
        }
 
-       sleep(1);
-
        if (bind_rx_queue(ifindex, mem->fd, create_queues(), num_queues, &ys)) {
                pr_err("Failed to bind");
                goto err_reset_flow_steering;