ASoC: rsnd: incidate irq error message

Current rsnd is using dev_dbg() if irq error happen,
but it makes debug very difficult if some strange things happen.
This patch uses dev_info() for it, and rename the macro name.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Message-Id: <87zgwglwyv.wl-kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/sh/rcar/rsnd.h b/sound/soc/sh/rcar/rsnd.h
index aec54552474dbbd8a23ec57f2b618af7590df544..9736a94b9c398f19aabd7e25bc3b30b899857e10 100644 (file)
--- a/sound/soc/sh/rcar/rsnd.h
+++ b/sound/soc/sh/rcar/rsnd.h
@@ -881,9 +881,10 @@ void rsnd_mod_make_sure(struct rsnd_mod *mod, enum rsnd_mod_type type);
  *
  * #define RSND_DEBUG_NO_IRQ_STATUS 1
  */
-#define rsnd_dbg_irq_status(dev, param...)             \
+#define rsnd_print_irq_status(dev, param...) do {      \
        if (!IS_BUILTIN(RSND_DEBUG_NO_IRQ_STATUS))      \
-               dev_dbg(dev, param)
+               dev_info(dev, param);                   \
+} while (0)
 
 /*
  * If you don't need rsnd_dai_call debug message,

diff --git a/sound/soc/sh/rcar/src.c b/sound/soc/sh/rcar/src.c
index 628af8f3920d71dabe8beb50bf12147457d481a1..7a7d6dc335a44524da569e5153907577f3d7fb74 100644 (file)
--- a/sound/soc/sh/rcar/src.c
+++ b/sound/soc/sh/rcar/src.c
@@ -17,7 +17,7 @@
 /*
  * you can enable below define if you don't need
  * SSI interrupt status debug message when debugging
- * see rsnd_dbg_irq_status()
+ * see rsnd_print_irq_status()
  *
  * #define RSND_DEBUG_NO_IRQ_STATUS 1
  */
@@ -421,8 +421,8 @@ static bool rsnd_src_error_occurred(struct rsnd_mod *mod)
        status0 = rsnd_mod_read(mod, SCU_SYS_STATUS0);
        status1 = rsnd_mod_read(mod, SCU_SYS_STATUS1);
        if ((status0 & val0) || (status1 & val1)) {
-               rsnd_dbg_irq_status(dev, "%s err status : 0x%08x, 0x%08x\n",
-                       rsnd_mod_name(mod), status0, status1);
+               rsnd_print_irq_status(dev, "%s err status : 0x%08x, 0x%08x\n",
+                                     rsnd_mod_name(mod), status0, status1);
 
                ret = true;
        }

diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c
index 2dceac994b37f5f896313841e2b51ed859a28892..ac920800af3764a1689de8a0457df88ebc48a27c 100644 (file)
--- a/sound/soc/sh/rcar/ssi.c
+++ b/sound/soc/sh/rcar/ssi.c
@@ -11,7 +11,7 @@
 /*
  * you can enable below define if you don't need
  * SSI interrupt status debug message when debugging
- * see rsnd_dbg_irq_status()
+ * see rsnd_print_irq_status()
  *
  * #define RSND_DEBUG_NO_IRQ_STATUS 1
  */
@@ -418,8 +418,8 @@ static bool rsnd_ssi_busif_err_status_clear(struct rsnd_mod *mod)
                        status &= 0xf << (id * 4);
 
                        if (status) {
-                               rsnd_dbg_irq_status(dev, "%s err status : 0x%08x\n",
-                                                   rsnd_mod_name(mod), status);
+                               rsnd_print_irq_status(dev, "%s err status : 0x%08x\n",
+                                                     rsnd_mod_name(mod), status);
                                rsnd_mod_write(mod,
                                               SSI_SYS_STATUS(i * 2),
                                               0xf << (id * 4));
@@ -433,8 +433,8 @@ static bool rsnd_ssi_busif_err_status_clear(struct rsnd_mod *mod)
                        status &= 0xf << 4;
 
                        if (status) {
-                               rsnd_dbg_irq_status(dev, "%s err status : 0x%08x\n",
-                                                   rsnd_mod_name(mod), status);
+                               rsnd_print_irq_status(dev, "%s err status : 0x%08x\n",
+                                                     rsnd_mod_name(mod), status);
                                rsnd_mod_write(mod,
                                               SSI_SYS_STATUS((i * 2) + 1),
                                               0xf << 4);
@@ -782,8 +782,8 @@ static void __rsnd_ssi_interrupt(struct rsnd_mod *mod,
 
        /* DMA only */
        if (is_dma && (status & (UIRQ | OIRQ))) {
-               rsnd_dbg_irq_status(dev, "%s err status : 0x%08x\n",
-                       rsnd_mod_name(mod), status);
+               rsnd_print_irq_status(dev, "%s err status : 0x%08x\n",
+                                     rsnd_mod_name(mod), status);
 
                stop = true;
        }