]> www.infradead.org Git - users/hch/misc.git/commitdiff
iio: adc: ad7173: check return value of spi_setup()
authorDavid Lechner <dlechner@baylibre.com>
Wed, 11 Jun 2025 14:40:16 +0000 (09:40 -0500)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Thu, 26 Jun 2025 18:32:52 +0000 (19:32 +0100)
Check the return value of spi_setup() and propagate the error in the
ad7173_probe() function. This is unlikely to happen since virtually
every SPI controller supports SPI_MODE_3, but still always a good idea
to check the return value.

Signed-off-by: David Lechner <dlechner@baylibre.com>
Link: https://patch.msgid.link/20250611-iio-adc-ad7173-check-spi_setup-return-v1-1-4d6f9ef0a2e4@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/ad7173.c

index b3e6bd2a55d717d5384616d9a8a160c57a8f1948..d75adb88af206f6123f5d556c2f5426dc313b662 100644 (file)
@@ -1765,7 +1765,9 @@ static int ad7173_probe(struct spi_device *spi)
        indio_dev->info = &ad7173_info;
 
        spi->mode = SPI_MODE_3;
-       spi_setup(spi);
+       ret = spi_setup(spi);
+       if (ret)
+               return ret;
 
        ret = ad_sd_init(&st->sd, indio_dev, spi, st->info->sd_info);
        if (ret)