]> www.infradead.org Git - users/willy/linux.git/commitdiff
dmaengine: Add a comment on why it's okay when kasprintf() fails
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 5 Feb 2025 14:57:11 +0000 (16:57 +0200)
committerVinod Koul <vkoul@kernel.org>
Mon, 10 Feb 2025 10:58:53 +0000 (16:28 +0530)
Add a comment in dma_request_chan() to clarify kasprintf() missing return
value check and it is correct functionality.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20250205145757.889247-4-andriy.shevchenko@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/dmaengine.c

index c1357d7f3dc6ca7899c4d68a039567e73b0f089d..dd4224d90f07085dbada7869fb4a438d41d9ef97 100644 (file)
@@ -854,8 +854,8 @@ struct dma_chan *dma_request_chan(struct device *dev, const char *name)
 
 found:
 #ifdef CONFIG_DEBUG_FS
-       chan->dbg_client_name = kasprintf(GFP_KERNEL, "%s:%s", dev_name(dev),
-                                         name);
+       chan->dbg_client_name = kasprintf(GFP_KERNEL, "%s:%s", dev_name(dev), name);
+       /* No functional issue if it fails, users are supposed to test before use */
 #endif
 
        chan->name = kasprintf(GFP_KERNEL, "dma:%s", name);