]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
net/mlx5: Eswitch, avoid redundant mask
authorEli Cohen <eli@mellanox.com>
Thu, 6 Feb 2020 13:13:36 +0000 (15:13 +0200)
committerSaeed Mahameed <saeedm@mellanox.com>
Fri, 28 Feb 2020 00:40:02 +0000 (16:40 -0800)
misc_params.source_port is a 16 bit field already so no need for
redundant masking against 0xffff. Also change local variables type to
u16.

Signed-off-by: Eli Cohen <eli@mellanox.com>
Reviewed-by: Roi Dayan <roid@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c

index dc08ed9339ab44a7beca458d45d611a47b4acb1f..f3a925e5ba88a2b2f51a9adec01d417b487fc3ec 100644 (file)
@@ -181,7 +181,7 @@ mlx5_eswitch_termtbl_actions_move(struct mlx5_flow_act *src,
 static bool mlx5_eswitch_offload_is_uplink_port(const struct mlx5_eswitch *esw,
                                                const struct mlx5_flow_spec *spec)
 {
-       u32 port_mask, port_value;
+       u16 port_mask, port_value;
 
        if (MLX5_CAP_ESW_FLOWTABLE(esw->dev, flow_source))
                return spec->flow_context.flow_source ==
@@ -191,7 +191,7 @@ static bool mlx5_eswitch_offload_is_uplink_port(const struct mlx5_eswitch *esw,
                             misc_parameters.source_port);
        port_value = MLX5_GET(fte_match_param, spec->match_value,
                              misc_parameters.source_port);
-       return (port_mask & port_value & 0xffff) == MLX5_VPORT_UPLINK;
+       return (port_mask & port_value) == MLX5_VPORT_UPLINK;
 }
 
 bool