]> www.infradead.org Git - linux.git/commitdiff
arm64: dts: amlogic: gxl: set i2c bias to pull-up
authorDa Xue <da@libre.computer>
Fri, 25 Apr 2025 20:31:18 +0000 (16:31 -0400)
committerNeil Armstrong <neil.armstrong@linaro.org>
Mon, 5 May 2025 12:28:24 +0000 (14:28 +0200)
GXL I2C pins need internal pull-up enabled to operate if there
is no external resistor. The pull-up is 60kohms per the datasheet.

We should set the bias when i2c pinmux is enabled.

Signed-off-by: Da Xue <da@libre.computer>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20250425203118.1444481-1-da@libre.computer
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
arch/arm64/boot/dts/amlogic/meson-gxl.dtsi

index 460c46cfad6a7ce909a746aa4a8f0dff880ad6d1..6be23241a7415c3ef7d9a15025fb1debce7faf51 100644 (file)
                                groups = "i2c_sck_ao",
                                       "i2c_sda_ao";
                                function = "i2c_ao";
-                               bias-disable;
+                               bias-pull-up;
                        };
                };
 
                                groups = "i2c_sck_a",
                                     "i2c_sda_a";
                                function = "i2c_a";
-                               bias-disable;
+                               bias-pull-up;
                        };
                };
 
                                groups = "i2c_sck_b",
                                      "i2c_sda_b";
                                function = "i2c_b";
-                               bias-disable;
+                               bias-pull-up;
                        };
                };
 
                                groups = "i2c_sck_c",
                                      "i2c_sda_c";
                                function = "i2c_c";
-                               bias-disable;
+                               bias-pull-up;
                        };
                };
 
                                groups = "i2c_sck_c_dv19",
                                      "i2c_sda_c_dv18";
                                function = "i2c_c";
-                               bias-disable;
+                               bias-pull-up;
                        };
                };