]> www.infradead.org Git - users/griffoul/linux.git/commitdiff
net: macb: Fix offset error in gem_update_stats
authorSean Anderson <sean.anderson@linux.dev>
Mon, 25 Aug 2025 17:21:34 +0000 (13:21 -0400)
committerJakub Kicinski <kuba@kernel.org>
Wed, 27 Aug 2025 00:36:28 +0000 (17:36 -0700)
hw_stats now has only one variable for tx_octets/rx_octets, so we should
only increment p once, not twice. This would cause the statistics to be
reported under the wrong categories in `ethtool -S --all-groups` (which
uses hw_stats) but not `ethtool -S` (which uses ethtool_stats).

Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
Fixes: f6af690a295a ("net: cadence: macb: Report standard stats")
Link: https://patch.msgid.link/20250825172134.681861-1-sean.anderson@linux.dev
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/cadence/macb_main.c

index b29c3beae0b254becde78a0923a04b5b12b4217b..10688545114708cd208ecd9a4264d6d2df993cba 100644 (file)
@@ -3090,7 +3090,7 @@ static void gem_update_stats(struct macb *bp)
                        /* Add GEM_OCTTXH, GEM_OCTRXH */
                        val = bp->macb_reg_readl(bp, offset + 4);
                        bp->ethtool_stats[i] += ((u64)val) << 32;
-                       *(p++) += ((u64)val) << 32;
+                       *p += ((u64)val) << 32;
                }
        }