]> www.infradead.org Git - users/hch/blktests.git/commitdiff
block/027: fix shellcheck errors
authorOmar Sandoval <osandov@fb.com>
Mon, 6 May 2019 21:24:53 +0000 (14:24 -0700)
committerOmar Sandoval <osandov@fb.com>
Mon, 6 May 2019 21:25:00 +0000 (14:25 -0700)
tests/block/027:59:35: note: Double quote to prevent globbing and word splitting. [SC2086]
tests/block/027:59:48: note: Double quote to prevent globbing and word splitting. [SC2086]

Signed-off-by: Omar Sandoval <osandov@fb.com>
tests/block/027

index ae464dd2d949f3d8a731013774c5b305d5a9f65e..0ff9e4c3897fbc254fdf69b62d496a8a8b41afa1 100755 (executable)
@@ -38,9 +38,10 @@ scsi_debug_stress_remove() {
 
        local dev fio_jobs scheds queue_path
        local cnt=1
+       fio_jobs=()
        for dev in "${SCSI_DEBUG_DEVICES[@]}"; do
                # create fio job
-               fio_jobs=$fio_jobs" --name=job1 --filename=/dev/$dev "
+               fio_jobs+=("--name=job$dev" "--filename=/dev/$dev")
 
                # set queue scheduler and queue_depth
                queue_path="/sys/block/$dev/queue"
@@ -56,7 +57,8 @@ scsi_debug_stress_remove() {
        fio --rw=randread --size=128G --direct=1 --ioengine=libaio \
                --iodepth=2048 --numjobs=$num_jobs --bs=4k \
                --group_reporting=1 --group_reporting=1 --runtime=$runtime \
-               --loops=10000 --cgroup=blktests/${TEST_NAME} $fio_jobs > "$FULL" 2>&1 &
+               --loops=10000 --cgroup="blktests/${TEST_NAME}" \
+               "${fio_jobs[@]}" > "$FULL" 2>&1 &
 
        sleep 6
        local device_path