]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ALSA: hda/conexant - Use cached pin control for Node 0x1d on HP EliteOne 1000 G2
authorVasiliy Kovalev <kovalev@altlinux.org>
Wed, 16 Oct 2024 08:07:13 +0000 (11:07 +0300)
committerTakashi Iwai <tiwai@suse.de>
Wed, 16 Oct 2024 08:29:57 +0000 (10:29 +0200)
The cached version avoids redundant commands to the codec, improving
stability and reducing unnecessary operations. This change ensures
better power management and reliable restoration of pin configurations,
especially after hibernation (S4) and other power transitions.

Fixes: 9988844c457f ("ALSA: hda/conexant - Fix audio routing for HP EliteOne 1000 G2")
Suggested-by: Kai-Heng Feng <kaihengf@nvidia.com>
Suggested-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org>
Link: https://patch.msgid.link/20241016080713.46801-1-kovalev@altlinux.org
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_conexant.c

index 956cb71c3bee118243620245e109f192b2771093..c74f6742c35955e51aefe10081bff3bd2290e05d 100644 (file)
@@ -330,7 +330,7 @@ static void cxt_fixup_update_pinctl(struct hda_codec *codec,
                 * This is the value stored in the codec register after
                 * the correct initialization of the previous windows boot.
                 */
-               snd_hda_set_pin_ctl(codec, 0x1d, AC_PINCTL_HP_EN);
+               snd_hda_set_pin_ctl_cache(codec, 0x1d, AC_PINCTL_HP_EN);
        }
 }