cifsd: handle unhashed dentry in ksmbd_vfs_mkdir

vfs_mkdir could return the dentry left unhashed negative on success.

Signed-off-by: Hyunchul Lee <hyc.lee@gmail.com>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Steve French <stfrench@microsoft.com>

diff --git a/fs/cifsd/vfs.c b/fs/cifsd/vfs.c
index b509c90d911f35d0657aac35e7573eea98cd3a01..bdc30a7b6d5235975ad16ff7bf6b3686c23e0273 100644 (file)
--- a/fs/cifsd/vfs.c
+++ b/fs/cifsd/vfs.c
@@ -190,14 +190,32 @@ int ksmbd_vfs_mkdir(struct ksmbd_work *work, const char *name, umode_t mode)
 
        mode |= S_IFDIR;
        err = vfs_mkdir(&init_user_ns, d_inode(path.dentry), dentry, mode);
-       if (!err) {
+       if (err)
+               goto out;
+       else if (d_unhashed(dentry)) {
+               struct dentry *d;
+
+               d = lookup_one_len(dentry->d_name.name,
+                              dentry->d_parent,
+                              dentry->d_name.len);
+               if (IS_ERR(d)) {
+                       err = PTR_ERR(d);
+                       goto out;
+               }
+               if (unlikely(d_is_negative(d))) {
+                       dput(d);
+                       err = -ENOENT;
+                       goto out;
+               }
+
                ksmbd_vfs_inherit_owner(work, d_inode(path.dentry),
-                       d_inode(dentry));
-       } else {
-               ksmbd_err("mkdir(%s): creation failed (err:%d)\n", name, err);
+                       d_inode(d));
+               dput(d);
        }
-
+out:
        done_path_create(&path, dentry);
+       if (err)
+               ksmbd_err("mkdir(%s): creation failed (err:%d)\n", name, err);
        return err;
 }