perf trace: Reduce #ifdefs for TEP_FIELD_IS_RELATIVE

Add a helper function that applies the mask to test, or returns false
if libtraceevent is too old or not present.

Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Athira Jajeev <atrajeev@linux.vnet.ibm.com>
Cc: Eelco Chaudron <echaudro@redhat.com>
Cc: German Gomez <german.gomez@arm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Kim Phillips <kim.phillips@amd.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sean Christopherson <seanjc@google.com>
Cc: Stephane Eranian <eranian@google.com>
Cc: Yang Jihong <yangjihong1@huawei.com>
Link: https://lore.kernel.org/r/20230111070641.1728726-2-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 46944eaba2e5421d24b8176c04b1e2f8dbd577f0..610fb60b1c0d2caaeaa337f37b130957ff08654c 100644 (file)
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -2731,10 +2731,8 @@ static size_t trace__fprintf_tp_fields(struct trace *trace, struct evsel *evsel,
                                offset = format_field__intval(field, sample, evsel->needs_swap);
                                syscall_arg.len = offset >> 16;
                                offset &= 0xffff;
-#if LIBTRACEEVENT_VERSION >= MAKE_LIBTRACEEVENT_VERSION(1, 5, 0)
-                               if (field->flags & TEP_FIELD_IS_RELATIVE)
+                               if (tep_field_is_relative(field->flags))
                                        offset += field->offset + field->size;
-#endif
                        }
 
                        val = (uintptr_t)(sample->raw_data + offset);

diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
index 98454f7a820c5f8a1803568c11302ad69f7eb8df..2b732bccabad275dcddf4d09d9f3f908828c2c80 100644 (file)
--- a/tools/perf/util/data-convert-bt.c
+++ b/tools/perf/util/data-convert-bt.c
@@ -322,10 +322,8 @@ static int add_tracepoint_field_value(struct ctf_writer *cw,
                offset = tmp_val;
                len = offset >> 16;
                offset &= 0xffff;
-#if LIBTRACEEVENT_VERSION >= MAKE_LIBTRACEEVENT_VERSION(1, 5, 0)
-               if (flags & TEP_FIELD_IS_RELATIVE)
+               if (tep_field_is_relative(flags))
                        offset += fmtf->offset + fmtf->size;
-#endif
        }
 
        if (flags & TEP_FIELD_IS_ARRAY) {

diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 296292fa2c047327bdcc2ae8f37c8a2680153212..8550638587e506f8845bd255c938284ad869e6e7 100644 (file)
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -2784,10 +2784,8 @@ void *evsel__rawptr(struct evsel *evsel, struct perf_sample *sample, const char
        if (field->flags & TEP_FIELD_IS_DYNAMIC) {
                offset = *(int *)(sample->raw_data + field->offset);
                offset &= 0xffff;
-#if LIBTRACEEVENT_VERSION >= MAKE_LIBTRACEEVENT_VERSION(1, 5, 0)
-               if (field->flags & TEP_FIELD_IS_RELATIVE)
+               if (tep_field_is_relative(field->flags))
                        offset += field->offset + field->size;
-#endif
        }
 
        return sample->raw_data + offset;

diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c
index 25a276710dfb532aa670e77b5408b7a3014d36ec..d948455e5ed4365651bd81b0f5ed87a860d244c2 100644 (file)
--- a/tools/perf/util/python.c
+++ b/tools/perf/util/python.c
@@ -442,10 +442,8 @@ tracepoint_field(struct pyrf_event *pe, struct tep_format_field *field)
                        offset  = val;
                        len     = offset >> 16;
                        offset &= 0xffff;
-#if LIBTRACEEVENT_VERSION >= MAKE_LIBTRACEEVENT_VERSION(1, 5, 0)
-                       if (field->flags & TEP_FIELD_IS_RELATIVE)
+                       if (tep_field_is_relative(field->flags))
                                offset += field->offset + field->size;
-#endif
                }
                if (field->flags & TEP_FIELD_IS_STRING &&
                    is_printable_array(data + offset, len)) {

diff --git a/tools/perf/util/scripting-engines/trace-event-perl.c b/tools/perf/util/scripting-engines/trace-event-perl.c
index 5bcec514f69711b5e895c8c01019b0682befc892..83fd2fd0ba165da54814e83822885f1f379b43df 100644 (file)
--- a/tools/perf/util/scripting-engines/trace-event-perl.c
+++ b/tools/perf/util/scripting-engines/trace-event-perl.c
@@ -393,10 +393,8 @@ static void perl_process_tracepoint(struct perf_sample *sample,
                        if (field->flags & TEP_FIELD_IS_DYNAMIC) {
                                offset = *(int *)(data + field->offset);
                                offset &= 0xffff;
-#if LIBTRACEEVENT_VERSION >= MAKE_LIBTRACEEVENT_VERSION(1, 5, 0)
-                               if (field->flags & TEP_FIELD_IS_RELATIVE)
+                               if (tep_field_is_relative(field->flags))
                                        offset += field->offset + field->size;
-#endif
                        } else
                                offset = field->offset;
                        XPUSHs(sv_2mortal(newSVpv((char *)data + offset, 0)));

diff --git a/tools/perf/util/scripting-engines/trace-event-python.c b/tools/perf/util/scripting-engines/trace-event-python.c
index 759ed6eafa3cb84c0b0335263b0bbec937ca8172..2c2697c5d02547c7ba8b21552e8e84971f0b5d5d 100644 (file)
--- a/tools/perf/util/scripting-engines/trace-event-python.c
+++ b/tools/perf/util/scripting-engines/trace-event-python.c
@@ -994,10 +994,8 @@ static void python_process_tracepoint(struct perf_sample *sample,
                                offset  = val;
                                len     = offset >> 16;
                                offset &= 0xffff;
-#if LIBTRACEEVENT_VERSION >= MAKE_LIBTRACEEVENT_VERSION(1, 5, 0)
-                               if (field->flags & TEP_FIELD_IS_RELATIVE)
+                               if (tep_field_is_relative(field->flags))
                                        offset += field->offset + field->size;
-#endif
                        }
                        if (field->flags & TEP_FIELD_IS_STRING &&
                            is_printable_array(data + offset, len)) {

diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index 3673912d9e6bba30d6e83bf9b1f5048efb1f0955..d7d0f997873aee2d0999adbadd54f704c9fc4b66 100644 (file)
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -2668,10 +2668,8 @@ static int64_t __sort__hde_cmp(struct perf_hpp_fmt *fmt,
                tep_read_number_field(field, a->raw_data, &dyn);
                offset = dyn & 0xffff;
                size = (dyn >> 16) & 0xffff;
-#if LIBTRACEEVENT_VERSION >= MAKE_LIBTRACEEVENT_VERSION(1, 5, 0)
-               if (field->flags & TEP_FIELD_IS_RELATIVE)
+               if (tep_field_is_relative(field->flags))
                        offset += field->offset + field->size;
-#endif
                /* record max width for output */
                if (size > hde->dynamic_len)
                        hde->dynamic_len = size;

diff --git a/tools/perf/util/trace-event.h b/tools/perf/util/trace-event.h
index 2e1b8641591c167dffbc49eaf54440648d1c734f..a0cff184b1cdcdc3d022c531ef520d6a2968bdff 100644 (file)
--- a/tools/perf/util/trace-event.h
+++ b/tools/perf/util/trace-event.h
@@ -140,4 +140,20 @@ int common_lock_depth(struct scripting_context *context);
 #define SAMPLE_FLAGS_BUF_SIZE 64
 int perf_sample__sprintf_flags(u32 flags, char *str, size_t sz);
 
+#if defined(LIBTRACEEVENT_VERSION) &&  LIBTRACEEVENT_VERSION >= MAKE_LIBTRACEEVENT_VERSION(1, 5, 0)
+#include <traceevent/event-parse.h>
+
+static inline bool tep_field_is_relative(unsigned long flags)
+{
+       return (flags & TEP_FIELD_IS_RELATIVE) != 0;
+}
+#else
+#include <linux/compiler.h>
+
+static inline bool tep_field_is_relative(unsigned long flags __maybe_unused)
+{
+       return false;
+}
+#endif
+
 #endif /* _PERF_UTIL_TRACE_EVENT_H */