]> www.infradead.org Git - users/hch/xfs.git/commitdiff
xfs: move RT bitmap and summary information to the rtgroup
authorChristoph Hellwig <hch@lst.de>
Sun, 4 Aug 2024 20:11:28 +0000 (22:11 +0200)
committerChristoph Hellwig <hch@lst.de>
Tue, 6 Aug 2024 13:05:09 +0000 (06:05 -0700)
Move the pointers to the RT bitmap and summary inodes as well as the
summary cache to the rtgroups structure to prepare for having a
separate bitmap and summary inodes for each rtgroup.

Code using the inodes now needs to operate on a rtgroup.  Where easily
possible such code is converted to iterate over all rtgroups, else
rtgroup 0 (the only one that can currently exist) is hardcoded.

Signed-off-by: Christoph Hellwig <hch@lst.de>
18 files changed:
fs/xfs/libxfs/xfs_bmap.c
fs/xfs/libxfs/xfs_rtbitmap.c
fs/xfs/libxfs/xfs_rtbitmap.h
fs/xfs/libxfs/xfs_rtgroup.c
fs/xfs/libxfs/xfs_rtgroup.h
fs/xfs/scrub/bmap.c
fs/xfs/scrub/fscounters.c
fs/xfs/scrub/repair.c
fs/xfs/scrub/repair.h
fs/xfs/scrub/rtbitmap.c
fs/xfs/scrub/rtsummary.c
fs/xfs/scrub/rtsummary_repair.c
fs/xfs/scrub/scrub.c
fs/xfs/xfs_discard.c
fs/xfs/xfs_fsmap.c
fs/xfs/xfs_mount.h
fs/xfs/xfs_qm.c
fs/xfs/xfs_rtalloc.c

index 3a8796f165d6dae52ae8e0fb2449056b0eb94c4b..a1ee8dc91d6bab90fa892fb53f9cc77f94446446 100644 (file)
@@ -5167,6 +5167,34 @@ xfs_bmap_del_extent_cow(
        ip->i_delayed_blks -= del->br_blockcount;
 }
 
+static int
+xfs_bmap_free_rtblocks(
+       struct xfs_trans        *tp,
+       struct xfs_bmbt_irec    *del)
+{
+       struct xfs_rtgroup      *rtg;
+       int                     error;
+
+       rtg = xfs_rtgroup_grab(tp->t_mountp, 0);
+       if (!rtg)
+               return -EIO;
+
+       /*
+        * Ensure the bitmap and summary inodes are locked and joined to the
+        * transaction before modifying them.
+        */
+       if (!(tp->t_flags & XFS_TRANS_RTBITMAP_LOCKED)) {
+               tp->t_flags |= XFS_TRANS_RTBITMAP_LOCKED;
+               xfs_rtgroup_lock(rtg, XFS_RTGLOCK_BITMAP);
+               xfs_rtgroup_trans_join(tp, rtg, XFS_RTGLOCK_BITMAP);
+       }
+
+       error = xfs_rtfree_blocks(tp, rtg, del->br_startblock,
+                       del->br_blockcount);
+       xfs_rtgroup_rele(rtg);
+       return error;
+}
+
 /*
  * Called by xfs_bmapi to update file extent records and the btree
  * after removing space.
@@ -5382,17 +5410,7 @@ xfs_bmap_del_extent_real(
                if (xfs_is_reflink_inode(ip) && whichfork == XFS_DATA_FORK) {
                        xfs_refcount_decrease_extent(tp, del);
                } else if (xfs_ifork_is_realtime(ip, whichfork)) {
-                       /*
-                        * Ensure the bitmap and summary inodes are locked
-                        * and joined to the transaction before modifying them.
-                        */
-                       if (!(tp->t_flags & XFS_TRANS_RTBITMAP_LOCKED)) {
-                               tp->t_flags |= XFS_TRANS_RTBITMAP_LOCKED;
-                               xfs_rtbitmap_lock(mp);
-                               xfs_rtbitmap_trans_join(tp);
-                       }
-                       error = xfs_rtfree_blocks(tp, del->br_startblock,
-                                       del->br_blockcount);
+                       error = xfs_bmap_free_rtblocks(tp, del);
                } else {
                        unsigned int    efi_flags = 0;
 
index 77d0d9dac1fa431585b1ee8a8c63c7aab129a8c7..2b3a60c54d5b8ae59db6bc6981ca9be8d349fd55 100644 (file)
@@ -90,12 +90,12 @@ xfs_rtbuf_get(
        if (issum) {
                cbpp = &args->sumbp;
                coffp = &args->sumoff;
-               ip = mp->m_rsumip;
+               ip = args->rtg->rtg_inodes[XFS_RTG_SUMMARY];
                type = XFS_BLFT_RTSUMMARY_BUF;
        } else {
                cbpp = &args->rbmbp;
                coffp = &args->rbmoff;
-               ip = mp->m_rbmip;
+               ip = args->rtg->rtg_inodes[XFS_RTG_BITMAP];
                type = XFS_BLFT_RTBITMAP_BUF;
        }
 
@@ -503,6 +503,7 @@ xfs_rtmodify_summary(
 {
        struct xfs_mount        *mp = args->mp;
        xfs_rtsumoff_t          so = xfs_rtsumoffs(mp, log, bbno);
+       uint8_t                 *rsum_cache = args->rtg->rtg_rsum_cache;
        unsigned int            infoword;
        xfs_suminfo_t           val;
        int                     error;
@@ -514,11 +515,11 @@ xfs_rtmodify_summary(
        infoword = xfs_rtsumoffs_to_infoword(mp, so);
        val = xfs_suminfo_add(args, infoword, delta);
 
-       if (mp->m_rsum_cache) {
-               if (val == 0 && log + 1 == mp->m_rsum_cache[bbno])
-                       mp->m_rsum_cache[bbno] = log;
-               if (val != 0 && log >= mp->m_rsum_cache[bbno])
-                       mp->m_rsum_cache[bbno] = log + 1;
+       if (rsum_cache) {
+               if (val == 0 && log + 1 == rsum_cache[bbno])
+                       rsum_cache[bbno] = log;
+               if (val != 0 && log >= rsum_cache[bbno])
+                       rsum_cache[bbno] = log + 1;
        }
 
        xfs_trans_log_rtsummary(args, infoword);
@@ -737,7 +738,7 @@ xfs_rtfree_range(
        /*
         * Find the next allocated block (end of allocated extent).
         */
-       error = xfs_rtfind_forw(args, end, mp->m_sb.sb_rextents - 1,
+       error = xfs_rtfind_forw(args, end, args->rtg->rtg_extents - 1,
                        &postblock);
        if (error)
                return error;
@@ -961,19 +962,22 @@ xfs_rtcheck_alloc_range(
 int
 xfs_rtfree_extent(
        struct xfs_trans        *tp,    /* transaction pointer */
+       struct xfs_rtgroup      *rtg,
        xfs_rtxnum_t            start,  /* starting rtext number to free */
        xfs_rtxlen_t            len)    /* length of extent freed */
 {
        struct xfs_mount        *mp = tp->t_mountp;
+       struct xfs_inode        *rbmip = rtg->rtg_inodes[XFS_RTG_BITMAP];
        struct xfs_rtalloc_args args = {
                .mp             = mp,
                .tp             = tp,
+               .rtg            = rtg,
        };
        int                     error;
        struct timespec64       atime;
 
-       ASSERT(mp->m_rbmip->i_itemp != NULL);
-       xfs_assert_ilocked(mp->m_rbmip, XFS_ILOCK_EXCL);
+       ASSERT(rbmip->i_itemp != NULL);
+       xfs_assert_ilocked(rbmip, XFS_ILOCK_EXCL);
 
        error = xfs_rtcheck_alloc_range(&args, start, len);
        if (error)
@@ -996,13 +1000,13 @@ xfs_rtfree_extent(
         */
        if (tp->t_frextents_delta + mp->m_sb.sb_frextents ==
            mp->m_sb.sb_rextents) {
-               if (!(mp->m_rbmip->i_diflags & XFS_DIFLAG_NEWRTBM))
-                       mp->m_rbmip->i_diflags |= XFS_DIFLAG_NEWRTBM;
+               if (!(rbmip->i_diflags & XFS_DIFLAG_NEWRTBM))
+                       rbmip->i_diflags |= XFS_DIFLAG_NEWRTBM;
 
-               atime = inode_get_atime(VFS_I(mp->m_rbmip));
+               atime = inode_get_atime(VFS_I(rbmip));
                atime.tv_sec = 0;
-               inode_set_atime_to_ts(VFS_I(mp->m_rbmip), atime);
-               xfs_trans_log_inode(tp, mp->m_rbmip, XFS_ILOG_CORE);
+               inode_set_atime_to_ts(VFS_I(rbmip), atime);
+               xfs_trans_log_inode(tp, rbmip, XFS_ILOG_CORE);
        }
        error = 0;
 out:
@@ -1018,6 +1022,7 @@ out:
 int
 xfs_rtfree_blocks(
        struct xfs_trans        *tp,
+       struct xfs_rtgroup      *rtg,
        xfs_fsblock_t           rtbno,
        xfs_filblks_t           rtlen)
 {
@@ -1038,21 +1043,23 @@ xfs_rtfree_blocks(
                return -EIO;
        }
 
-       return xfs_rtfree_extent(tp, xfs_rtb_to_rtx(mp, rtbno),
-                       xfs_rtb_to_rtx(mp, rtlen));
+       return xfs_rtfree_extent(tp, rtg, xfs_rtb_to_rtx(mp, rtbno),
+                       xfs_extlen_to_rtxlen(mp, rtlen));
 }
 
 /* Find all the free records within a given range. */
 int
 xfs_rtalloc_query_range(
-       struct xfs_mount                *mp,
+       struct xfs_rtgroup              *rtg,
        struct xfs_trans                *tp,
        xfs_rtxnum_t                    start,
        xfs_rtxnum_t                    end,
        xfs_rtalloc_query_range_fn      fn,
        void                            *priv)
 {
+       struct xfs_mount                *mp = rtg->rtg_mount;
        struct xfs_rtalloc_args         args = {
+               .rtg                    = rtg,
                .mp                     = mp,
                .tp                     = tp,
        };
@@ -1060,10 +1067,10 @@ xfs_rtalloc_query_range(
 
        if (start > end)
                return -EINVAL;
-       if (start == end || start >= mp->m_sb.sb_rextents)
+       if (start == end || start >= rtg->rtg_extents)
                return 0;
 
-       end = min(end, mp->m_sb.sb_rextents - 1);
+       end = min(end, rtg->rtg_extents - 1);
 
        /* Iterate the bitmap, looking for discrepancies. */
        while (start <= end) {
@@ -1086,7 +1093,7 @@ xfs_rtalloc_query_range(
                        rec.ar_startext = start;
                        rec.ar_extcount = rtend - start + 1;
 
-                       error = fn(mp, tp, &rec, priv);
+                       error = fn(rtg, tp, &rec, priv);
                        if (error)
                                break;
                }
@@ -1101,26 +1108,27 @@ xfs_rtalloc_query_range(
 /* Find all the free records. */
 int
 xfs_rtalloc_query_all(
-       struct xfs_mount                *mp,
+       struct xfs_rtgroup              *rtg,
        struct xfs_trans                *tp,
        xfs_rtalloc_query_range_fn      fn,
        void                            *priv)
 {
-       return xfs_rtalloc_query_range(mp, tp, 0, mp->m_sb.sb_rextents - 1, fn,
+       return xfs_rtalloc_query_range(rtg, tp, 0, rtg->rtg_extents - 1, fn,
                        priv);
 }
 
 /* Is the given extent all free? */
 int
 xfs_rtalloc_extent_is_free(
-       struct xfs_mount                *mp,
+       struct xfs_rtgroup              *rtg,
        struct xfs_trans                *tp,
        xfs_rtxnum_t                    start,
        xfs_rtxlen_t                    len,
        bool                            *is_free)
 {
        struct xfs_rtalloc_args         args = {
-               .mp                     = mp,
+               .mp                     = rtg->rtg_mount,
+               .rtg                    = rtg,
                .tp                     = tp,
        };
        xfs_rtxnum_t                    end;
@@ -1161,65 +1169,6 @@ xfs_rtsummary_blockcount(
        return XFS_B_TO_FSB(mp, rsumwords << XFS_WORDLOG);
 }
 
-/* Lock both realtime free space metadata inodes for a freespace update. */
-void
-xfs_rtbitmap_lock(
-       struct xfs_mount        *mp)
-{
-       xfs_ilock(mp->m_rbmip, XFS_ILOCK_EXCL | XFS_ILOCK_RTBITMAP);
-       xfs_ilock(mp->m_rsumip, XFS_ILOCK_EXCL | XFS_ILOCK_RTSUM);
-}
-
-/*
- * Join both realtime free space metadata inodes to the transaction.  The
- * ILOCKs will be released on transaction commit.
- */
-void
-xfs_rtbitmap_trans_join(
-       struct xfs_trans        *tp)
-{
-       xfs_trans_ijoin(tp, tp->t_mountp->m_rbmip, XFS_ILOCK_EXCL);
-       xfs_trans_ijoin(tp, tp->t_mountp->m_rsumip, XFS_ILOCK_EXCL);
-}
-
-/* Unlock both realtime free space metadata inodes after a freespace update. */
-void
-xfs_rtbitmap_unlock(
-       struct xfs_mount        *mp)
-{
-       xfs_iunlock(mp->m_rsumip, XFS_ILOCK_EXCL | XFS_ILOCK_RTSUM);
-       xfs_iunlock(mp->m_rbmip, XFS_ILOCK_EXCL | XFS_ILOCK_RTBITMAP);
-}
-
-/*
- * Lock the realtime free space metadata inodes for a freespace scan.  Callers
- * must walk metadata blocks in order of increasing file offset.
- */
-void
-xfs_rtbitmap_lock_shared(
-       struct xfs_mount        *mp,
-       unsigned int            rbmlock_flags)
-{
-       if (rbmlock_flags & XFS_RBMLOCK_BITMAP)
-               xfs_ilock(mp->m_rbmip, XFS_ILOCK_SHARED | XFS_ILOCK_RTBITMAP);
-
-       if (rbmlock_flags & XFS_RBMLOCK_SUMMARY)
-               xfs_ilock(mp->m_rsumip, XFS_ILOCK_SHARED | XFS_ILOCK_RTSUM);
-}
-
-/* Unlock the realtime free space metadata inodes after a freespace scan. */
-void
-xfs_rtbitmap_unlock_shared(
-       struct xfs_mount        *mp,
-       unsigned int            rbmlock_flags)
-{
-       if (rbmlock_flags & XFS_RBMLOCK_SUMMARY)
-               xfs_iunlock(mp->m_rsumip, XFS_ILOCK_SHARED | XFS_ILOCK_RTSUM);
-
-       if (rbmlock_flags & XFS_RBMLOCK_BITMAP)
-               xfs_iunlock(mp->m_rbmip, XFS_ILOCK_SHARED | XFS_ILOCK_RTBITMAP);
-}
-
 static int
 xfs_rtfile_alloc_blocks(
        struct xfs_inode        *ip,
@@ -1260,21 +1209,25 @@ out_trans_cancel:
 /* Get a buffer for the block. */
 static int
 xfs_rtfile_initialize_block(
-       struct xfs_inode        *ip,
+       struct xfs_rtgroup      *rtg,
+       enum xfs_rtg_inodes     type,
        xfs_fsblock_t           fsbno,
        void                    *data)
 {
-       struct xfs_mount        *mp = ip->i_mount;
+       struct xfs_mount        *mp = rtg->rtg_mount;
+       struct xfs_inode        *ip = rtg->rtg_inodes[type];
        struct xfs_trans        *tp;
        struct xfs_buf          *bp;
        const size_t            copylen = mp->m_blockwsize << XFS_WORDLOG;
        enum xfs_blft           buf_type;
        int                     error;
 
-       if (ip == mp->m_rsumip)
+       if (type == XFS_RTG_BITMAP)
+               buf_type = XFS_BLFT_RTBITMAP_BUF;
+       else if (type == XFS_RTG_SUMMARY)
                buf_type = XFS_BLFT_RTSUMMARY_BUF;
        else
-               buf_type = XFS_BLFT_RTBITMAP_BUF;
+               return -EINVAL;
 
        error = xfs_trans_alloc(mp, &M_RES(mp)->tr_growrtzero, 0, 0, 0, &tp);
        if (error)
@@ -1306,12 +1259,13 @@ xfs_rtfile_initialize_block(
  */
 int
 xfs_rtfile_initialize_blocks(
-       struct xfs_inode        *ip,            /* inode (bitmap/summary) */
+       struct xfs_rtgroup      *rtg,
+       enum xfs_rtg_inodes     type,
        xfs_fileoff_t           offset_fsb,     /* offÑ•et to start from */
        xfs_fileoff_t           end_fsb,        /* offÑ•et to allocate to */
        void                    *data)          /* data to fill the blocks */
 {
-       struct xfs_mount        *mp = ip->i_mount;
+       struct xfs_mount        *mp = rtg->rtg_mount;
        const size_t            copylen = mp->m_blockwsize << XFS_WORDLOG;
 
        while (offset_fsb < end_fsb) {
@@ -1319,8 +1273,8 @@ xfs_rtfile_initialize_blocks(
                xfs_filblks_t           i;
                int                     error;
 
-               error = xfs_rtfile_alloc_blocks(ip, offset_fsb,
-                               end_fsb - offset_fsb, &map);
+               error = xfs_rtfile_alloc_blocks(rtg->rtg_inodes[type],
+                               offset_fsb, end_fsb - offset_fsb, &map);
                if (error)
                        return error;
 
@@ -1330,7 +1284,7 @@ xfs_rtfile_initialize_blocks(
                 * Do this one block per transaction, to keep it simple.
                 */
                for (i = 0; i < map.br_blockcount; i++) {
-                       error = xfs_rtfile_initialize_block(ip,
+                       error = xfs_rtfile_initialize_block(rtg, type,
                                        map.br_startblock + i, data);
                        if (error)
                                return error;
@@ -1343,3 +1297,35 @@ xfs_rtfile_initialize_blocks(
 
        return 0;
 }
+
+int
+xfs_rtbitmap_create(
+       struct xfs_rtgroup      *rtg,
+       struct xfs_inode        *ip,
+       struct xfs_trans        *tp,
+       bool                    init)
+{
+       struct xfs_mount        *mp = rtg->rtg_mount;
+
+       ip->i_disk_size = mp->m_sb.sb_rbmblocks * mp->m_sb.sb_blocksize;
+       if (init && !xfs_has_rtgroups(mp)) {
+               ip->i_diflags |= XFS_DIFLAG_NEWRTBM;
+               inode_set_atime(VFS_I(ip), 0, 0);
+       }
+       xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE);
+       return 0;
+}
+
+int
+xfs_rtsummary_create(
+       struct xfs_rtgroup      *rtg,
+       struct xfs_inode        *ip,
+       struct xfs_trans        *tp,
+       bool                    init)
+{
+       struct xfs_mount        *mp = rtg->rtg_mount;
+
+       ip->i_disk_size = mp->m_rsumblocks * mp->m_sb.sb_blocksize;
+       xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE);
+       return 0;
+}
index 140513d1d6bcf1d5a13080b623c9a8e3fa98a932..e4994a3e461d33810fab4376165684f2cbf9c1f1 100644 (file)
@@ -6,7 +6,10 @@
 #ifndef __XFS_RTBITMAP_H__
 #define        __XFS_RTBITMAP_H__
 
+#include "xfs_rtgroup.h"
+
 struct xfs_rtalloc_args {
+       struct xfs_rtgroup      *rtg;
        struct xfs_mount        *mp;
        struct xfs_trans        *tp;
 
@@ -268,7 +271,7 @@ struct xfs_rtalloc_rec {
 };
 
 typedef int (*xfs_rtalloc_query_range_fn)(
-       struct xfs_mount                *mp,
+       struct xfs_rtgroup              *rtg,
        struct xfs_trans                *tp,
        const struct xfs_rtalloc_rec    *rec,
        void                            *priv);
@@ -291,53 +294,41 @@ int xfs_rtmodify_summary(struct xfs_rtalloc_args *args, int log,
                xfs_fileoff_t bbno, int delta);
 int xfs_rtfree_range(struct xfs_rtalloc_args *args, xfs_rtxnum_t start,
                xfs_rtxlen_t len);
-int xfs_rtalloc_query_range(struct xfs_mount *mp, struct xfs_trans *tp,
+int xfs_rtalloc_query_range(struct xfs_rtgroup *rtg, struct xfs_trans *tp,
                xfs_rtxnum_t start, xfs_rtxnum_t end,
                xfs_rtalloc_query_range_fn fn, void *priv);
-int xfs_rtalloc_query_all(struct xfs_mount *mp, struct xfs_trans *tp,
-                         xfs_rtalloc_query_range_fn fn,
-                         void *priv);
-int xfs_rtalloc_extent_is_free(struct xfs_mount *mp, struct xfs_trans *tp,
-                              xfs_rtxnum_t start, xfs_rtxlen_t len,
-                              bool *is_free);
-/*
- * Free an extent in the realtime subvolume.  Length is expressed in
- * realtime extents, as is the block number.
- */
-int                                    /* error */
-xfs_rtfree_extent(
-       struct xfs_trans        *tp,    /* transaction pointer */
-       xfs_rtxnum_t            start,  /* starting rtext number to free */
-       xfs_rtxlen_t            len);   /* length of extent freed */
-
+int xfs_rtalloc_query_all(struct xfs_rtgroup *rtg, struct xfs_trans *tp,
+               xfs_rtalloc_query_range_fn fn, void *priv);
+int xfs_rtalloc_extent_is_free(struct xfs_rtgroup *rtg, struct xfs_trans *tp,
+               xfs_rtxnum_t start, xfs_rtxlen_t len, bool *is_free);
+int xfs_rtfree_extent(struct xfs_trans *tp, struct xfs_rtgroup *rtg,
+               xfs_rtxnum_t start, xfs_rtxlen_t len);
 /* Same as above, but in units of rt blocks. */
-int xfs_rtfree_blocks(struct xfs_trans *tp, xfs_fsblock_t rtbno,
-               xfs_filblks_t rtlen);
+int xfs_rtfree_blocks(struct xfs_trans *tp, struct xfs_rtgroup *rtg,
+               xfs_fsblock_t rtbno, xfs_filblks_t rtlen);
 
 xfs_filblks_t xfs_rtbitmap_blockcount(struct xfs_mount *mp, xfs_rtbxlen_t
                rtextents);
 xfs_filblks_t xfs_rtsummary_blockcount(struct xfs_mount *mp,
                unsigned int rsumlevels, xfs_extlen_t rbmblocks);
 
-int xfs_rtfile_initialize_blocks(struct xfs_inode *ip,
-               xfs_fileoff_t offset_fsb, xfs_fileoff_t end_fsb, void *data);
+int xfs_rtfile_initialize_blocks(struct xfs_rtgroup *rtg,
+               enum xfs_rtg_inodes type, xfs_fileoff_t offset_fsb,
+               xfs_fileoff_t end_fsb, void *data);
+int xfs_rtbitmap_create(struct xfs_rtgroup *rtg, struct xfs_inode *ip,
+               struct xfs_trans *tp, bool init);
+int xfs_rtsummary_create(struct xfs_rtgroup *rtg, struct xfs_inode *ip,
+               struct xfs_trans *tp, bool init);
 
-void xfs_rtbitmap_lock(struct xfs_mount *mp);
-void xfs_rtbitmap_unlock(struct xfs_mount *mp);
-void xfs_rtbitmap_trans_join(struct xfs_trans *tp);
-
-/* Lock the rt bitmap inode in shared mode */
-#define XFS_RBMLOCK_BITMAP     (1U << 0)
-/* Lock the rt summary inode in shared mode */
-#define XFS_RBMLOCK_SUMMARY    (1U << 1)
-
-void xfs_rtbitmap_lock_shared(struct xfs_mount *mp,
-               unsigned int rbmlock_flags);
-void xfs_rtbitmap_unlock_shared(struct xfs_mount *mp,
-               unsigned int rbmlock_flags);
 #else /* CONFIG_XFS_RT */
 # define xfs_rtfree_extent(t,b,l)                      (-ENOSYS)
-# define xfs_rtfree_blocks(t,rb,rl)                    (-ENOSYS)
+
+static inline int xfs_rtfree_blocks(struct xfs_trans *tp,
+               struct xfs_rtgroup *rtg, xfs_fsblock_t rtbno,
+               xfs_filblks_t rtlen)
+{
+       return -ENOSYS;
+}
 # define xfs_rtalloc_query_range(m,t,l,h,f,p)          (-ENOSYS)
 # define xfs_rtalloc_query_all(m,t,f,p)                        (-ENOSYS)
 # define xfs_rtbitmap_read_buf(a,b)                    (-ENOSYS)
@@ -351,11 +342,6 @@ xfs_rtbitmap_blockcount(struct xfs_mount *mp, xfs_rtbxlen_t rtextents)
        return 0;
 }
 # define xfs_rtsummary_blockcount(mp, l, b)            (0)
-# define xfs_rtbitmap_lock(mp)                 do { } while (0)
-# define xfs_rtbitmap_trans_join(tp)           do { } while (0)
-# define xfs_rtbitmap_unlock(mp)               do { } while (0)
-# define xfs_rtbitmap_lock_shared(mp, lf)      do { } while (0)
-# define xfs_rtbitmap_unlock_shared(mp, lf)    do { } while (0)
 #endif /* CONFIG_XFS_RT */
 
 #endif /* __XFS_RTBITMAP_H__ */
index 35830ee936f685a71ab2978620e7393205b9953e..6d825d014c67cf03b2e34450f55f1fe04f7c00f8 100644 (file)
@@ -218,10 +218,16 @@ xfs_rtgroup_lock(
        ASSERT(!(rtglock_flags & XFS_RTGLOCK_BITMAP_SHARED) ||
               !(rtglock_flags & XFS_RTGLOCK_BITMAP));
 
-       if (rtglock_flags & XFS_RTGLOCK_BITMAP)
-               xfs_rtbitmap_lock(rtg->rtg_mount);
-       else if (rtglock_flags & XFS_RTGLOCK_BITMAP_SHARED)
-               xfs_rtbitmap_lock_shared(rtg->rtg_mount, XFS_RBMLOCK_BITMAP);
+       if (rtglock_flags & XFS_RTGLOCK_BITMAP) {
+               /*
+                * Lock both realtime free space metadata inodes for a freespace
+                * update.
+                */
+               xfs_ilock(rtg->rtg_inodes[XFS_RTG_BITMAP], XFS_ILOCK_EXCL);
+               xfs_ilock(rtg->rtg_inodes[XFS_RTG_SUMMARY], XFS_ILOCK_EXCL);
+       } else if (rtglock_flags & XFS_RTGLOCK_BITMAP_SHARED) {
+               xfs_ilock(rtg->rtg_inodes[XFS_RTG_BITMAP], XFS_ILOCK_SHARED);
+       }
 }
 
 /* Unlock metadata inodes associated with this rt group. */
@@ -234,10 +240,12 @@ xfs_rtgroup_unlock(
        ASSERT(!(rtglock_flags & XFS_RTGLOCK_BITMAP_SHARED) ||
               !(rtglock_flags & XFS_RTGLOCK_BITMAP));
 
-       if (rtglock_flags & XFS_RTGLOCK_BITMAP)
-               xfs_rtbitmap_unlock(rtg->rtg_mount);
-       else if (rtglock_flags & XFS_RTGLOCK_BITMAP_SHARED)
-               xfs_rtbitmap_unlock_shared(rtg->rtg_mount, XFS_RBMLOCK_BITMAP);
+       if (rtglock_flags & XFS_RTGLOCK_BITMAP) {
+               xfs_iunlock(rtg->rtg_inodes[XFS_RTG_SUMMARY], XFS_ILOCK_EXCL);
+               xfs_iunlock(rtg->rtg_inodes[XFS_RTG_BITMAP], XFS_ILOCK_EXCL);
+       } else if (rtglock_flags & XFS_RTGLOCK_BITMAP_SHARED) {
+               xfs_iunlock(rtg->rtg_inodes[XFS_RTG_BITMAP], XFS_ILOCK_SHARED);
+       }
 }
 
 /*
@@ -253,8 +261,12 @@ xfs_rtgroup_trans_join(
        ASSERT(!(rtglock_flags & ~XFS_RTGLOCK_ALL_FLAGS));
        ASSERT(!(rtglock_flags & XFS_RTGLOCK_BITMAP_SHARED));
 
-       if (rtglock_flags & XFS_RTGLOCK_BITMAP)
-               xfs_rtbitmap_trans_join(tp);
+       if (rtglock_flags & XFS_RTGLOCK_BITMAP) {
+               xfs_trans_ijoin(tp, rtg->rtg_inodes[XFS_RTG_BITMAP],
+                               XFS_ILOCK_EXCL);
+               xfs_trans_ijoin(tp, rtg->rtg_inodes[XFS_RTG_SUMMARY],
+                               XFS_ILOCK_EXCL);
+       }
 }
 
 #ifdef CONFIG_PROVE_LOCKING
@@ -322,6 +334,14 @@ struct xfs_rtginode_ops {
 };
 
 static const struct xfs_rtginode_ops xfs_rtginode_ops[XFS_RTG_MAX] = {
+       [XFS_RTG_BITMAP] = {
+               .name           = "bitmap",
+               .create         = xfs_rtbitmap_create,
+       },
+       [XFS_RTG_SUMMARY] = {
+               .name           = "summary",
+               .create         = xfs_rtsummary_create,
+       },
 };
 
 /* Return the shortname of this rtgroup inode. */
@@ -353,18 +373,36 @@ xfs_rtginode_load(
        struct xfs_trans        *tp)
 {
        struct xfs_mount        *mp = tp->t_mountp;
-       const char              *path;
        struct xfs_inode        *ip;
        int                     error;
 
        if (!xfs_rtginode_enabled(rtg, type))
                return 0;
 
-       path = xfs_rtginode_path(rtg->rtg_rgno, type);
-       if (!path)
-               return -ENOMEM;
-       error = xfs_metadir_load(tp, mp->m_rtdirip, path, S_IFREG, &ip);
-       kfree(path);
+       if (!xfs_has_rtgroups(mp)) {
+               xfs_ino_t       ino;
+
+               switch (type) {
+               case XFS_RTG_BITMAP:
+                       ino = mp->m_sb.sb_rbmino;
+                       break;
+               case XFS_RTG_SUMMARY:
+                       ino = mp->m_sb.sb_rsumino;
+                       break;
+               default:
+                       return 0;
+               }
+
+               error = xfs_metafile_iget(tp, ino, S_IFREG, &ip);
+       } else {
+               const char      *path;
+
+               path = xfs_rtginode_path(rtg->rtg_rgno, type);
+               if (!path)
+                       return -ENOMEM;
+               error = xfs_metadir_load(tp, mp->m_rtdirip, path, S_IFREG, &ip);
+               kfree(path);
+       }
 
        if (error)
                return error;
index bc69d0520ad77a04a0b94610624be8991e659e29..d5e6afbabbf36c7b6ec3404f93d69684024204b8 100644 (file)
@@ -10,6 +10,9 @@ struct xfs_mount;
 struct xfs_trans;
 
 enum xfs_rtg_inodes {
+       XFS_RTG_BITMAP,         /* allocation bitmap */
+       XFS_RTG_SUMMARY,        /* allocation summary */
+
        XFS_RTG_MAX,
 };
 
@@ -28,11 +31,19 @@ struct xfs_rtgroup {
        wait_queue_head_t       rtg_active_wq;/* woken active_ref falls to zero */
 
        /* per-rtgroup metadata inodes */
-       struct xfs_inode        *rtg_inodes[1 /* hack */];
+       struct xfs_inode        *rtg_inodes[XFS_RTG_MAX];
 
        /* Number of blocks in this group */
        xfs_rtxnum_t            rtg_extents;
 
+       /*
+        * Optional cache of rt summary level per bitmap block with the
+        * invariant that rtg_rsum_cache[bbno] > the maximum i for which
+        * rsum[i][bbno] != 0, or 0 if rsum[i][bbno] == 0 for all i.
+        * Reads and writes are serialized by the rsumip inode lock.
+        */
+       uint8_t                 *rtg_rsum_cache;
+
 #ifdef __KERNEL__
        /* -- kernel only structures below this line -- */
        spinlock_t              rtg_state_lock;
index dba0cddcbab9c2db9e772137a47a290f9e2de7e7..1946f0bcedda532c0835a866ef939e68537987eb 100644 (file)
@@ -19,6 +19,7 @@
 #include "xfs_bmap_btree.h"
 #include "xfs_rmap.h"
 #include "xfs_rmap_btree.h"
+#include "xfs_rtgroup.h"
 #include "xfs_health.h"
 #include "scrub/scrub.h"
 #include "scrub/common.h"
@@ -314,8 +315,20 @@ xchk_bmap_rt_iextent_xref(
        struct xchk_bmap_info   *info,
        struct xfs_bmbt_irec    *irec)
 {
+       int                     error;
+
+       error = xchk_rtgroup_init(info->sc,
+                       xfs_rtb_to_rgno(ip->i_mount, irec->br_startblock),
+                       &info->sc->sr);
+       if (!xchk_fblock_process_error(info->sc, info->whichfork,
+                       irec->br_startoff, &error))
+               goto out_free;
+
+       xchk_rtgroup_lock(&info->sc->sr, XCHK_RTGLOCK_ALL);
        xchk_xref_is_used_rt_space(info->sc, irec->br_startblock,
                        irec->br_blockcount);
+out_free:
+       xchk_rtgroup_free(info->sc, &info->sc->sr);
 }
 
 /* Cross-reference a single datadev extent record. */
index 1d3e98346933e1100d951af3ce77618b1d00aa0f..5f6449fc85dc0eda4b5148cb0dd43dbfcd80978d 100644 (file)
@@ -19,6 +19,7 @@
 #include "xfs_rtbitmap.h"
 #include "xfs_inode.h"
 #include "xfs_icache.h"
+#include "xfs_rtgroup.h"
 #include "scrub/scrub.h"
 #include "scrub/common.h"
 #include "scrub/trace.h"
@@ -388,7 +389,7 @@ retry:
 #ifdef CONFIG_XFS_RT
 STATIC int
 xchk_fscount_add_frextent(
-       struct xfs_mount                *mp,
+       struct xfs_rtgroup              *rtg,
        struct xfs_trans                *tp,
        const struct xfs_rtalloc_rec    *rec,
        void                            *priv)
@@ -409,6 +410,8 @@ xchk_fscount_count_frextents(
        struct xchk_fscounters  *fsc)
 {
        struct xfs_mount        *mp = sc->mp;
+       struct xfs_rtgroup      *rtg;
+       xfs_rgnumber_t          rgno;
        int                     error;
 
        fsc->frextents = 0;
@@ -416,19 +419,20 @@ xchk_fscount_count_frextents(
        if (!xfs_has_realtime(mp))
                return 0;
 
-       xfs_rtbitmap_lock_shared(sc->mp, XFS_RBMLOCK_BITMAP);
-       error = xfs_rtalloc_query_all(sc->mp, sc->tp,
-                       xchk_fscount_add_frextent, fsc);
-       if (error) {
-               xchk_set_incomplete(sc);
-               goto out_unlock;
+       for_each_rtgroup(mp, rgno, rtg) {
+               xfs_rtgroup_lock(rtg, XFS_RTGLOCK_BITMAP_SHARED);
+               error = xfs_rtalloc_query_all(rtg, sc->tp,
+                               xchk_fscount_add_frextent, fsc);
+               xfs_rtgroup_unlock(rtg, XFS_RTGLOCK_BITMAP_SHARED);
+               if (error) {
+                       xchk_set_incomplete(sc);
+                       xfs_rtgroup_rele(rtg);
+                       return error;
+               }
        }
 
        fsc->frextents_delayed = percpu_counter_sum(&mp->m_delalloc_rtextents);
-
-out_unlock:
-       xfs_rtbitmap_unlock_shared(sc->mp, XFS_RBMLOCK_BITMAP);
-       return error;
+       return 0;
 }
 #else
 STATIC int
index 01c0e863775d4562a536a97967f12086da7cf6d9..abe4f49bd098bc843f3991e016261d479ae8ef49 100644 (file)
@@ -21,6 +21,7 @@
 #include "xfs_rmap.h"
 #include "xfs_rmap_btree.h"
 #include "xfs_refcount_btree.h"
+#include "xfs_rtbitmap.h"
 #include "xfs_extent_busy.h"
 #include "xfs_ag.h"
 #include "xfs_ag_resv.h"
@@ -953,6 +954,29 @@ xrep_ag_init(
        return 0;
 }
 
+#ifdef CONFIG_XFS_RT
+/*
+ * Given a reference to a rtgroup structure, lock rtgroup btree inodes and
+ * create btree cursors.  Must only be called to repair a regular rt file.
+ */
+int
+xrep_rtgroup_init(
+       struct xfs_scrub        *sc,
+       struct xfs_rtgroup      *rtg,
+       struct xchk_rt          *sr,
+       unsigned int            rtglock_flags)
+{
+       ASSERT(sr->rtg == NULL);
+
+       xfs_rtgroup_lock(rtg, rtglock_flags);
+       sr->rtlock_flags = rtglock_flags;
+
+       /* Grab our own passive reference from the caller's ref. */
+       sr->rtg = xfs_rtgroup_hold(rtg);
+       return 0;
+}
+#endif /* CONFIG_XFS_RT */
+
 /* Reinitialize the per-AG block reservation for the AG we just fixed. */
 int
 xrep_reset_perag_resv(
@@ -1214,3 +1238,19 @@ xrep_buf_verify_struct(
 
        return fa == NULL;
 }
+
+/* Are we looking at a realtime metadata inode? */
+bool
+xrep_is_rtmeta_ino(
+       struct xfs_rtgroup      *rtg,
+       xfs_ino_t               ino)
+{
+       unsigned int            i;
+
+       for (i = 0; i < XFS_RTG_MAX; i++) {
+               if (rtg->rtg_inodes[i] && ino == rtg->rtg_inodes[i]->i_ino)
+                       return true;
+       }
+
+       return false;
+}
index 90f9cb3b5ad8ba92d459fea85a1fdc51438e275d..e8ccfe8008e0ef9741df98581fc4790e70b485e8 100644 (file)
@@ -8,6 +8,7 @@
 
 #include "xfs_quota_defs.h"
 
+struct xfs_rtgroup;
 struct xchk_stats_run;
 
 static inline int xrep_notsupported(struct xfs_scrub *sc)
@@ -106,6 +107,14 @@ int xrep_setup_inode(struct xfs_scrub *sc, const struct xfs_imap *imap);
 void xrep_ag_btcur_init(struct xfs_scrub *sc, struct xchk_ag *sa);
 int xrep_ag_init(struct xfs_scrub *sc, struct xfs_perag *pag,
                struct xchk_ag *sa);
+#ifdef CONFIG_XFS_RT
+int xrep_rtgroup_init(struct xfs_scrub *sc, struct xfs_rtgroup *rtg,
+               struct xchk_rt *sr, unsigned int rtglock_flags);
+#else
+# define xrep_rtgroup_init(sc, rtg, sr, lockflags)     (-ENOSYS)
+#endif /* CONFIG_XFS_RT */
+
+bool xrep_is_rtmeta_ino(struct xfs_rtgroup *rtg, xfs_ino_t ino);
 
 /* Metadata revalidators */
 
index 46583517377ffadd57e557897bc050428e84bd4c..7df7f4facc14fd7e6a057423e25a848033240c68 100644 (file)
@@ -35,6 +35,10 @@ xchk_setup_rtbitmap(
                return -ENOMEM;
        sc->buf = rtb;
 
+       error = xchk_rtgroup_init(sc, sc->sm->sm_agno, &sc->sr);
+       if (error)
+               return error;
+
        if (xchk_could_repair(sc)) {
                error = xrep_setup_rtbitmap(sc, rtb);
                if (error)
@@ -45,7 +49,8 @@ xchk_setup_rtbitmap(
        if (error)
                return error;
 
-       error = xchk_install_live_inode(sc, sc->mp->m_rbmip);
+       error = xchk_install_live_inode(sc,
+                       sc->sr.rtg->rtg_inodes[XFS_RTG_BITMAP]);
        if (error)
                return error;
 
@@ -53,18 +58,18 @@ xchk_setup_rtbitmap(
        if (error)
                return error;
 
-       xchk_ilock(sc, XFS_ILOCK_EXCL | XFS_ILOCK_RTBITMAP);
-
        /*
         * Now that we've locked the rtbitmap, we can't race with growfsrt
         * trying to expand the bitmap or change the size of the rt volume.
         * Hence it is safe to compute and check the geometry values.
         */
+       xchk_rtgroup_lock(&sc->sr, XCHK_RTGLOCK_ALL);
        if (mp->m_sb.sb_rblocks) {
                rtb->rextents = xfs_rtb_to_rtx(mp, mp->m_sb.sb_rblocks);
                rtb->rextslog = xfs_compute_rextslog(rtb->rextents);
                rtb->rbmblocks = xfs_rtbitmap_blockcount(mp, rtb->rextents);
        }
+
        return 0;
 }
 
@@ -73,11 +78,12 @@ xchk_setup_rtbitmap(
 /* Scrub a free extent record from the realtime bitmap. */
 STATIC int
 xchk_rtbitmap_rec(
-       struct xfs_mount        *mp,
+       struct xfs_rtgroup      *rtg,
        struct xfs_trans        *tp,
        const struct xfs_rtalloc_rec *rec,
        void                    *priv)
 {
+       struct xfs_mount        *mp = rtg->rtg_mount;
        struct xfs_scrub        *sc = priv;
        xfs_rtblock_t           startblock;
        xfs_filblks_t           blockcount;
@@ -140,18 +146,20 @@ xchk_rtbitmap(
        struct xfs_scrub        *sc)
 {
        struct xfs_mount        *mp = sc->mp;
+       struct xfs_rtgroup      *rtg = sc->sr.rtg;
+       struct xfs_inode        *rbmip = rtg->rtg_inodes[XFS_RTG_BITMAP];
        struct xchk_rtbitmap    *rtb = sc->buf;
        int                     error;
 
        /* Is sb_rextents correct? */
        if (mp->m_sb.sb_rextents != rtb->rextents) {
-               xchk_ino_set_corrupt(sc, mp->m_rbmip->i_ino);
+               xchk_ino_set_corrupt(sc, rbmip->i_ino);
                return 0;
        }
 
        /* Is sb_rextslog correct? */
        if (mp->m_sb.sb_rextslog != rtb->rextslog) {
-               xchk_ino_set_corrupt(sc, mp->m_rbmip->i_ino);
+               xchk_ino_set_corrupt(sc, rbmip->i_ino);
                return 0;
        }
 
@@ -160,17 +168,17 @@ xchk_rtbitmap(
         * case can we exceed 4bn bitmap blocks since the super field is a u32.
         */
        if (rtb->rbmblocks > U32_MAX) {
-               xchk_ino_set_corrupt(sc, mp->m_rbmip->i_ino);
+               xchk_ino_set_corrupt(sc, rbmip->i_ino);
                return 0;
        }
        if (mp->m_sb.sb_rbmblocks != rtb->rbmblocks) {
-               xchk_ino_set_corrupt(sc, mp->m_rbmip->i_ino);
+               xchk_ino_set_corrupt(sc, rbmip->i_ino);
                return 0;
        }
 
        /* The bitmap file length must be aligned to an fsblock. */
-       if (mp->m_rbmip->i_disk_size & mp->m_blockmask) {
-               xchk_ino_set_corrupt(sc, mp->m_rbmip->i_ino);
+       if (rbmip->i_disk_size & mp->m_blockmask) {
+               xchk_ino_set_corrupt(sc, rbmip->i_ino);
                return 0;
        }
 
@@ -179,8 +187,8 @@ xchk_rtbitmap(
         * growfsrt expands the bitmap file before updating sb_rextents, so the
         * file can be larger than sb_rbmblocks.
         */
-       if (mp->m_rbmip->i_disk_size < XFS_FSB_TO_B(mp, rtb->rbmblocks)) {
-               xchk_ino_set_corrupt(sc, mp->m_rbmip->i_ino);
+       if (rbmip->i_disk_size < XFS_FSB_TO_B(mp, rtb->rbmblocks)) {
+               xchk_ino_set_corrupt(sc, rbmip->i_ino);
                return 0;
        }
 
@@ -193,7 +201,7 @@ xchk_rtbitmap(
        if (error || (sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT))
                return error;
 
-       error = xfs_rtalloc_query_all(mp, sc->tp, xchk_rtbitmap_rec, sc);
+       error = xfs_rtalloc_query_all(rtg, sc->tp, xchk_rtbitmap_rec, sc);
        if (!xchk_fblock_process_error(sc, XFS_DATA_FORK, 0, &error))
                return error;
 
@@ -207,6 +215,8 @@ xchk_xref_is_used_rt_space(
        xfs_rtblock_t           rtbno,
        xfs_extlen_t            len)
 {
+       struct xfs_rtgroup      *rtg = sc->sr.rtg;
+       struct xfs_inode        *rbmip = rtg->rtg_inodes[XFS_RTG_BITMAP];
        xfs_rtxnum_t            startext;
        xfs_rtxnum_t            endext;
        bool                    is_free;
@@ -217,13 +227,10 @@ xchk_xref_is_used_rt_space(
 
        startext = xfs_rtb_to_rtx(sc->mp, rtbno);
        endext = xfs_rtb_to_rtx(sc->mp, rtbno + len - 1);
-       xfs_ilock(sc->mp->m_rbmip, XFS_ILOCK_SHARED | XFS_ILOCK_RTBITMAP);
-       error = xfs_rtalloc_extent_is_free(sc->mp, sc->tp, startext,
+       error = xfs_rtalloc_extent_is_free(rtg, sc->tp, startext,
                        endext - startext + 1, &is_free);
        if (!xchk_should_check_xref(sc, &error, NULL))
-               goto out_unlock;
+               return;
        if (is_free)
-               xchk_ino_xref_set_corrupt(sc, sc->mp->m_rbmip->i_ino);
-out_unlock:
-       xfs_iunlock(sc->mp->m_rbmip, XFS_ILOCK_SHARED | XFS_ILOCK_RTBITMAP);
+               xchk_ino_xref_set_corrupt(sc, rbmip->i_ino);
 }
index 7c7366c98338b03437053568d7dcba44fc3645ed..cc532aaf174ff37fd585ef934fc392ad2f39f7ca 100644 (file)
@@ -18,6 +18,7 @@
 #include "xfs_bmap.h"
 #include "xfs_sb.h"
 #include "xfs_exchmaps.h"
+#include "xfs_rtgroup.h"
 #include "scrub/scrub.h"
 #include "scrub/common.h"
 #include "scrub/trace.h"
@@ -46,12 +47,19 @@ xchk_setup_rtsummary(
        struct xchk_rtsummary   *rts;
        int                     error;
 
+       if (xchk_need_intent_drain(sc))
+               xchk_fsgates_enable(sc, XCHK_FSGATES_DRAIN);
+
        rts = kvzalloc(struct_size(rts, words, mp->m_blockwsize),
                        XCHK_GFP_FLAGS);
        if (!rts)
                return -ENOMEM;
        sc->buf = rts;
 
+       error = xchk_rtgroup_init(sc, sc->sm->sm_agno, &sc->sr);
+       if (error)
+               return error;
+
        if (xchk_could_repair(sc)) {
                error = xrep_setup_rtsummary(sc, rts);
                if (error)
@@ -73,7 +81,8 @@ xchk_setup_rtsummary(
        if (error)
                return error;
 
-       error = xchk_install_live_inode(sc, mp->m_rsumip);
+       error = xchk_install_live_inode(sc,
+                       sc->sr.rtg->rtg_inodes[XFS_RTG_SUMMARY]);
        if (error)
                return error;
 
@@ -81,20 +90,17 @@ xchk_setup_rtsummary(
        if (error)
                return error;
 
-       /*
-        * Locking order requires us to take the rtbitmap first.  We must be
-        * careful to unlock it ourselves when we are done with the rtbitmap
-        * file since the scrub infrastructure won't do that for us.  Only
-        * then we can lock the rtsummary inode.
-        */
-       xfs_ilock(mp->m_rbmip, XFS_ILOCK_SHARED | XFS_ILOCK_RTBITMAP);
-       xchk_ilock(sc, XFS_ILOCK_EXCL | XFS_ILOCK_RTSUM);
-
        /*
         * Now that we've locked the rtbitmap and rtsummary, we can't race with
         * growfsrt trying to expand the summary or change the size of the rt
         * volume.  Hence it is safe to compute and check the geometry values.
+        *
+        * Note that there is no strict requirement for an exclusive lock on the
+        * summary here, but to keep the locking APIs simple we lock both inodes
+        * exclusively here.  If we ever start caring about running concurrent
+        * fsmap with scrub this could be changed.
         */
+       xchk_rtgroup_lock(&sc->sr, XFS_RTGLOCK_BITMAP);
        if (mp->m_sb.sb_rblocks) {
                int             rextslog;
 
@@ -105,6 +111,7 @@ xchk_setup_rtsummary(
                rts->rsumblocks = xfs_rtsummary_blockcount(mp, rts->rsumlevels,
                                rts->rbmblocks);
        }
+
        return 0;
 }
 
@@ -155,11 +162,12 @@ xchk_rtsum_inc(
 /* Update the summary file to reflect the free extent that we've accumulated. */
 STATIC int
 xchk_rtsum_record_free(
-       struct xfs_mount                *mp,
+       struct xfs_rtgroup              *rtg,
        struct xfs_trans                *tp,
        const struct xfs_rtalloc_rec    *rec,
        void                            *priv)
 {
+       struct xfs_mount                *mp = rtg->rtg_mount;
        struct xfs_scrub                *sc = priv;
        xfs_fileoff_t                   rbmoff;
        xfs_rtblock_t                   rtbno;
@@ -182,7 +190,8 @@ xchk_rtsum_record_free(
        rtlen = xfs_rtx_to_rtb(mp, rec->ar_extcount);
 
        if (!xfs_verify_rtbext(mp, rtbno, rtlen)) {
-               xchk_ino_xref_set_corrupt(sc, mp->m_rbmip->i_ino);
+               xchk_ino_xref_set_corrupt(sc,
+                               rtg->rtg_inodes[XFS_RTG_BITMAP]->i_ino);
                return -EFSCORRUPTED;
        }
 
@@ -204,15 +213,16 @@ xchk_rtsum_compute(
        struct xfs_scrub        *sc)
 {
        struct xfs_mount        *mp = sc->mp;
+       struct xfs_rtgroup      *rtg = sc->sr.rtg;
        unsigned long long      rtbmp_blocks;
 
        /* If the bitmap size doesn't match the computed size, bail. */
        rtbmp_blocks = xfs_rtbitmap_blockcount(mp, mp->m_sb.sb_rextents);
-       if (XFS_FSB_TO_B(mp, rtbmp_blocks) != mp->m_rbmip->i_disk_size)
+       if (XFS_FSB_TO_B(mp, rtbmp_blocks) !=
+           rtg->rtg_inodes[XFS_RTG_BITMAP]->i_disk_size)
                return -EFSCORRUPTED;
 
-       return xfs_rtalloc_query_all(sc->mp, sc->tp, xchk_rtsum_record_free,
-                       sc);
+       return xfs_rtalloc_query_all(rtg, sc->tp, xchk_rtsum_record_free, sc);
 }
 
 /* Compare the rtsummary file against the one we computed. */
@@ -231,8 +241,9 @@ xchk_rtsum_compare(
        xfs_rtsumoff_t          sumoff = 0;
        int                     error = 0;
 
-       rts->args.mp = sc->mp;
+       rts->args.mp = mp;
        rts->args.tp = sc->tp;
+       rts->args.rtg = sc->sr.rtg;
 
        /* Mappings may not cross or lie beyond EOF. */
        endoff = XFS_B_TO_FSB(mp, ip->i_disk_size);
@@ -299,31 +310,34 @@ xchk_rtsummary(
        struct xfs_scrub        *sc)
 {
        struct xfs_mount        *mp = sc->mp;
+       struct xfs_rtgroup      *rtg = sc->sr.rtg;
+       struct xfs_inode        *rbmip = rtg->rtg_inodes[XFS_RTG_BITMAP];
+       struct xfs_inode        *rsumip = rtg->rtg_inodes[XFS_RTG_SUMMARY];
        struct xchk_rtsummary   *rts = sc->buf;
-       int                     error = 0;
+       int                     error;
 
        /* Is sb_rextents correct? */
        if (mp->m_sb.sb_rextents != rts->rextents) {
-               xchk_ino_set_corrupt(sc, mp->m_rbmip->i_ino);
-               goto out_rbm;
+               xchk_ino_set_corrupt(sc, rbmip->i_ino);
+               return 0;
        }
 
        /* Is m_rsumlevels correct? */
        if (mp->m_rsumlevels != rts->rsumlevels) {
-               xchk_ino_set_corrupt(sc, mp->m_rsumip->i_ino);
-               goto out_rbm;
+               xchk_ino_set_corrupt(sc, rsumip->i_ino);
+               return 0;
        }
 
        /* Is m_rsumsize correct? */
        if (mp->m_rsumblocks != rts->rsumblocks) {
-               xchk_ino_set_corrupt(sc, mp->m_rsumip->i_ino);
-               goto out_rbm;
+               xchk_ino_set_corrupt(sc, rsumip->i_ino);
+               return 0;
        }
 
        /* The summary file length must be aligned to an fsblock. */
-       if (mp->m_rsumip->i_disk_size & mp->m_blockmask) {
-               xchk_ino_set_corrupt(sc, mp->m_rsumip->i_ino);
-               goto out_rbm;
+       if (rsumip->i_disk_size & mp->m_blockmask) {
+               xchk_ino_set_corrupt(sc, rsumip->i_ino);
+               return 0;
        }
 
        /*
@@ -331,15 +345,15 @@ xchk_rtsummary(
         * growfsrt expands the summary file before updating sb_rextents, so
         * the file can be larger than rsumsize.
         */
-       if (mp->m_rsumip->i_disk_size < XFS_FSB_TO_B(mp, rts->rsumblocks)) {
-               xchk_ino_set_corrupt(sc, mp->m_rsumip->i_ino);
-               goto out_rbm;
+       if (rsumip->i_disk_size < XFS_FSB_TO_B(mp, rts->rsumblocks)) {
+               xchk_ino_set_corrupt(sc, rsumip->i_ino);
+               return 0;
        }
 
        /* Invoke the fork scrubber. */
        error = xchk_metadata_inode_forks(sc);
        if (error || (sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT))
-               goto out_rbm;
+               return error;
 
        /* Construct the new summary file from the rtbitmap. */
        error = xchk_rtsum_compute(sc);
@@ -348,23 +362,12 @@ xchk_rtsummary(
                 * EFSCORRUPTED means the rtbitmap is corrupt, which is an xref
                 * error since we're checking the summary file.
                 */
-               xchk_ino_xref_set_corrupt(sc, mp->m_rbmip->i_ino);
-               error = 0;
-               goto out_rbm;
+               xchk_ino_set_corrupt(sc, rbmip->i_ino);
+               return 0;
        }
        if (error)
-               goto out_rbm;
+               return error;
 
        /* Does the computed summary file match the actual rtsummary file? */
-       error = xchk_rtsum_compare(sc);
-
-out_rbm:
-       /*
-        * Unlock the rtbitmap since we're done with it.  All other writers of
-        * the rt free space metadata grab the bitmap and summary ILOCKs in
-        * that order, so we're still protected against allocation activities
-        * even if we continue on to the repair function.
-        */
-       xfs_iunlock(mp->m_rbmip, XFS_ILOCK_SHARED | XFS_ILOCK_RTBITMAP);
-       return error;
+       return xchk_rtsum_compare(sc);
 }
index 7deeb948cb7027665bc1d01cc4306a7408f346b1..1688380988007fff600a91967c3474f93feec2e3 100644 (file)
@@ -76,8 +76,9 @@ xrep_rtsummary_prep_buf(
        union xfs_suminfo_raw   *ondisk;
        int                     error;
 
-       rts->args.mp = sc->mp;
+       rts->args.mp = mp;
        rts->args.tp = sc->tp;
+       rts->args.rtg = sc->sr.rtg;
        rts->args.sumbp = bp;
        ondisk = xfs_rsumblock_infoptr(&rts->args, 0);
        rts->args.sumbp = NULL;
@@ -162,8 +163,8 @@ xrep_rtsummary(
                return error;
 
        /* Reset incore state and blow out the summary cache. */
-       if (mp->m_rsum_cache)
-               memset(mp->m_rsum_cache, 0xFF, mp->m_sb.sb_rbmblocks);
+       if (sc->sr.rtg->rtg_rsum_cache)
+               memset(sc->sr.rtg->rtg_rsum_cache, 0xFF, mp->m_sb.sb_rbmblocks);
 
        mp->m_rsumlevels = rts->rsumlevels;
        mp->m_rsumblocks = rts->rsumblocks;
index fe1b3dfe4848787dec2d6f42a3cac80cf102f10e..8a7e1feb38a448a928e976307c21dc23b452a21f 100644 (file)
@@ -384,13 +384,13 @@ static const struct xchk_meta_ops meta_scrub_ops[] = {
                .repair = xrep_parent,
        },
        [XFS_SCRUB_TYPE_RTBITMAP] = {   /* realtime bitmap */
-               .type   = ST_FS,
+               .type   = ST_RTGROUP,
                .setup  = xchk_setup_rtbitmap,
                .scrub  = xchk_rtbitmap,
                .repair = xrep_rtbitmap,
        },
        [XFS_SCRUB_TYPE_RTSUM] = {      /* realtime summary */
-               .type   = ST_FS,
+               .type   = ST_RTGROUP,
                .setup  = xchk_setup_rtsummary,
                .scrub  = xchk_rtsummary,
                .repair = xrep_rtsummary,
index b61540ddd1a5e34d02bcc0b611ea273dedfe5243..8c5672e054aee414300c4592073e95983c434edd 100644 (file)
@@ -21,6 +21,7 @@
 #include "xfs_ag.h"
 #include "xfs_health.h"
 #include "xfs_rtbitmap.h"
+#include "xfs_rtgroup.h"
 
 /*
  * Notes on an efficient, low latency fstrim algorithm
@@ -515,7 +516,7 @@ xfs_discard_rtdev_extents(
 
 static int
 xfs_trim_gather_rtextent(
-       struct xfs_mount                *mp,
+       struct xfs_rtgroup              *rtg,
        struct xfs_trans                *tp,
        const struct xfs_rtalloc_rec    *rec,
        void                            *priv)
@@ -534,12 +535,12 @@ xfs_trim_gather_rtextent(
                return -ECANCELED;
        }
 
-       rbno = xfs_rtx_to_rtb(mp, rec->ar_startext);
-       rlen = xfs_rtx_to_rtb(mp, rec->ar_extcount);
+       rbno = xfs_rtx_to_rtb(rtg->rtg_mount, rec->ar_startext);
+       rlen = xfs_rtx_to_rtb(rtg->rtg_mount, rec->ar_extcount);
 
        /* Ignore too small. */
        if (rlen < tr->minlen_fsb) {
-               trace_xfs_discard_rttoosmall(mp, rbno, rlen);
+               trace_xfs_discard_rttoosmall(rtg->rtg_mount, rbno, rlen);
                return 0;
        }
 
@@ -558,71 +559,51 @@ xfs_trim_gather_rtextent(
 }
 
 static int
-xfs_trim_rtdev_extents(
-       struct xfs_mount        *mp,
-       xfs_daddr_t             start,
-       xfs_daddr_t             end,
+xfs_trim_rtg_extents(
+       struct xfs_rtgroup      *rtg,
+       xfs_rtxnum_t            low,
+       xfs_rtxnum_t            high,
        xfs_daddr_t             minlen,
        uint64_t                *blocks_trimmed)
 {
+       struct xfs_mount        *mp = rtg->rtg_mount;
        struct xfs_trim_rtdev   tr = {
                .blocks_trimmed = blocks_trimmed,
                .minlen_fsb     = XFS_BB_TO_FSB(mp, minlen),
+               .extent_list    = LIST_HEAD_INIT(tr.extent_list),
        };
-       xfs_rtxnum_t            low, high;
        struct xfs_trans        *tp;
-       xfs_daddr_t             rtdev_daddr;
        int                     error;
 
-       INIT_LIST_HEAD(&tr.extent_list);
-
-       /* Shift the start and end downwards to match the rt device. */
-       rtdev_daddr = XFS_FSB_TO_BB(mp, mp->m_sb.sb_dblocks);
-       if (start > rtdev_daddr)
-               start -= rtdev_daddr;
-       else
-               start = 0;
-
-       if (end <= rtdev_daddr)
-               return 0;
-       end -= rtdev_daddr;
-
        error = xfs_trans_alloc_empty(mp, &tp);
        if (error)
                return error;
 
-       end = min_t(xfs_daddr_t, end,
-                       XFS_FSB_TO_BB(mp, mp->m_sb.sb_rblocks) - 1);
-
-       /* Convert the rt blocks to rt extents */
-       low = xfs_rtb_to_rtxup(mp, XFS_BB_TO_FSB(mp, start));
-       high = xfs_rtb_to_rtx(mp, XFS_BB_TO_FSBT(mp, end));
-
        /*
         * Walk the free ranges between low and high.  The query_range function
         * trims the extents returned.
         */
        do {
                tr.stop_rtx = low + (mp->m_sb.sb_blocksize * NBBY);
-               xfs_rtbitmap_lock_shared(mp, XFS_RBMLOCK_BITMAP);
-               error = xfs_rtalloc_query_range(mp, tp, low, high,
+               xfs_rtgroup_lock(rtg, XFS_RTGLOCK_BITMAP_SHARED);
+               error = xfs_rtalloc_query_range(rtg, tp, low, high,
                                xfs_trim_gather_rtextent, &tr);
 
                if (error == -ECANCELED)
                        error = 0;
                if (error) {
-                       xfs_rtbitmap_unlock_shared(mp, XFS_RBMLOCK_BITMAP);
+                       xfs_rtgroup_unlock(rtg, XFS_RTGLOCK_BITMAP_SHARED);
                        xfs_discard_free_rtdev_extents(&tr);
                        break;
                }
 
                if (list_empty(&tr.extent_list)) {
-                       xfs_rtbitmap_unlock_shared(mp, XFS_RBMLOCK_BITMAP);
+                       xfs_rtgroup_unlock(rtg, XFS_RTGLOCK_BITMAP_SHARED);
                        break;
                }
 
                error = xfs_discard_rtdev_extents(mp, &tr);
-               xfs_rtbitmap_unlock_shared(mp, XFS_RBMLOCK_BITMAP);
+               xfs_rtgroup_unlock(rtg, XFS_RTGLOCK_BITMAP_SHARED);
                if (error)
                        break;
 
@@ -632,6 +613,57 @@ xfs_trim_rtdev_extents(
        xfs_trans_cancel(tp);
        return error;
 }
+
+static int
+xfs_trim_rtdev_extents(
+       struct xfs_mount        *mp,
+       xfs_daddr_t             start,
+       xfs_daddr_t             end,
+       xfs_daddr_t             minlen,
+       uint64_t                *blocks_trimmed)
+{
+       xfs_rtblock_t           start_rtbno, end_rtbno;
+       xfs_rtxnum_t            start_rtx, end_rtx;
+       xfs_rgnumber_t          rgno, end_rgno;
+       int                     last_error = 0, error;
+       struct xfs_rtgroup      *rtg;
+
+       /* Shift the start and end downwards to match the rt device. */
+       start_rtbno = xfs_daddr_to_rtb(mp, start);
+       if (start_rtbno > mp->m_sb.sb_dblocks)
+               start_rtbno -= mp->m_sb.sb_dblocks;
+       else
+               start_rtbno = 0;
+       start_rtx = xfs_rtb_to_rtx(mp, start_rtbno);
+       rgno = xfs_rtb_to_rgno(mp, start_rtbno);
+
+       end_rtbno = xfs_daddr_to_rtb(mp, end);
+       if (end_rtbno <= mp->m_sb.sb_dblocks)
+               return 0;
+       end_rtbno -= mp->m_sb.sb_dblocks;
+       end_rtx = xfs_rtb_to_rtx(mp, end_rtbno + mp->m_sb.sb_rextsize - 1);
+       end_rgno = xfs_rtb_to_rgno(mp, end_rtbno);
+
+       for_each_rtgroup_range(mp, rgno, end_rgno, rtg) {
+               xfs_rtxnum_t    rtg_end = rtg->rtg_extents;
+
+               if (rgno == end_rgno)
+                       rtg_end = min(rtg_end, end_rtx);
+
+               error = xfs_trim_rtg_extents(rtg, start_rtx, rtg_end, minlen,
+                               blocks_trimmed);
+               if (error)
+                       last_error = error;
+
+               if (xfs_trim_should_stop()) {
+                       xfs_rtgroup_rele(rtg);
+                       break;
+               }
+               start_rtx = 0;
+       }
+
+       return last_error;
+}
 #else
 # define xfs_trim_rtdev_extents(m,s,e,n,b)     (-EOPNOTSUPP)
 #endif /* CONFIG_XFS_RT */
index f6bf3fa362b6c5d1acf7c0170886116e4bff16f0..a82ed4e6bca60b77943b8c0a025f6e798ba3ed0a 100644 (file)
@@ -697,29 +697,22 @@ xfs_getfsmap_logdev(
 /* Transform a rtbitmap "record" into a fsmap */
 STATIC int
 xfs_getfsmap_rtdev_rtbitmap_helper(
-       struct xfs_mount                *mp,
+       struct xfs_rtgroup              *rtg,
        struct xfs_trans                *tp,
        const struct xfs_rtalloc_rec    *rec,
        void                            *priv)
 {
+       struct xfs_mount                *mp = rtg->rtg_mount;
        struct xfs_getfsmap_info        *info = priv;
-       struct xfs_rmap_irec            irec;
-       xfs_rtblock_t                   rtbno;
-       xfs_daddr_t                     rec_daddr, len_daddr;
-
-       rtbno = xfs_rtx_to_rtb(mp, rec->ar_startext);
-       rec_daddr = XFS_FSB_TO_BB(mp, rtbno);
-       irec.rm_startblock = rtbno;
-
-       rtbno = xfs_rtx_to_rtb(mp, rec->ar_extcount);
-       len_daddr = XFS_FSB_TO_BB(mp, rtbno);
-       irec.rm_blockcount = rtbno;
-
-       irec.rm_owner = XFS_RMAP_OWN_NULL;      /* "free" */
-       irec.rm_offset = 0;
-       irec.rm_flags = 0;
-
-       return xfs_getfsmap_helper(tp, info, &irec, rec_daddr, len_daddr);
+       struct xfs_rmap_irec            irec = {
+               .rm_startblock  = xfs_rtx_to_rtb(mp, rec->ar_startext),
+               .rm_blockcount  = xfs_rtxlen_to_extlen(mp, rec->ar_extcount),
+               .rm_owner       = XFS_RMAP_OWN_NULL, /* "free" */
+       };
+
+       return xfs_getfsmap_helper(tp, info, &irec,
+                       XFS_FSB_TO_BB(mp, irec.rm_startblock),
+                       XFS_FSB_TO_BB(mp, irec.rm_blockcount));
 }
 
 /* Execute a getfsmap query against the realtime device rtbitmap. */
@@ -729,59 +722,69 @@ xfs_getfsmap_rtdev_rtbitmap(
        const struct xfs_fsmap          *keys,
        struct xfs_getfsmap_info        *info)
 {
-
-       struct xfs_rtalloc_rec          ahigh = { 0 };
        struct xfs_mount                *mp = tp->t_mountp;
-       xfs_rtblock_t                   start_rtb;
-       xfs_rtblock_t                   end_rtb;
-       xfs_rtxnum_t                    high;
+       xfs_rtblock_t                   start_rtbno, end_rtbno;
+       xfs_rtxnum_t                    start_rtx, end_rtx;
+       xfs_rgnumber_t                  rgno, end_rgno;
+       struct xfs_rtgroup              *rtg;
        uint64_t                        eofs;
        int                             error;
 
-       eofs = XFS_FSB_TO_BB(mp, xfs_rtx_to_rtb(mp, mp->m_sb.sb_rextents));
+       eofs = XFS_FSB_TO_BB(mp, mp->m_sb.sb_rblocks);
        if (keys[0].fmr_physical >= eofs)
                return 0;
-       start_rtb = XFS_BB_TO_FSBT(mp,
-                               keys[0].fmr_physical + keys[0].fmr_length);
-       end_rtb = XFS_BB_TO_FSB(mp, min(eofs - 1, keys[1].fmr_physical));
 
        info->missing_owner = XFS_FMR_OWN_UNKNOWN;
 
        /* Adjust the low key if we are continuing from where we left off. */
+       start_rtbno =
+               XFS_BB_TO_FSBT(mp, keys[0].fmr_physical + keys[0].fmr_length);
        if (keys[0].fmr_length > 0) {
-               info->low_daddr = XFS_FSB_TO_BB(mp, start_rtb);
+               info->low_daddr = XFS_FSB_TO_BB(mp, start_rtbno);
                if (info->low_daddr >= eofs)
                        return 0;
        }
+       start_rtx = xfs_rtb_to_rtx(mp, start_rtbno);
+       rgno = xfs_rtb_to_rgno(mp, start_rtbno);
+       trace_xfs_fsmap_low_key_linear(mp, info->dev, start_rtbno);
+
+       end_rtbno = XFS_BB_TO_FSB(mp, min(eofs - 1, keys[1].fmr_physical));
+       end_rtx = xfs_rtb_to_rtx(mp, end_rtbno + mp->m_sb.sb_rextsize - 1);
+       end_rgno = xfs_rtb_to_rgno(mp, end_rtbno);
+       trace_xfs_fsmap_high_key_linear(mp, info->dev, end_rtbno);
+
+       for_each_rtgroup_range(mp, rgno, end_rgno, rtg) {
+               xfs_rtxnum_t            rtg_end = rtg->rtg_extents;
+
+               if (rgno == end_rgno)
+                       rtg_end = end_rtx;
+
+               xfs_rtgroup_lock(rtg, XFS_RTGLOCK_BITMAP_SHARED);
+               error = xfs_rtalloc_query_range(rtg, tp, start_rtx, rtg_end,
+                               xfs_getfsmap_rtdev_rtbitmap_helper, info);
+               if (!error) {
+                       struct xfs_rtalloc_rec  ahigh = {
+                               .ar_startext    = rtg_end,
+                       };
+
+                       /*
+                        * Report any gaps at the end of the rtbitmap by
+                        * simulating a null rmap starting at the block after
+                        * the end of the query range.
+                        */
+                       info->last = true;
+                       error = xfs_getfsmap_rtdev_rtbitmap_helper(rtg, tp,
+                                       &ahigh, info);
+               }
+               xfs_rtgroup_unlock(rtg, XFS_RTGLOCK_BITMAP_SHARED);
+               if (error) {
+                       xfs_rtgroup_rele(rtg);
+                       return error;
+               }
+               start_rtx = 0;
+       }
 
-       trace_xfs_fsmap_low_key_linear(mp, info->dev, start_rtb);
-       trace_xfs_fsmap_high_key_linear(mp, info->dev, end_rtb);
-
-       xfs_rtbitmap_lock_shared(mp, XFS_RBMLOCK_BITMAP);
-
-       /*
-        * Set up query parameters to return free rtextents covering the range
-        * we want.
-        */
-       high = xfs_rtb_to_rtxup(mp, end_rtb);
-       error = xfs_rtalloc_query_range(mp, tp, xfs_rtb_to_rtx(mp, start_rtb),
-                       high, xfs_getfsmap_rtdev_rtbitmap_helper, info);
-       if (error)
-               goto err;
-
-       /*
-        * Report any gaps at the end of the rtbitmap by simulating a null
-        * rmap starting at the block after the end of the query range.
-        */
-       info->last = true;
-       ahigh.ar_startext = min(mp->m_sb.sb_rextents, high);
-
-       error = xfs_getfsmap_rtdev_rtbitmap_helper(mp, tp, &ahigh, info);
-       if (error)
-               goto err;
-err:
-       xfs_rtbitmap_unlock_shared(mp, XFS_RBMLOCK_BITMAP);
-       return error;
+       return 0;
 }
 #endif /* CONFIG_XFS_RT */
 
index dc1f7ade770e517528d27b3b1acb3e3ecf58d658..d0060ef1bec6aad1e8d9253240e25aff0ddfc49c 100644 (file)
@@ -90,8 +90,6 @@ typedef struct xfs_mount {
        struct xfs_da_geometry  *m_dir_geo;     /* directory block geometry */
        struct xfs_da_geometry  *m_attr_geo;    /* attribute block geometry */
        struct xlog             *m_log;         /* log specific stuff */
-       struct xfs_inode        *m_rbmip;       /* pointer to bitmap inode */
-       struct xfs_inode        *m_rsumip;      /* pointer to summary inode */
        struct xfs_inode        *m_rootip;      /* pointer to root directory */
        struct xfs_inode        *m_metadirip;   /* ptr to metadata directory */
        struct xfs_inode        *m_rtdirip;     /* ptr to realtime metadir */
@@ -100,14 +98,6 @@ typedef struct xfs_mount {
        struct xfs_buftarg      *m_logdev_targp;/* log device */
        struct xfs_buftarg      *m_rtdev_targp; /* rt device */
        void __percpu           *m_inodegc;     /* percpu inodegc structures */
-
-       /*
-        * Optional cache of rt summary level per bitmap block with the
-        * invariant that m_rsum_cache[bbno] > the maximum i for which
-        * rsum[i][bbno] != 0, or 0 if rsum[i][bbno] == 0 for all i.
-        * Reads and writes are serialized by the rsumip inode lock.
-        */
-       uint8_t                 *m_rsum_cache;
        struct xfs_mru_cache    *m_filestream;  /* per-mount filestream data */
        struct workqueue_struct *m_buf_workqueue;
        struct workqueue_struct *m_unwritten_workqueue;
index a6a52bfe3cde983957b378107248436c50ce252c..e2bc44ab8b23fb3affd893565b0b32bb64203380 100644 (file)
@@ -29,6 +29,7 @@
 #include "xfs_health.h"
 #include "xfs_da_format.h"
 #include "xfs_metafile.h"
+#include "xfs_rtgroup.h"
 
 /*
  * The global quota manager. There is only one of these for the entire
@@ -210,6 +211,21 @@ xfs_qm_unmount(
        }
 }
 
+static void
+xfs_qm_unmount_rt(
+       struct xfs_mount        *mp)
+{
+       struct xfs_rtgroup      *rtg = xfs_rtgroup_grab(mp, 0);
+
+       if (!rtg)
+               return;
+       if (rtg->rtg_inodes[XFS_RTG_BITMAP])
+               xfs_qm_dqdetach(rtg->rtg_inodes[XFS_RTG_BITMAP]);
+       if (rtg->rtg_inodes[XFS_RTG_SUMMARY])
+               xfs_qm_dqdetach(rtg->rtg_inodes[XFS_RTG_SUMMARY]);
+       xfs_rtgroup_rele(rtg);
+}
+
 /*
  * Called from the vfsops layer.
  */
@@ -223,10 +239,13 @@ xfs_qm_unmount_quotas(
         */
        ASSERT(mp->m_rootip);
        xfs_qm_dqdetach(mp->m_rootip);
-       if (mp->m_rbmip)
-               xfs_qm_dqdetach(mp->m_rbmip);
-       if (mp->m_rsumip)
-               xfs_qm_dqdetach(mp->m_rsumip);
+
+       /*
+        * For pre-RTG file systems, the RT inodes have quotas attached,
+        * detach them now.
+        */
+       if (!xfs_has_rtgroups(mp))
+               xfs_qm_unmount_rt(mp);
 
        /*
         * Release the quota inodes.
index e3ff9d5cdb6ee35edfa8bd9e13bfe7684dd3722f..4d5db0611125b982fb8ff5d0bd45c61e135db0aa 100644 (file)
@@ -42,14 +42,14 @@ xfs_rtany_summary(
        xfs_fileoff_t           bbno,   /* bitmap block number */
        int                     *maxlog) /* out: max log2 extent size free */
 {
-       struct xfs_mount        *mp = args->mp;
+       uint8_t                 *rsum_cache = args->rtg->rtg_rsum_cache;
        int                     error;
        int                     log;    /* loop counter, log2 of ext. size */
        xfs_suminfo_t           sum;    /* summary data */
 
-       /* There are no extents at levels >= m_rsum_cache[bbno]. */
-       if (mp->m_rsum_cache) {
-               high = min(high, mp->m_rsum_cache[bbno] - 1);
+       /* There are no extents at levels >= rsum_cache[bbno]. */
+       if (rsum_cache) {
+               high = min(high, rsum_cache[bbno] - 1);
                if (low > high) {
                        *maxlog = -1;
                        return 0;
@@ -81,12 +81,11 @@ xfs_rtany_summary(
        *maxlog = -1;
 out:
        /* There were no extents at levels > log. */
-       if (mp->m_rsum_cache && log + 1 < mp->m_rsum_cache[bbno])
-               mp->m_rsum_cache[bbno] = log + 1;
+       if (rsum_cache && log + 1 < rsum_cache[bbno])
+               rsum_cache[bbno] = log + 1;
        return 0;
 }
 
-
 /*
  * Copy and transform the summary file, given the old and new
  * parameters in the mount structures.
@@ -153,7 +152,7 @@ xfs_rtallocate_range(
        /*
         * Find the next allocated block (end of free extent).
         */
-       error = xfs_rtfind_forw(args, end, mp->m_sb.sb_rextents - 1,
+       error = xfs_rtfind_forw(args, end, args->rtg->rtg_extents - 1,
                        &postblock);
        if (error)
                return error;
@@ -215,14 +214,14 @@ xfs_rtalloc_align_len(
  */
 static inline xfs_rtxlen_t
 xfs_rtallocate_clamp_len(
-       struct xfs_mount        *mp,
+       struct xfs_rtgroup      *rtg,
        xfs_rtxnum_t            startrtx,
        xfs_rtxlen_t            rtxlen,
        xfs_rtxlen_t            prod)
 {
        xfs_rtxlen_t            ret;
 
-       ret = min(mp->m_sb.sb_rextents, startrtx + rtxlen) - startrtx;
+       ret = min(rtg->rtg_extents, startrtx + rtxlen) - startrtx;
        return xfs_rtalloc_align_len(ret, prod);
 }
 
@@ -257,10 +256,11 @@ xfs_rtallocate_extent_block(
         * Loop over all the extents starting in this bitmap block up to the
         * end of the rt volume, looking for one that's long enough.
         */
-       end = min(mp->m_sb.sb_rextents, xfs_rbmblock_to_rtx(mp, bbno + 1)) - 1;
+       end = min(args->rtg->rtg_extents, xfs_rbmblock_to_rtx(mp, bbno + 1)) -
+               1;
        for (i = xfs_rbmblock_to_rtx(mp, bbno); i <= end; i++) {
                /* Make sure we don't scan off the end of the rt volume. */
-               scanlen = xfs_rtallocate_clamp_len(mp, i, maxlen, prod);
+               scanlen = xfs_rtallocate_clamp_len(args->rtg, i, maxlen, prod);
                if (scanlen < minlen)
                        break;
 
@@ -345,7 +345,6 @@ xfs_rtallocate_extent_exact(
        xfs_rtxlen_t            prod,   /* extent product factor */
        xfs_rtxnum_t            *rtx)   /* out: start rtext allocated */
 {
-       struct xfs_mount        *mp = args->mp;
        xfs_rtxnum_t            next;   /* next rtext to try (dummy) */
        xfs_rtxlen_t            alloclen; /* candidate length */
        xfs_rtxlen_t            scanlen; /* number of free rtx to look for */
@@ -356,7 +355,7 @@ xfs_rtallocate_extent_exact(
        ASSERT(maxlen % prod == 0);
 
        /* Make sure we don't run off the end of the rt volume. */
-       scanlen = xfs_rtallocate_clamp_len(mp, start, maxlen, prod);
+       scanlen = xfs_rtallocate_clamp_len(args->rtg, start, maxlen, prod);
        if (scanlen < minlen)
                return -ENOSPC;
 
@@ -417,11 +416,10 @@ xfs_rtallocate_extent_near(
        ASSERT(maxlen % prod == 0);
 
        /*
-        * If the block number given is off the end, silently set it to
-        * the last block.
+        * If the block number given is off the end, silently set it to the last
+        * block.
         */
-       if (start >= mp->m_sb.sb_rextents)
-               start = mp->m_sb.sb_rextents - 1;
+       start = min(start, args->rtg->rtg_extents - 1);
 
        /*
         * Try the exact allocation first.
@@ -661,37 +659,64 @@ xfs_rtunmount_rtg(
 
        for (i = 0; i < XFS_RTG_MAX; i++)
                xfs_rtginode_irele(&rtg->rtg_inodes[i]);
+       kvfree(rtg->rtg_rsum_cache);
 }
 
 static int
 xfs_alloc_rsum_cache(
-       struct xfs_mount        *mp,
+       struct xfs_rtgroup      *rtg,
        xfs_extlen_t            rbmblocks)
 {
        /*
         * The rsum cache is initialized to the maximum value, which is
         * trivially an upper bound on the maximum level with any free extents.
         */
-       mp->m_rsum_cache = kvmalloc(rbmblocks, GFP_KERNEL);
-       if (!mp->m_rsum_cache)
+       rtg->rtg_rsum_cache = kvmalloc(rbmblocks, GFP_KERNEL);
+       if (!rtg->rtg_rsum_cache)
                return -ENOMEM;
-       memset(mp->m_rsum_cache, -1, rbmblocks);
+       memset(rtg->rtg_rsum_cache, -1, rbmblocks);
        return 0;
 }
 
+/* Ensure that the rtgroup metadata inode is loaded, creating it if neeeded. */
+static int
+xfs_rtginode_ensure(
+       struct xfs_rtgroup      *rtg,
+       enum xfs_rtg_inodes     type)
+{
+       struct xfs_trans        *tp;
+       int                     error;
+
+       if (rtg->rtg_inodes[type])
+               return 0;
+
+       error = xfs_trans_alloc_empty(rtg->rtg_mount, &tp);
+       if (error)
+               return error;
+       error = xfs_rtginode_load(rtg, type, tp);
+       xfs_trans_cancel(tp);
+
+       if (error != -ENOENT)
+               return 0;
+       return xfs_rtginode_create(rtg, type, true);
+}
+
 static int
 xfs_growfs_rt_bmblock(
-       struct xfs_mount        *mp,
+       struct xfs_rtgroup      *rtg,
        xfs_rfsblock_t          nrblocks,
        xfs_agblock_t           rextsize,
        xfs_fileoff_t           bmbno)
 {
-       struct xfs_inode        *rbmip = mp->m_rbmip;
-       struct xfs_inode        *rsumip = mp->m_rsumip;
+       struct xfs_mount        *mp = rtg->rtg_mount;
+       struct xfs_inode        *rbmip = rtg->rtg_inodes[XFS_RTG_BITMAP];
+       struct xfs_inode        *rsumip = rtg->rtg_inodes[XFS_RTG_SUMMARY];
        struct xfs_rtalloc_args args = {
                .mp             = mp,
+               .rtg            = rtg,
        };
        struct xfs_rtalloc_args nargs = {
+               .rtg            = rtg,
        };
        struct xfs_mount        *nmp;
        xfs_rfsblock_t          nrblocks_step;
@@ -717,6 +742,7 @@ xfs_growfs_rt_bmblock(
        nmp->m_rsumlevels = nmp->m_sb.sb_rextslog + 1;
        nmp->m_rsumblocks = xfs_rtsummary_blockcount(mp, nmp->m_rsumlevels,
                        nmp->m_sb.sb_rbmblocks);
+       rtg->rtg_extents = xfs_rtgroup_extents(nmp, rtg->rtg_rgno);
 
        /*
         * Recompute the growfsrt reservation from the new rsumsize, so that the
@@ -729,8 +755,8 @@ xfs_growfs_rt_bmblock(
                goto out_free;
        nargs.tp = args.tp;
 
-       xfs_rtbitmap_lock(mp);
-       xfs_rtbitmap_trans_join(args.tp);
+       xfs_rtgroup_lock(args.rtg, XFS_RTGLOCK_BITMAP);
+       xfs_rtgroup_trans_join(args.tp, args.rtg, XFS_RTGLOCK_BITMAP);
 
        /*
         * Update the bitmap inode's size ondisk and incore.  We need to update
@@ -832,8 +858,9 @@ out_free:
  */
 static xfs_fileoff_t
 xfs_last_rt_bmblock(
-       struct xfs_mount        *mp)
+       struct xfs_rtgroup      *rtg)
 {
+       struct xfs_mount        *mp = rtg->rtg_mount;
        xfs_fileoff_t           bmbno = mp->m_sb.sb_rbmblocks;
 
        /* Skip the current block if it is exactly full. */
@@ -842,6 +869,103 @@ xfs_last_rt_bmblock(
        return bmbno;
 }
 
+/*
+ * Allocate space to the bitmap and summary files, as necessary.
+ */
+static int
+xfs_growfs_rt_alloc_blocks(
+       struct xfs_rtgroup      *rtg,
+       xfs_rfsblock_t          nrblocks,
+       xfs_agblock_t           rextsize,
+       xfs_extlen_t            *nrbmblocks)
+{
+       struct xfs_mount        *mp = rtg->rtg_mount;
+       struct xfs_inode        *rbmip = rtg->rtg_inodes[XFS_RTG_BITMAP];
+       struct xfs_inode        *rsumip = rtg->rtg_inodes[XFS_RTG_SUMMARY];
+       xfs_rtxnum_t            nrextents = div_u64(nrblocks, rextsize);
+       xfs_extlen_t            orbmblocks;
+       xfs_extlen_t            orsumblocks;
+       xfs_extlen_t            nrsumblocks;
+       int                     error;
+
+       /*
+        * Get the old block counts for bitmap and summary inodes.
+        * These can't change since other growfs callers are locked out.
+        */
+       orbmblocks = XFS_B_TO_FSB(mp, rbmip->i_disk_size);
+       orsumblocks = XFS_B_TO_FSB(mp, rsumip->i_disk_size);
+
+       *nrbmblocks = xfs_rtbitmap_blockcount(mp, nrextents);
+       nrsumblocks = xfs_rtsummary_blockcount(mp,
+               xfs_compute_rextslog(nrextents) + 1, *nrbmblocks);
+
+       error = xfs_rtfile_initialize_blocks(rtg, XFS_RTG_BITMAP, orbmblocks,
+                       *nrbmblocks, NULL);
+       if (error)
+               return error;
+       return xfs_rtfile_initialize_blocks(rtg, XFS_RTG_SUMMARY, orsumblocks,
+                       nrsumblocks, NULL);
+}
+
+static int
+xfs_growfs_rtg(
+       struct xfs_mount        *mp,
+       xfs_rfsblock_t          nrblocks,
+       xfs_agblock_t           rextsize)
+{
+       uint8_t                 *old_rsum_cache = NULL;
+       xfs_extlen_t            bmblocks;
+       xfs_fileoff_t           bmbno;
+       struct xfs_rtgroup      *rtg;
+       unsigned int            i;
+       int                     error;
+
+       rtg = xfs_rtgroup_grab(mp, 0);
+       if (!rtg)
+               return -EINVAL;
+
+       for (i = 0; i < XFS_RTG_MAX; i++) {
+               error = xfs_rtginode_ensure(rtg, i);
+               if (error)
+                       goto out_rele;
+       }
+
+       error = xfs_growfs_rt_alloc_blocks(rtg, nrblocks, rextsize, &bmblocks);
+       if (error)
+               goto out_rele;
+
+       if (bmblocks != rtg->rtg_mount->m_sb.sb_rbmblocks) {
+               old_rsum_cache = rtg->rtg_rsum_cache;
+               error = xfs_alloc_rsum_cache(rtg, bmblocks);
+               if (error)
+                       goto out_rele;
+       }
+
+       for (bmbno = xfs_last_rt_bmblock(rtg); bmbno < bmblocks; bmbno++) {
+               error = xfs_growfs_rt_bmblock(rtg, nrblocks, rextsize, bmbno);
+               if (error)
+                       goto out_error;
+       }
+
+       if (old_rsum_cache)
+               kvfree(old_rsum_cache);
+       xfs_rtgroup_rele(rtg);
+       return 0;
+
+out_error:
+       /*
+        * Reset rtg_extents to the old value if adding more blocks failed.
+        */
+       rtg->rtg_extents = xfs_rtgroup_extents(rtg->rtg_mount, rtg->rtg_rgno);
+       if (old_rsum_cache) {
+               kvfree(rtg->rtg_rsum_cache);
+               rtg->rtg_rsum_cache = old_rsum_cache;
+       }
+out_rele:
+       xfs_rtgroup_rele(rtg);
+       return error;
+}
+
 /*
  * Grow the realtime area of the filesystem.
  */
@@ -850,15 +974,11 @@ xfs_growfs_rt(
        xfs_mount_t     *mp,            /* mount point for filesystem */
        xfs_growfs_rt_t *in)            /* growfs rt input struct */
 {
-       xfs_fileoff_t   bmbno;          /* bitmap block number */
-       struct xfs_buf  *bp;            /* temporary buffer */
-       int             error;          /* error return value */
-       xfs_extlen_t    nrbmblocks;     /* new number of rt bitmap blocks */
-       xfs_rtxnum_t    nrextents;      /* new number of realtime extents */
-       xfs_extlen_t    nrsumblocks;    /* new number of summary blocks */
-       xfs_extlen_t    rbmblocks;      /* current number of rt bitmap blocks */
-       xfs_extlen_t    rsumblocks;     /* current number of rt summary blks */
-       uint8_t         *rsum_cache;    /* old summary cache */
+       xfs_rtxnum_t            nrextents;
+       xfs_extlen_t            nrbmblocks;
+       xfs_extlen_t            nrsumblocks;
+       struct xfs_buf          *bp;
+       int                     error;
 
        if (!capable(CAP_SYS_ADMIN))
                return -EPERM;
@@ -866,12 +986,6 @@ xfs_growfs_rt(
        /* Needs to have been mounted with an rt device. */
        if (!XFS_IS_REALTIME_MOUNT(mp))
                return -EINVAL;
-       /*
-        * Mount should fail if the rt bitmap/summary files don't load, but
-        * we'll check anyway.
-        */
-       if (!mp->m_rbmip || !mp->m_rsumip)
-               return -EINVAL;
 
        /* Shrink not supported. */
        if (in->newblocks <= mp->m_sb.sb_rblocks)
@@ -920,58 +1034,13 @@ xfs_growfs_rt(
         */
        if (nrsumblocks > (mp->m_sb.sb_logblocks >> 1))
                return -EINVAL;
-       /*
-        * Get the old block counts for bitmap and summary inodes.
-        * These can't change since other growfs callers are locked out.
-        */
-       rbmblocks = XFS_B_TO_FSB(mp, mp->m_rbmip->i_disk_size);
-       rsumblocks = XFS_B_TO_FSB(mp, mp->m_rsumip->i_disk_size);
-       /*
-        * Allocate space to the bitmap and summary files, as necessary.
-        */
-       error = xfs_rtfile_initialize_blocks(mp->m_rbmip, rbmblocks,
-                       nrbmblocks, NULL);
-       if (error)
-               return error;
-       error = xfs_rtfile_initialize_blocks(mp->m_rsumip, rsumblocks,
-                       nrsumblocks, NULL);
+
+       error = xfs_growfs_rtg(mp, in->newblocks, in->extsize);
        if (error)
                return error;
 
-       rsum_cache = mp->m_rsum_cache;
-       if (nrbmblocks != mp->m_sb.sb_rbmblocks) {
-               error = xfs_alloc_rsum_cache(mp, nrbmblocks);
-               if (error)
-                       return error;
-       }
-
-       /* Initialize the free space bitmap one bitmap block at a time. */
-       for (bmbno = xfs_last_rt_bmblock(mp); bmbno < nrbmblocks; bmbno++) {
-               error = xfs_growfs_rt_bmblock(mp, in->newblocks, in->extsize,
-                               bmbno);
-               if (error)
-                       goto out_free;
-       }
-
        /* Update secondary superblocks now the physical grow has completed */
-       error = xfs_update_secondary_sbs(mp);
-
-out_free:
-       /*
-        * If we had to allocate a new rsum_cache, we either need to free the
-        * old one (if we succeeded) or free the new one and restore the old one
-        * (if there was an error).
-        */
-       if (rsum_cache != mp->m_rsum_cache) {
-               if (error) {
-                       kvfree(mp->m_rsum_cache);
-                       mp->m_rsum_cache = rsum_cache;
-               } else {
-                       kvfree(rsum_cache);
-               }
-       }
-
-       return error;
+       return xfs_update_secondary_sbs(mp);
 }
 
 /*
@@ -997,7 +1066,7 @@ xfs_rtmount_init(
        mp->m_rsumlevels = sbp->sb_rextslog + 1;
        mp->m_rsumblocks = xfs_rtsummary_blockcount(mp, mp->m_rsumlevels,
                        mp->m_sb.sb_rbmblocks);
-       mp->m_rbmip = mp->m_rsumip = NULL;
+
        /*
         * Check that the realtime section is an ok size.
         */
@@ -1021,7 +1090,7 @@ xfs_rtmount_init(
 
 static int
 xfs_rtalloc_count_frextent(
-       struct xfs_mount                *mp,
+       struct xfs_rtgroup              *rtg,
        struct xfs_trans                *tp,
        const struct xfs_rtalloc_rec    *rec,
        void                            *priv)
@@ -1043,12 +1112,17 @@ xfs_rtalloc_reinit_frextents(
        uint64_t                val = 0;
        int                     error;
 
-       xfs_rtbitmap_lock_shared(mp, XFS_RBMLOCK_BITMAP);
-       error = xfs_rtalloc_query_all(mp, NULL, xfs_rtalloc_count_frextent,
-                       &val);
-       xfs_rtbitmap_unlock_shared(mp, XFS_RBMLOCK_BITMAP);
-       if (error)
-               return error;
+       struct xfs_rtgroup      *rtg;
+       xfs_rgnumber_t          rgno;
+
+       for_each_rtgroup(mp, rgno, rtg) {
+               xfs_rtgroup_lock(rtg, XFS_RTGLOCK_BITMAP_SHARED);
+               error = xfs_rtalloc_query_all(rtg, NULL, xfs_rtalloc_count_frextent,
+                               &val);
+               xfs_rtgroup_unlock(rtg, XFS_RTGLOCK_BITMAP_SHARED);
+               if (error)
+                       return error;
+       }
 
        spin_lock(&mp->m_sb_lock);
        mp->m_sb.sb_frextents = val;
@@ -1087,16 +1161,30 @@ out_unlock:
        return error;
 }
 
-static void
-xfs_rtgroup_unmount_inodes(
-       struct xfs_mount        *mp)
+static int
+xfs_rtmount_rtg(
+       struct xfs_mount        *mp,
+       struct xfs_trans        *tp,
+       struct xfs_rtgroup      *rtg)
 {
-       struct xfs_rtgroup      *rtg;
-       xfs_rgnumber_t          rgno;
+       int                     error, i;
 
-       for_each_rtgroup(mp, rgno, rtg)
-               xfs_rtunmount_rtg(rtg);
-       xfs_rtginode_irele(&mp->m_rtdirip);
+       rtg->rtg_extents = xfs_rtgroup_extents(mp, rtg->rtg_rgno);
+
+       for (i = 0; i < XFS_RTG_MAX; i++) {
+               error = xfs_rtginode_load(rtg, i, tp);
+               if (error)
+                       return error;
+
+               if (rtg->rtg_inodes[i]) {
+                       error = xfs_rtmount_iread_extents(tp,
+                                       rtg->rtg_inodes[i], 0);
+                       if (error)
+                               return error;
+               }
+       }
+
+       return xfs_alloc_rsum_cache(rtg, mp->m_sb.sb_rbmblocks);
 }
 
 /*
@@ -1108,71 +1196,30 @@ xfs_rtmount_inodes(
        struct xfs_mount        *mp)
 {
        struct xfs_trans        *tp;
-       struct xfs_sb           *sbp = &mp->m_sb;
        struct xfs_rtgroup      *rtg;
        xfs_rgnumber_t          rgno;
-       unsigned int            i;
        int                     error;
 
        error = xfs_trans_alloc_empty(mp, &tp);
        if (error)
                return error;
 
-       error = xfs_metafile_iget(tp, mp->m_sb.sb_rbmino, S_IFREG, &mp->m_rbmip);
-       if (xfs_metadata_is_sick(error))
-               xfs_rt_mark_sick(mp, XFS_SICK_RT_BITMAP);
-       if (error)
-               goto out_trans;
-       ASSERT(mp->m_rbmip != NULL);
-
-       error = xfs_rtmount_iread_extents(tp, mp->m_rbmip, XFS_ILOCK_RTBITMAP);
-       if (error)
-               goto out_rele_bitmap;
-
-       error = xfs_metafile_iget(tp, mp->m_sb.sb_rsumino, S_IFREG, &mp->m_rsumip);
-       if (xfs_metadata_is_sick(error))
-               xfs_rt_mark_sick(mp, XFS_SICK_RT_SUMMARY);
-       if (error)
-               goto out_rele_bitmap;
-       ASSERT(mp->m_rsumip != NULL);
-
-       error = xfs_rtmount_iread_extents(tp, mp->m_rsumip, XFS_ILOCK_RTSUM);
-       if (error)
-               goto out_rele_summary;
-
        if (xfs_has_rtgroups(mp) && mp->m_sb.sb_rgcount > 0) {
                error = xfs_rtginode_load_parent(tp);
                if (error)
-                       goto out_rele_rtdir;
+                       goto out_cancel;
        }
 
        for_each_rtgroup(mp, rgno, rtg) {
-               rtg->rtg_extents = xfs_rtgroup_extents(mp, rtg->rtg_rgno);
-
-               for (i = 0; i < XFS_RTG_MAX; i++) {
-                       error = xfs_rtginode_load(rtg, i, tp);
-                       if (error) {
-                               xfs_rtgroup_rele(rtg);
-                               goto out_rele_inodes;
-                       }
+               error = xfs_rtmount_rtg(mp, tp, rtg);
+               if (error) {
+                       xfs_rtgroup_rele(rtg);
+                       xfs_rtunmount_inodes(mp);
+                       break;
                }
        }
 
-       error = xfs_alloc_rsum_cache(mp, sbp->sb_rbmblocks);
-       if (error)
-               goto out_rele_summary;
-       xfs_trans_cancel(tp);
-       return 0;
-
-out_rele_inodes:
-       xfs_rtgroup_unmount_inodes(mp);
-out_rele_rtdir:
-       xfs_rtginode_irele(&mp->m_rtdirip);
-out_rele_summary:
-       xfs_irele(mp->m_rsumip);
-out_rele_bitmap:
-       xfs_irele(mp->m_rbmip);
-out_trans:
+out_cancel:
        xfs_trans_cancel(tp);
        return error;
 }
@@ -1181,14 +1228,12 @@ void
 xfs_rtunmount_inodes(
        struct xfs_mount        *mp)
 {
-       kvfree(mp->m_rsum_cache);
+       struct xfs_rtgroup      *rtg;
+       xfs_rgnumber_t          rgno;
 
-       xfs_rtgroup_unmount_inodes(mp);
+       for_each_rtgroup(mp, rgno, rtg)
+               xfs_rtunmount_rtg(rtg);
        xfs_rtginode_irele(&mp->m_rtdirip);
-       if (mp->m_rbmip)
-               xfs_irele(mp->m_rbmip);
-       if (mp->m_rsumip)
-               xfs_irele(mp->m_rsumip);
 }
 
 /*
@@ -1200,28 +1245,29 @@ xfs_rtunmount_inodes(
  */
 static xfs_rtxnum_t
 xfs_rtpick_extent(
-       xfs_mount_t             *mp,            /* file system mount point */
-       xfs_trans_t             *tp,            /* transaction pointer */
+       struct xfs_rtgroup      *rtg,
+       struct xfs_trans        *tp,
        xfs_rtxlen_t            len)            /* allocation length (rtextents) */
 {
-       xfs_rtxnum_t            b;              /* result rtext */
+       struct xfs_mount        *mp = rtg->rtg_mount;
+       struct xfs_inode        *rbmip = rtg->rtg_inodes[XFS_RTG_BITMAP];
+       xfs_rtxnum_t            b = 0;          /* result rtext */
        int                     log2;           /* log of sequence number */
        uint64_t                resid;          /* residual after log removed */
        uint64_t                seq;            /* sequence number of file creation */
        struct timespec64       ts;             /* timespec in inode */
 
-       xfs_assert_ilocked(mp->m_rbmip, XFS_ILOCK_EXCL);
+       xfs_assert_ilocked(rbmip, XFS_ILOCK_EXCL);
 
-       ts = inode_get_atime(VFS_I(mp->m_rbmip));
-       if (!(mp->m_rbmip->i_diflags & XFS_DIFLAG_NEWRTBM)) {
-               mp->m_rbmip->i_diflags |= XFS_DIFLAG_NEWRTBM;
+       ts = inode_get_atime(VFS_I(rbmip));
+       if (!(rbmip->i_diflags & XFS_DIFLAG_NEWRTBM)) {
+               rbmip->i_diflags |= XFS_DIFLAG_NEWRTBM;
                seq = 0;
        } else {
                seq = ts.tv_sec;
        }
-       if ((log2 = xfs_highbit64(seq)) == -1)
-               b = 0;
-       else {
+       log2 = xfs_highbit64(seq);
+       if (log2 != -1) {
                resid = seq - (1ULL << log2);
                b = (mp->m_sb.sb_rextents * ((resid << 1) + 1ULL)) >>
                    (log2 + 1);
@@ -1231,8 +1277,8 @@ xfs_rtpick_extent(
                        b = mp->m_sb.sb_rextents - len;
        }
        ts.tv_sec = seq + 1;
-       inode_set_atime_to_ts(VFS_I(mp->m_rbmip), ts);
-       xfs_trans_log_inode(tp, mp->m_rbmip, XFS_ILOG_CORE);
+       inode_set_atime_to_ts(VFS_I(rbmip), ts);
+       xfs_trans_log_inode(tp, rbmip, XFS_ILOG_CORE);
        return b;
 }
 
@@ -1287,12 +1333,16 @@ xfs_rtallocate(
        xfs_rtxlen_t            len = 0;
        int                     error = 0;
 
+       args.rtg = xfs_rtgroup_grab(args.mp, 0);
+       if (!args.rtg)
+               return -ENOSPC;
+
        /*
         * Lock out modifications to both the RT bitmap and summary inodes.
         */
        if (!*rtlocked) {
-               xfs_rtbitmap_lock(args.mp);
-               xfs_rtbitmap_trans_join(tp);
+               xfs_rtgroup_lock(args.rtg, XFS_RTGLOCK_BITMAP);
+               xfs_rtgroup_trans_join(tp, args.rtg, XFS_RTGLOCK_BITMAP);
                *rtlocked = true;
        }
 
@@ -1303,7 +1353,7 @@ xfs_rtallocate(
        if (bno_hint)
                start = xfs_rtb_to_rtx(args.mp, bno_hint);
        else if (initial_user_data)
-               start = xfs_rtpick_extent(args.mp, tp, maxlen);
+               start = xfs_rtpick_extent(args.rtg, tp, maxlen);
 
        if (start) {
                error = xfs_rtallocate_extent_near(&args, start, minlen, maxlen,
@@ -1337,6 +1387,7 @@ xfs_rtallocate(
        *blen = xfs_rtxlen_to_extlen(args.mp, len);
 
 out_release:
+       xfs_rtgroup_rele(args.rtg);
        xfs_rtbuf_cache_relse(&args);
        return error;
 }