]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
media: imx: imx7_mipi_csis: Fix logging of only error event counters
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Tue, 13 Apr 2021 02:29:52 +0000 (04:29 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jul 2021 14:53:11 +0000 (16:53 +0200)
[ Upstream commit d2fcc9c2de1191ea80366e3658711753738dd10a ]

The mipi_csis_events array ends with 6 non-error events, not 4. Update
mipi_csis_log_counters() accordingly. While at it, log event counters in
forward order, as there's no reason to log them backward.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Rui Miguel Silva <rmfrfs@gmail.com>
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Tested-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/staging/media/imx/imx7-mipi-csis.c

index 021bbd42039072e1097681b17673bcc50574ebed..63bc78e4cac8f4c4d14f15efa11900f51ddf4af7 100644 (file)
@@ -528,13 +528,15 @@ static void mipi_csis_clear_counters(struct csi_state *state)
 
 static void mipi_csis_log_counters(struct csi_state *state, bool non_errors)
 {
-       int i = non_errors ? MIPI_CSIS_NUM_EVENTS : MIPI_CSIS_NUM_EVENTS - 4;
+       unsigned int num_events = non_errors ? MIPI_CSIS_NUM_EVENTS
+                               : MIPI_CSIS_NUM_EVENTS - 6;
        struct device *dev = &state->pdev->dev;
        unsigned long flags;
+       unsigned int i;
 
        spin_lock_irqsave(&state->slock, flags);
 
-       for (i--; i >= 0; i--) {
+       for (i = 0; i < num_events; ++i) {
                if (state->events[i].counter > 0 || state->debug)
                        dev_info(dev, "%s events: %d\n", state->events[i].name,
                                 state->events[i].counter);