]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
hw/i386: Remove unnecessary initialization in x86_cpu_new
authorBabu Moger <babu.moger@amd.com>
Wed, 11 Mar 2020 22:53:13 +0000 (17:53 -0500)
committerEduardo Habkost <ehabkost@redhat.com>
Tue, 17 Mar 2020 23:48:10 +0000 (19:48 -0400)
The function pc_cpu_pre_plug takes care of initialization of CPUX86State.
So, remove the initialization here.

Suggested-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Babu Moger <babu.moger@amd.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <158396719336.58170.11951852360759449871.stgit@naples-babu.amd.com>

hw/i386/x86.c

index b7d94e8dfe3b88a8288142bd5a026613ceac1373..41b884605ff6c4b0a39ba53a283986baca8d8c7d 100644 (file)
@@ -103,13 +103,9 @@ void x86_cpu_new(X86MachineState *x86ms, int64_t apic_id, Error **errp)
 {
     Object *cpu = NULL;
     Error *local_err = NULL;
-    CPUX86State *env = NULL;
 
     cpu = object_new(MACHINE(x86ms)->cpu_type);
 
-    env = &X86_CPU(cpu)->env;
-    env->nr_dies = x86ms->smp_dies;
-
     object_property_set_uint(cpu, apic_id, "apic-id", &local_err);
     object_property_set_bool(cpu, true, "realized", &local_err);