wifi: iwlwifi: mvm: Use IWL_FW_CHECK() for BAR notif size validation

Use IWL_FW_CHECK() for BAR notification size validation, improving
diagnostics with a clear error message on failure.

Signed-off-by: Daniel Gabay <daniel.gabay@intel.com>
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20241226174257.913d5d476929.I8cd62f45bacc088c309b0152fc392dc2579e82e0@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c b/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c
index e8ea48936c2d5cf1f5b80f32bb8b1491a45d6fd9..c03cb7cc2f1c14534d04a5674d3ccc08d0a5930e 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c
@@ -2507,9 +2507,12 @@ void iwl_mvm_rx_bar_frame_release(struct iwl_mvm *mvm, struct napi_struct *napi,
        struct iwl_rx_packet *pkt = rxb_addr(rxb);
        struct iwl_bar_frame_release *release = (void *)pkt->data;
        struct iwl_mvm_baid_data *baid_data;
+       u32 pkt_len = iwl_rx_packet_payload_len(pkt);
        unsigned int baid, nssn, sta_id, tid;
 
-       if (unlikely(iwl_rx_packet_payload_len(pkt) < sizeof(*release)))
+       if (IWL_FW_CHECK(mvm, pkt_len < sizeof(*release),
+                        "Unexpected frame release notif size %d (expected %zu)\n",
+                        pkt_len, sizeof(*release)))
                return;
 
        baid = le32_get_bits(release->ba_info,