]> www.infradead.org Git - users/hch/misc.git/commitdiff
rtc: tps6586x: Fix initial enable_irq/disable_irq balance
authorEsben Haabendal <esben@geanix.com>
Fri, 16 May 2025 07:23:38 +0000 (09:23 +0200)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 9 Oct 2025 21:34:52 +0000 (23:34 +0200)
Interrupts are automatically enabled when requested, so we need to
initialize irq_en accordingly to avoid causing an unbalanced enable
warning.

Signed-off-by: Esben Haabendal <esben@geanix.com>
Link: https://lore.kernel.org/r/20250516-rtc-uie-irq-fixes-v2-4-3de8e530a39e@geanix.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-tps6586x.c

index 54c8429b16bfcc692b1f4d5404f0c42f720e93b4..76ecf7b798f0de22aa89a552a263b473ab3065ef 100644 (file)
@@ -258,6 +258,7 @@ static int tps6586x_rtc_probe(struct platform_device *pdev)
 
        irq_set_status_flags(rtc->irq, IRQ_NOAUTOEN);
 
+       rtc->irq_en = true;
        ret = devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL,
                                tps6586x_rtc_irq,
                                IRQF_ONESHOT,