dm vdo: remove checks that can not fail

Remove checks that can't fail.

Signed-off-by: Matthew Sakai <msakai@redhat.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>

diff --git a/drivers/md/dm-vdo/constants.h b/drivers/md/dm-vdo/constants.h
index a8c4d6e24b38a31f578634947cb9a87c2ea0af1a..2a8b03779f878a0c9440f9d723870f520b86c6d0 100644 (file)
--- a/drivers/md/dm-vdo/constants.h
+++ b/drivers/md/dm-vdo/constants.h
@@ -44,9 +44,6 @@ enum {
        /* The default size of each slab journal, in blocks */
        DEFAULT_VDO_SLAB_JOURNAL_SIZE = 224,
 
-       /* Unit test minimum */
-       MINIMUM_VDO_SLAB_JOURNAL_BLOCKS = 2,
-
        /*
         * The initial size of lbn_operations and pbn_operations, which is based upon the expected
         * maximum number of outstanding VIOs. This value was chosen to make it highly unlikely

diff --git a/drivers/md/dm-vdo/encodings.c b/drivers/md/dm-vdo/encodings.c
index 100e92f8f866c88a78aeec2dd8d17e57c2a81d71..b7cc0f41caca4bfa136e5dc3dc77167c6cd3c71c 100644 (file)
--- a/drivers/md/dm-vdo/encodings.c
+++ b/drivers/md/dm-vdo/encodings.c
@@ -711,24 +711,11 @@ int vdo_configure_slab(block_count_t slab_size, block_count_t slab_journal_block
        ref_blocks = vdo_get_saved_reference_count_size(slab_size - slab_journal_blocks);
        meta_blocks = (ref_blocks + slab_journal_blocks);
 
-       /* Make sure test code hasn't configured slabs to be too small. */
+       /* Make sure configured slabs are not too small. */
        if (meta_blocks >= slab_size)
                return VDO_BAD_CONFIGURATION;
 
-       /*
-        * If the slab size is very small, assume this must be a unit test and override the number
-        * of data blocks to be a power of two (wasting blocks in the slab). Many tests need their
-        * data_blocks fields to be the exact capacity of the configured volume, and that used to
-        * fall out since they use a power of two for the number of data blocks, the slab size was
-        * a power of two, and every block in a slab was a data block.
-        *
-        * TODO: Try to figure out some way of structuring testParameters and unit tests so this
-        * hack isn't needed without having to edit several unit tests every time the metadata size
-        * changes by one block.
-        */
        data_blocks = slab_size - meta_blocks;
-       if ((slab_size < 1024) && !is_power_of_2(data_blocks))
-               data_blocks = ((block_count_t) 1 << ilog2(data_blocks));
 
        /*
         * Configure the slab journal thresholds. The flush threshold is 168 of 224 blocks in
@@ -1221,11 +1208,6 @@ int vdo_validate_config(const struct vdo_config *config,
        if (result != VDO_SUCCESS)
                return result;
 
-       result = VDO_ASSERT(config->slab_journal_blocks >= MINIMUM_VDO_SLAB_JOURNAL_BLOCKS,
-                           "slab journal size meets minimum size");
-       if (result != VDO_SUCCESS)
-               return result;
-
        result = VDO_ASSERT(config->slab_journal_blocks <= config->slab_size,
                            "slab journal size is within expected bound");
        if (result != VDO_SUCCESS)