]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
spi: rockchip-sfc: Use dev_err_probe() in the probe path
authorDragan Simic <dsimic@manjaro.org>
Thu, 26 Sep 2024 08:38:16 +0000 (10:38 +0200)
committerMark Brown <broonie@kernel.org>
Sun, 29 Sep 2024 23:12:15 +0000 (01:12 +0200)
Use function dev_err_probe() in the probe path instead of dev_err() where
appropriate, to make the code a bit more uniform and compact.

Signed-off-by: Dragan Simic <dsimic@manjaro.org>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patch.msgid.link/8f65c1ec7737af7f2a538fcae3618756a53ba3fa.1727337732.git.dsimic@manjaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-rockchip-sfc.c

index 505d5089bf031d08d8de93906b58098e3b8f38d0..7e0fb4944a3473949c895e26e8cd8c90b2bb45c8 100644 (file)
@@ -580,16 +580,14 @@ static int rockchip_sfc_probe(struct platform_device *pdev)
                return PTR_ERR(sfc->regbase);
 
        sfc->clk = devm_clk_get(&pdev->dev, "clk_sfc");
-       if (IS_ERR(sfc->clk)) {
-               dev_err(&pdev->dev, "Failed to get sfc interface clk\n");
-               return PTR_ERR(sfc->clk);
-       }
+       if (IS_ERR(sfc->clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(sfc->clk),
+                                    "Failed to get sfc interface clk\n");
 
        sfc->hclk = devm_clk_get(&pdev->dev, "hclk_sfc");
-       if (IS_ERR(sfc->hclk)) {
-               dev_err(&pdev->dev, "Failed to get sfc ahb clk\n");
-               return PTR_ERR(sfc->hclk);
-       }
+       if (IS_ERR(sfc->hclk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(sfc->hclk),
+                                    "Failed to get sfc ahb clk\n");
 
        sfc->use_dma = !of_property_read_bool(sfc->dev->of_node, "rockchip,sfc-no-dma");