]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
drm/i915/display: Use intel_crtc_destroy_state instead kfree
authorSuraj Kandpal <suraj.kandpal@intel.com>
Tue, 10 Oct 2023 18:31:00 +0000 (00:01 +0530)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 11 Oct 2023 21:40:28 +0000 (00:40 +0300)
intel_encoder_current_mode() seems to leak some resource because
it uses kfree instead of intel_crtc_destroy_state let us fix that.

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231010183101.704439-2-suraj.kandpal@intel.com
drivers/gpu/drm/i915/display/intel_display.c

index e309fda108efc27f93bec8578a50d7cfde9af62f..e7129a5630db4059b8d6c2b413c56a0829d42def 100644 (file)
@@ -3999,7 +3999,7 @@ intel_encoder_current_mode(struct intel_encoder *encoder)
        }
 
        if (!intel_crtc_get_pipe_config(crtc_state)) {
-               kfree(crtc_state);
+               intel_crtc_destroy_state(&crtc->base, &crtc_state->uapi);
                kfree(mode);
                return NULL;
        }
@@ -4008,7 +4008,7 @@ intel_encoder_current_mode(struct intel_encoder *encoder)
 
        intel_mode_from_crtc_timings(mode, &crtc_state->hw.adjusted_mode);
 
-       kfree(crtc_state);
+       intel_crtc_destroy_state(&crtc->base, &crtc_state->uapi);
 
        return mode;
 }