]> www.infradead.org Git - users/hch/misc.git/commitdiff
drm/amd/display: use max() to improve code
authorQianfeng Rong <rongqianfeng@vivo.com>
Sat, 16 Aug 2025 14:23:05 +0000 (22:23 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 29 Aug 2025 14:07:00 +0000 (10:07 -0400)
Use max() to reduce the code and improve readability.

No functional changes.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn401/dcn401_clk_mgr.c
drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c

index 084994c650c4c9e4d6e5e43e77e3d68dcb29b070..8376e2b0e73dd1c045a11eca4fbe24ed14033e78 100644 (file)
@@ -1047,11 +1047,8 @@ static void dcn32_get_memclk_states_from_smu(struct clk_mgr *clk_mgr_base)
                        &num_entries_per_clk->num_fclk_levels);
        clk_mgr_base->bw_params->dc_mode_limit.fclk_mhz = dcn30_smu_get_dc_mode_max_dpm_freq(clk_mgr, PPCLK_FCLK);
 
-       if (num_entries_per_clk->num_memclk_levels >= num_entries_per_clk->num_fclk_levels) {
-               num_levels = num_entries_per_clk->num_memclk_levels;
-       } else {
-               num_levels = num_entries_per_clk->num_fclk_levels;
-       }
+       num_levels = max(num_entries_per_clk->num_memclk_levels, num_entries_per_clk->num_fclk_levels);
+
        clk_mgr_base->bw_params->max_memclk_mhz =
                        clk_mgr_base->bw_params->clk_table.entries[num_entries_per_clk->num_memclk_levels - 1].memclk_mhz;
        clk_mgr_base->bw_params->clk_table.num_entries = num_levels ? num_levels : 1;
index b59703467128834873a39a84185e86f512186019..47ff4c965d767b04d8066f681d5444e13132e617 100644 (file)
@@ -1404,11 +1404,7 @@ static void dcn401_get_memclk_states_from_smu(struct clk_mgr *clk_mgr_base)
                        clk_mgr_base->bw_params->clk_table.entries[num_entries_per_clk->num_fclk_levels - 1].fclk_mhz)
                clk_mgr_base->bw_params->dc_mode_limit.fclk_mhz = 0;
 
-       if (num_entries_per_clk->num_memclk_levels >= num_entries_per_clk->num_fclk_levels) {
-               num_levels = num_entries_per_clk->num_memclk_levels;
-       } else {
-               num_levels = num_entries_per_clk->num_fclk_levels;
-       }
+       num_levels = max(num_entries_per_clk->num_memclk_levels, num_entries_per_clk->num_fclk_levels);
 
        clk_mgr_base->bw_params->clk_table.num_entries = num_levels ? num_levels : 1;
 
index 23fdb17f851a3000939d35843e2dbe17ece73055..d6c77d96e4f706ddd895cc5d01b9c8c5c3ea2776 100644 (file)
@@ -463,11 +463,7 @@ static void populate_dml21_timing_config_from_stream_state(struct dml2_timing_cf
                                (stream->timing.h_total * (long long)calc_max_hardware_v_total(stream)));
        }
 
-       if (stream->timing.min_refresh_in_uhz > min_hardware_refresh_in_uhz) {
-               timing->drr_config.min_refresh_uhz = stream->timing.min_refresh_in_uhz;
-       } else {
-               timing->drr_config.min_refresh_uhz = min_hardware_refresh_in_uhz;
-       }
+       timing->drr_config.min_refresh_uhz = max(stream->timing.min_refresh_in_uhz, min_hardware_refresh_in_uhz);
 
        if (dml_ctx->config.callbacks.get_max_flickerless_instant_vtotal_increase &&
                        stream->ctx->dc->config.enable_fpo_flicker_detection == 1)