genirq: Get rid of GENERIC_MSI_IRQ_DOMAIN

Adjust to reality and remove another layer of pointless Kconfig
indirection. CONFIG_GENERIC_MSI_IRQ is good enough to serve
all purposes.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20221111122014.524842979@linutronix.de

diff --git a/drivers/base/Makefile b/drivers/base/Makefile
index 83217d243c25b20d1f1b59c296336c530ecbcc6c..3079bfe53d04d9bb9f1bb35514f41dda7b09cf50 100644 (file)
--- a/drivers/base/Makefile
+++ b/drivers/base/Makefile
@@ -22,7 +22,7 @@ obj-$(CONFIG_REGMAP)  += regmap/
 obj-$(CONFIG_SOC_BUS) += soc.o
 obj-$(CONFIG_PINCTRL) += pinctrl.o
 obj-$(CONFIG_DEV_COREDUMP) += devcoredump.o
-obj-$(CONFIG_GENERIC_MSI_IRQ_DOMAIN) += platform-msi.o
+obj-$(CONFIG_GENERIC_MSI_IRQ) += platform-msi.o
 obj-$(CONFIG_GENERIC_ARCH_TOPOLOGY) += arch_topology.o
 obj-$(CONFIG_GENERIC_ARCH_NUMA) += arch_numa.o
 obj-$(CONFIG_ACPI) += physical_location.o

diff --git a/drivers/bus/fsl-mc/Kconfig b/drivers/bus/fsl-mc/Kconfig
index b1fd55901c504d298ce368f03cafd50e2adf5ada..9492342e7d139a70c6133471ff322cc843a1a9a3 100644 (file)
--- a/drivers/bus/fsl-mc/Kconfig
+++ b/drivers/bus/fsl-mc/Kconfig
@@ -8,7 +8,7 @@
 config FSL_MC_BUS
        bool "QorIQ DPAA2 fsl-mc bus driver"
        depends on OF && (ARCH_LAYERSCAPE || (COMPILE_TEST && (ARM || ARM64 || X86_LOCAL_APIC || PPC)))
-       select GENERIC_MSI_IRQ_DOMAIN
+       select GENERIC_MSI_IRQ
        help
          Driver to enable the bus infrastructure for the QorIQ DPAA2
          architecture.  The fsl-mc bus driver handles discovery of

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 7524b62a8870a24990d7a8a001c201872ca94160..25e111ab21f83089f0076a6d185fb6931ac64867 100644 (file)
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -462,7 +462,7 @@ config MV_XOR_V2
        select DMA_ENGINE
        select DMA_ENGINE_RAID
        select ASYNC_TX_ENABLE_CHANNEL_SWITCH
-       select GENERIC_MSI_IRQ_DOMAIN
+       select GENERIC_MSI_IRQ
        help
          Enable support for the Marvell version 2 XOR engine.
 

diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c
index 210f1a9eb44145fb8b7a848cecb395bf6e93e9da..04d1c33afc1296466e250aa865ee935a306131c5 100644 (file)
--- a/drivers/dma/qcom/hidma.c
+++ b/drivers/dma/qcom/hidma.c
@@ -610,7 +610,7 @@ static irqreturn_t hidma_chirq_handler(int chirq, void *arg)
        return hidma_ll_inthandler(chirq, lldev);
 }
 
-#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
+#ifdef CONFIG_GENERIC_MSI_IRQ
 static irqreturn_t hidma_chirq_handler_msi(int chirq, void *arg)
 {
        struct hidma_lldev **lldevp = arg;
@@ -671,7 +671,7 @@ static int hidma_sysfs_init(struct hidma_dev *dev)
        return device_create_file(dev->ddev.dev, dev->chid_attrs);
 }
 
-#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
+#ifdef CONFIG_GENERIC_MSI_IRQ
 static void hidma_write_msi_msg(struct msi_desc *desc, struct msi_msg *msg)
 {
        struct device *dev = msi_desc_to_dev(desc);
@@ -687,7 +687,7 @@ static void hidma_write_msi_msg(struct msi_desc *desc, struct msi_msg *msg)
 
 static void hidma_free_msis(struct hidma_dev *dmadev)
 {
-#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
+#ifdef CONFIG_GENERIC_MSI_IRQ
        struct device *dev = dmadev->ddev.dev;
        int i, virq;
 
@@ -704,7 +704,7 @@ static void hidma_free_msis(struct hidma_dev *dmadev)
 static int hidma_request_msi(struct hidma_dev *dmadev,
                             struct platform_device *pdev)
 {
-#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
+#ifdef CONFIG_GENERIC_MSI_IRQ
        int rc, i, virq;
 
        rc = platform_msi_domain_alloc_irqs(&pdev->dev, HIDMA_MSI_INTS,

diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
index dc5f7a156ff5ec733c748448af161fef159eeb55..8eaf9b72a99550f7593aba651fdc1d66cfdbf443 100644 (file)
--- a/drivers/iommu/Kconfig
+++ b/drivers/iommu/Kconfig
@@ -389,7 +389,7 @@ config ARM_SMMU_V3
        depends on ARM64
        select IOMMU_API
        select IOMMU_IO_PGTABLE_LPAE
-       select GENERIC_MSI_IRQ_DOMAIN
+       select GENERIC_MSI_IRQ
        help
          Support for implementations of the ARM System MMU architecture
          version 3 providing translation support to a PCIe root complex.

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 7ef9f5e696d317415c30b258f637db95c1fcaf81..ffea6a8ccece68e321f9d7c37feabc6e3a335f40 100644 (file)
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -38,7 +38,7 @@ config ARM_GIC_V3
 
 config ARM_GIC_V3_ITS
        bool
-       select GENERIC_MSI_IRQ_DOMAIN
+       select GENERIC_MSI_IRQ
        default ARM_GIC_V3
 
 config ARM_GIC_V3_ITS_PCI
@@ -375,7 +375,7 @@ config MVEBU_ICU
 
 config MVEBU_ODMI
        bool
-       select GENERIC_MSI_IRQ_DOMAIN
+       select GENERIC_MSI_IRQ
 
 config MVEBU_PIC
        bool
@@ -488,7 +488,7 @@ config IMX_MU_MSI
        default m if ARCH_MXC
        select IRQ_DOMAIN
        select IRQ_DOMAIN_HIERARCHY
-       select GENERIC_MSI_IRQ_DOMAIN
+       select GENERIC_MSI_IRQ
        help
          Provide a driver for the i.MX Messaging Unit block used as a
          CPU-to-CPU MSI controller. This requires a specially crafted DT

diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
index 05d6fae800e372e00f69ef77041d08c5123e5f5c..d7af896cbd7b4089d581aa5bc035eea517fda4c3 100644 (file)
--- a/drivers/mailbox/Kconfig
+++ b/drivers/mailbox/Kconfig
@@ -223,7 +223,7 @@ config BCM_FLEXRM_MBOX
        tristate "Broadcom FlexRM Mailbox"
        depends on ARM64
        depends on ARCH_BCM_IPROC || COMPILE_TEST
-       select GENERIC_MSI_IRQ_DOMAIN
+       select GENERIC_MSI_IRQ
        default m if ARCH_BCM_IPROC
        help
          Mailbox implementation of the Broadcom FlexRM ring manager,

diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
index b7f62214668ac3af159cd5c68a63352607565eb7..9309f2469b41db5d962af7f1cc447c7257aaf86d 100644 (file)
--- a/drivers/pci/Kconfig
+++ b/drivers/pci/Kconfig
@@ -38,7 +38,6 @@ source "drivers/pci/pcie/Kconfig"
 
 config PCI_MSI
        bool "Message Signaled Interrupts (MSI and MSI-X)"
-       select GENERIC_MSI_IRQ_DOMAIN
        select GENERIC_MSI_IRQ
        help
           This allows device drivers to enable MSI (Message Signaled

diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig
index 341010f20b777905f67d25dbb072fe4c515b487f..692ffd56f5cc8aa6d395a3df2c1a67e0b9172393 100644 (file)
--- a/drivers/perf/Kconfig
+++ b/drivers/perf/Kconfig
@@ -93,7 +93,7 @@ config ARM_PMU_ACPI
 config ARM_SMMU_V3_PMU
         tristate "ARM SMMUv3 Performance Monitors Extension"
         depends on (ARM64 && ACPI) || (COMPILE_TEST && 64BIT)
-        depends on GENERIC_MSI_IRQ_DOMAIN
+        depends on GENERIC_MSI_IRQ
           help
           Provides support for the ARM SMMUv3 Performance Monitor Counter
           Groups (PMCG), which provide monitoring of transactions passing

diff --git a/drivers/soc/ti/Kconfig b/drivers/soc/ti/Kconfig
index 7e2fb1c16af128a8ba7fc3a87bf8ef5fefaa3b08..e9a597e4bdc820535b9c22ba8ca3afa7103034fb 100644 (file)
--- a/drivers/soc/ti/Kconfig
+++ b/drivers/soc/ti/Kconfig
@@ -98,6 +98,6 @@ endif # SOC_TI
 
 config TI_SCI_INTA_MSI_DOMAIN
        bool
-       select GENERIC_MSI_IRQ_DOMAIN
+       select GENERIC_MSI_IRQ
        help
          Driver to enable Interrupt Aggregator specific MSI Domain.

diff --git a/include/asm-generic/msi.h b/include/asm-generic/msi.h
index bf910d47e900a954c6ea3e9ab5fdc3229c03112c..124c734ca5d9fc0a204a2a3d951036e8270056f0 100644 (file)
--- a/include/asm-generic/msi.h
+++ b/include/asm-generic/msi.h
@@ -4,7 +4,7 @@
 
 #include <linux/types.h>
 
-#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
+#ifdef CONFIG_GENERIC_MSI_IRQ
 
 #ifndef NUM_MSI_ALLOC_SCRATCHPAD_REGS
 # define NUM_MSI_ALLOC_SCRATCHPAD_REGS 2
@@ -36,6 +36,6 @@ typedef struct msi_alloc_info {
 
 #define GENERIC_MSI_DOMAIN_OPS         1
 
-#endif /* CONFIG_GENERIC_MSI_IRQ_DOMAIN */
+#endif /* CONFIG_GENERIC_MSI_IRQ */
 
 #endif

diff --git a/include/linux/device.h b/include/linux/device.h
index 424b55df02727b5742070f72374fd65f5dd68151..c90a444be1c4092310f5def93f81bc91e6151001 100644 (file)
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -378,10 +378,8 @@ struct dev_links_info {
  * @data:      Pointer to MSI device data
  */
 struct dev_msi_info {
-#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
-       struct irq_domain       *domain;
-#endif
 #ifdef CONFIG_GENERIC_MSI_IRQ
+       struct irq_domain       *domain;
        struct msi_device_data  *data;
 #endif
 };
@@ -742,7 +740,7 @@ static inline void set_dev_node(struct device *dev, int node)
 
 static inline struct irq_domain *dev_get_msi_domain(const struct device *dev)
 {
-#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
+#ifdef CONFIG_GENERIC_MSI_IRQ
        return dev->msi.domain;
 #else
        return NULL;
@@ -751,7 +749,7 @@ static inline struct irq_domain *dev_get_msi_domain(const struct device *dev)
 
 static inline void dev_set_msi_domain(struct device *dev, struct irq_domain *d)
 {
-#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
+#ifdef CONFIG_GENERIC_MSI_IRQ
        dev->msi.domain = d;
 #endif
 }

diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 6aeea1071b1b2d69643e4ff5dbc82b9f41df1189..88ae4513abb5f73ce5db40005a941e3b80efda17 100644 (file)
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -27,7 +27,7 @@ struct gpio_chip;
 
 union gpio_irq_fwspec {
        struct irq_fwspec       fwspec;
-#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
+#ifdef CONFIG_GENERIC_MSI_IRQ
        msi_alloc_info_t        msiinfo;
 #endif
 };

diff --git a/include/linux/msi.h b/include/linux/msi.h
index 9b8414523916b6c662d3dd547fee310fd9135250..8b287148e512d2f860ab0a605c5a7176af462604 100644 (file)
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -79,9 +79,7 @@ void __get_cached_msi_msg(struct msi_desc *entry, struct msi_msg *msg);
 #ifdef CONFIG_GENERIC_MSI_IRQ
 void get_cached_msi_msg(unsigned int irq, struct msi_msg *msg);
 #else
-static inline void get_cached_msi_msg(unsigned int irq, struct msi_msg *msg)
-{
-}
+static inline void get_cached_msi_msg(unsigned int irq, struct msi_msg *msg) { }
 #endif
 
 typedef void (*irq_write_msi_msg_t)(struct msi_desc *desc,
@@ -278,7 +276,7 @@ static inline void msi_device_destroy_sysfs(struct device *dev) { }
  */
 bool arch_restore_msi_irqs(struct pci_dev *dev);
 
-#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
+#ifdef CONFIG_GENERIC_MSI_IRQ
 
 #include <linux/irqhandler.h>
 
@@ -451,7 +449,7 @@ int platform_msi_device_domain_alloc(struct irq_domain *domain, unsigned int vir
 void platform_msi_device_domain_free(struct irq_domain *domain, unsigned int virq,
                                     unsigned int nvec);
 void *platform_msi_get_host_data(struct irq_domain *domain);
-#endif /* CONFIG_GENERIC_MSI_IRQ_DOMAIN */
+#endif /* CONFIG_GENERIC_MSI_IRQ */
 
 /* PCI specific interfaces */
 #ifdef CONFIG_PCI_MSI

diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig
index db3d174c53d484b8ebd5b69020b632ad131fd0b6..b64c44ae4c2504174239c7eb19adbff8e76d7687 100644 (file)
--- a/kernel/irq/Kconfig
+++ b/kernel/irq/Kconfig
@@ -86,15 +86,10 @@ config GENERIC_IRQ_IPI
        depends on SMP
        select IRQ_DOMAIN_HIERARCHY
 
-# Generic MSI interrupt support
-config GENERIC_MSI_IRQ
-       bool
-
 # Generic MSI hierarchical interrupt domain support
-config GENERIC_MSI_IRQ_DOMAIN
+config GENERIC_MSI_IRQ
        bool
        select IRQ_DOMAIN_HIERARCHY
-       select GENERIC_MSI_IRQ
 
 config IRQ_MSI_IOMMU
        bool

diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c
index b46b747880870e227c855666897b936dfe283de3..4fde91703c9b572051c4f1c396dbc504741deb26 100644 (file)
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -461,7 +461,6 @@ static inline int msi_sysfs_populate_desc(struct device *dev, struct msi_desc *d
 static inline void msi_sysfs_remove_desc(struct device *dev, struct msi_desc *desc) { }
 #endif /* !CONFIG_SYSFS */
 
-#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
 static int __msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev, int nvec);
 static void __msi_domain_free_irqs(struct irq_domain *domain, struct device *dev);
 
@@ -1058,5 +1057,3 @@ struct msi_domain_info *msi_get_domain_info(struct irq_domain *domain)
 {
        return (struct msi_domain_info *)domain->host_data;
 }
-
-#endif /* CONFIG_GENERIC_MSI_IRQ_DOMAIN */