]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
rds: Lost locking in loop connection freeing
authorPavel Emelyanov <xemul@parallels.com>
Tue, 15 Jul 2014 01:23:01 +0000 (09:23 +0800)
committerMukesh Kacker <mukesh.kacker@oracle.com>
Wed, 8 Jul 2015 21:00:01 +0000 (14:00 -0700)
upstream commit: 58c490babd4b425310363cbd1f406d7e508f77a5

rds: Lost locking in loop connection freeing

The conn is removed from list in there and this requires
proper lock protection.

Orabug: 19265200

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
Signed-off-by: Guangyu Sun <guangyu.sun@oracle.com>
(cherry picked from commit 92ad60f3efabfcd9eb40e983a131c730829c0d90)

net/rds/loop.c

index c4c03a02a5b94d272d82fe8b5db6daa9d520c6d4..e0eac736d8b36d1024f4ba4ce30da50c8d0d4948 100644 (file)
@@ -133,8 +133,12 @@ static int rds_loop_conn_alloc(struct rds_connection *conn, gfp_t gfp)
 static void rds_loop_conn_free(void *arg)
 {
        struct rds_loop_connection *lc = arg;
+       unsigned long flags;
+
        rdsdebug("lc %p\n", lc);
+       spin_lock_irqsave(&loop_conns_lock, flags);
        list_del(&lc->loop_node);
+       spin_unlock_irqrestore(&loop_conns_lock, flags);
        kfree(lc);
 }