]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
serial: sh-sci: Replace direct stop_rx/stop_tx calls with port ops in sci_shutdown()
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Mon, 30 Jun 2025 20:23:21 +0000 (21:23 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 9 Jul 2025 11:45:30 +0000 (13:45 +0200)
Replace direct calls to sci_stop_rx() and sci_stop_tx() with port ops
callbacks in sci_shutdown(). This enables the RSCI driver, which reuses
the SCI core but implements its own stop_rx and stop_tx logic, to reuse
sci_shutdown() without duplicating code.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20250630202323.279809-4-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sh-sci.c

index 06d674a744e287abcda108a820f8735b0a4638dd..42af911d371426181d19c3d487f530efc56ce52c 100644 (file)
@@ -2289,8 +2289,8 @@ void sci_shutdown(struct uart_port *port)
        mctrl_gpio_disable_ms_sync(to_sci_port(port)->gpios);
 
        uart_port_lock_irqsave(port, &flags);
-       sci_stop_rx(port);
-       sci_stop_tx(port);
+       s->port.ops->stop_rx(port);
+       s->port.ops->stop_tx(port);
        s->ops->shutdown_complete(port);
        uart_port_unlock_irqrestore(port, flags);