]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
ksmbd: fix wrong name of SMB2_CREATE_ALLOCATION_SIZE
authorNamjae Jeon <linkinjeon@kernel.org>
Tue, 5 Dec 2023 23:23:49 +0000 (08:23 +0900)
committerSteve French <stfrench@microsoft.com>
Fri, 8 Dec 2023 16:11:33 +0000 (10:11 -0600)
MS confirm that "AISi" name of SMB2_CREATE_ALLOCATION_SIZE in MS-SMB2
specification is a typo. cifs/ksmbd have been using this wrong name from
MS-SMB2. It should be "AlSi". Also It will cause problem when running
smb2.create.open test in smbtorture against ksmbd.

Cc: stable@vger.kernel.org
Fixes: 12197a7fdda9 ("Clarify SMB2/SMB3 create context and add missing ones")
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/common/smb2pdu.h

index 8b603b13e37236e3c2181c70b0947c57b7d4146a..57f2343164a34d81ad9816c0dec7c8994b66beb0 100644 (file)
@@ -1145,7 +1145,7 @@ struct smb2_server_client_notification {
 #define SMB2_CREATE_SD_BUFFER                  "SecD" /* security descriptor */
 #define SMB2_CREATE_DURABLE_HANDLE_REQUEST     "DHnQ"
 #define SMB2_CREATE_DURABLE_HANDLE_RECONNECT   "DHnC"
-#define SMB2_CREATE_ALLOCATION_SIZE            "AISi"
+#define SMB2_CREATE_ALLOCATION_SIZE            "AlSi"
 #define SMB2_CREATE_QUERY_MAXIMAL_ACCESS_REQUEST "MxAc"
 #define SMB2_CREATE_TIMEWARP_REQUEST           "TWrp"
 #define SMB2_CREATE_QUERY_ON_DISK_ID           "QFid"