crypto: sun8i-ce - remove unnecessary alignmask for ahashes

The crypto API's support for alignmasks for ahash algorithms is nearly
useless, as its only effect is to cause the API to align the key and
result buffers.  The drivers that happen to be specifying an alignmask
for ahash rarely actually need it.  When they do, it's easily fixable,
especially considering that these buffers cannot be used for DMA.

In preparation for removing alignmask support from ahash, this patch
makes the sun8i-ce driver no longer use it.  This driver didn't actually
rely on it; it only writes to the result buffer in sun8i_ce_hash_run(),
simply using memcpy().  And this driver only supports unkeyed hash
algorithms, so the key buffer need not be considered.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
index 1741758e03eb60b9068fa89ac42ed8249243fe3c..0408b2d5d533b856e8c3add8d5f0a24827b9c8d1 100644 (file)
--- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
+++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
@@ -414,7 +414,6 @@ static struct sun8i_ce_alg_template ce_algs[] = {
                                .cra_name = "md5",
                                .cra_driver_name = "md5-sun8i-ce",
                                .cra_priority = 300,
-                               .cra_alignmask = 3,
                                .cra_flags = CRYPTO_ALG_TYPE_AHASH |
                                        CRYPTO_ALG_ASYNC |
                                        CRYPTO_ALG_NEED_FALLBACK,
@@ -448,7 +447,6 @@ static struct sun8i_ce_alg_template ce_algs[] = {
                                .cra_name = "sha1",
                                .cra_driver_name = "sha1-sun8i-ce",
                                .cra_priority = 300,
-                               .cra_alignmask = 3,
                                .cra_flags = CRYPTO_ALG_TYPE_AHASH |
                                        CRYPTO_ALG_ASYNC |
                                        CRYPTO_ALG_NEED_FALLBACK,
@@ -481,7 +479,6 @@ static struct sun8i_ce_alg_template ce_algs[] = {
                                .cra_name = "sha224",
                                .cra_driver_name = "sha224-sun8i-ce",
                                .cra_priority = 300,
-                               .cra_alignmask = 3,
                                .cra_flags = CRYPTO_ALG_TYPE_AHASH |
                                        CRYPTO_ALG_ASYNC |
                                        CRYPTO_ALG_NEED_FALLBACK,
@@ -514,7 +511,6 @@ static struct sun8i_ce_alg_template ce_algs[] = {
                                .cra_name = "sha256",
                                .cra_driver_name = "sha256-sun8i-ce",
                                .cra_priority = 300,
-                               .cra_alignmask = 3,
                                .cra_flags = CRYPTO_ALG_TYPE_AHASH |
                                        CRYPTO_ALG_ASYNC |
                                        CRYPTO_ALG_NEED_FALLBACK,
@@ -547,7 +543,6 @@ static struct sun8i_ce_alg_template ce_algs[] = {
                                .cra_name = "sha384",
                                .cra_driver_name = "sha384-sun8i-ce",
                                .cra_priority = 300,
-                               .cra_alignmask = 3,
                                .cra_flags = CRYPTO_ALG_TYPE_AHASH |
                                        CRYPTO_ALG_ASYNC |
                                        CRYPTO_ALG_NEED_FALLBACK,
@@ -580,7 +575,6 @@ static struct sun8i_ce_alg_template ce_algs[] = {
                                .cra_name = "sha512",
                                .cra_driver_name = "sha512-sun8i-ce",
                                .cra_priority = 300,
-                               .cra_alignmask = 3,
                                .cra_flags = CRYPTO_ALG_TYPE_AHASH |
                                        CRYPTO_ALG_ASYNC |
                                        CRYPTO_ALG_NEED_FALLBACK,