]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
net: libwx: Fix the size in RSS hash key population
authorChandra Mohan Sundar <chandramohan.explore@gmail.com>
Thu, 14 Aug 2025 16:30:10 +0000 (22:00 +0530)
committerJakub Kicinski <kuba@kernel.org>
Fri, 15 Aug 2025 19:38:53 +0000 (12:38 -0700)
While trying to fill a random RSS key, the size of the pointer
is being used rather than the actual size of the RSS key.

Fix by passing an appropriate value of the RSS key.
This issue was reported by static coverity analyser.

Fixes: eb4898fde1de8 ("net: libwx: add wangxun vf common api")
Signed-off-by: Chandra Mohan Sundar <chandramohan.explore@gmail.com>
Link: https://patch.msgid.link/20250814163014.613004-1-chandramohan.explore@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/wangxun/libwx/wx_vf_lib.c

index 5d48df7a849f2d8bbe714aa32a333f50a04ce9af..3023ea2732ef2d79a803e3d07ec24e4700f979a5 100644 (file)
@@ -192,7 +192,7 @@ void wx_setup_vfmrqc_vf(struct wx *wx)
        u8 i, j;
 
        /* Fill out hash function seeds */
-       netdev_rss_key_fill(wx->rss_key, sizeof(wx->rss_key));
+       netdev_rss_key_fill(wx->rss_key, WX_RSS_KEY_SIZE);
        for (i = 0; i < WX_RSS_KEY_SIZE / 4; i++)
                wr32(wx, WX_VXRSSRK(i), wx->rss_key[i]);