ice: remove dead code

The check for a NULL pf pointer is moot since the earlier declaration and
assignment of struct device *dev already de-referenced the pointer.  Also,
the only caller of ice_set_dflt_mib() already ensures pf is not NULL.

Cc: Dave Ertman <david.m.ertman@intel.com>
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>

diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index f6177591978d949681e9b8fbf4f812f0308c1d41..98cd44a3ccf7387051cbbfc477ea014ae0455288 100644 (file)
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -785,15 +785,9 @@ static void ice_set_dflt_mib(struct ice_pf *pf)
        u8 mib_type, *buf, *lldpmib = NULL;
        u16 len, typelen, offset = 0;
        struct ice_lldp_org_tlv *tlv;
-       struct ice_hw *hw;
+       struct ice_hw *hw = &pf->hw;
        u32 ouisubtype;
 
-       if (!pf) {
-               dev_dbg(dev, "%s NULL pf pointer\n", __func__);
-               return;
-       }
-
-       hw = &pf->hw;
        mib_type = SET_LOCAL_MIB_TYPE_LOCAL_MIB;
        lldpmib = kzalloc(ICE_LLDPDU_SIZE, GFP_KERNEL);
        if (!lldpmib) {