clk: Print an error when clk registration fails

We have a lot of driver code that prints an error message when
registering a clk fails. Do that in the core function instead to
consolidate code. This also helps drivers avoid the anti-pattern of
accessing the struct clk_hw::init pointer after registration.

Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Link: https://lore.kernel.org/r/20250226235408.1339266-1-sboyd@kernel.org

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 00c1a89a852aa9e2629505027aae74fa6b19c781..3938f26002097b1e79d1c15a7c29398ee0510eb8 100644 (file)
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -4397,6 +4397,13 @@ fail_ops:
 fail_name:
        kref_put(&core->ref, __clk_release);
 fail_out:
+       if (dev) {
+               dev_err_probe(dev, ret, "failed to register clk '%s' (%pS)\n",
+                             init->name, hw);
+       } else {
+               pr_err("%pOF: error %pe: failed to register clk '%s' (%pS)\n",
+                      np, ERR_PTR(ret), init->name, hw);
+       }
        return ERR_PTR(ret);
 }