platform/x86: intel-wmi-thunderbolt: Silence error cases

These were raised by Lukas Wunner as potential DOS attacks against
the system log by passing bad data to sysfs.

Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>

diff --git a/drivers/platform/x86/intel-wmi-thunderbolt.c b/drivers/platform/x86/intel-wmi-thunderbolt.c
index 32fb6cc33d7238d081327ede23846549f6f3887b..c2257bd06f1863d848fc384b2ac5577294bef8f5 100644 (file)
--- a/drivers/platform/x86/intel-wmi-thunderbolt.c
+++ b/drivers/platform/x86/intel-wmi-thunderbolt.c
@@ -41,13 +41,10 @@ static ssize_t force_power_store(struct device *dev,
        if (mode == 0 || mode == 1) {
                status = wmi_evaluate_method(INTEL_WMI_THUNDERBOLT_GUID, 0, 1,
                                             &input, NULL);
-               if (ACPI_FAILURE(status)) {
-                       pr_err("intel-wmi-thunderbolt: failed setting %s\n",
-                              buf);
+               if (ACPI_FAILURE(status))
                        return -ENODEV;
-               }
        } else {
-               pr_err("intel-wmi-thunderbolt: unsupported mode: %d", mode);
+               return -EINVAL;
        }
        return count;
 }