]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
ASoC: codecs: wm8903: use new GPIO line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 8 Apr 2025 07:38:28 +0000 (09:38 +0200)
committerMark Brown <broonie@kernel.org>
Sun, 13 Apr 2025 19:23:23 +0000 (20:23 +0100)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://patch.msgid.link/20250408-gpiochip-set-rv-sound-v1-10-dd54b6ca1ef9@linaro.org
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm8903.c

index 03902909f27eb417ff04c2b2f8df6567079a7aa2..2ed9f493d5075c3870c229bbfe0b479db2e0aa7f 100644 (file)
@@ -1825,13 +1825,15 @@ static int wm8903_gpio_direction_out(struct gpio_chip *chip,
        return 0;
 }
 
-static void wm8903_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
+static int wm8903_gpio_set(struct gpio_chip *chip, unsigned int offset,
+                          int value)
 {
        struct wm8903_priv *wm8903 = gpiochip_get_data(chip);
 
-       regmap_update_bits(wm8903->regmap, WM8903_GPIO_CONTROL_1 + offset,
-                          WM8903_GP1_LVL_MASK,
-                          !!value << WM8903_GP1_LVL_SHIFT);
+       return regmap_update_bits(wm8903->regmap,
+                                 WM8903_GPIO_CONTROL_1 + offset,
+                                 WM8903_GP1_LVL_MASK,
+                                 !!value << WM8903_GP1_LVL_SHIFT);
 }
 
 static const struct gpio_chip wm8903_template_chip = {
@@ -1841,7 +1843,7 @@ static const struct gpio_chip wm8903_template_chip = {
        .direction_input        = wm8903_gpio_direction_in,
        .get                    = wm8903_gpio_get,
        .direction_output       = wm8903_gpio_direction_out,
-       .set                    = wm8903_gpio_set,
+       .set_rv                 = wm8903_gpio_set,
        .can_sleep              = 1,
 };