]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
spi: dw: remove redundant assignment to variable len
authorColin Ian King <colin.i.king@gmail.com>
Thu, 15 Feb 2024 13:16:03 +0000 (13:16 +0000)
committerMark Brown <broonie@kernel.org>
Thu, 15 Feb 2024 14:17:19 +0000 (14:17 +0000)
The variable id len being initialized with a value that is never read,
it is being re-assigned later on in a for-loop. The initialization is
redundant and can be removed.

Cleans up clang scan build warning:
drivers/spi/spi-dw-dma.c:580:17: warning: Although the value stored
to 'len' is used in the enclosing expression, the value is never
actually read from 'len' [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Acked-by: Serge Semin <fancer.lancer@gmail.com>
Link: https://msgid.link/r/20240215131603.2062332-1-colin.i.king@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-dw-dma.c

index 0ecbb6c36e2388588f030af5fa8f71c586a41696..f4c209e5f52baa2c453b353ac515f4950726d627 100644 (file)
@@ -577,7 +577,7 @@ static int dw_spi_dma_transfer_one(struct dw_spi *dws,
        sg_init_table(&tx_tmp, 1);
        sg_init_table(&rx_tmp, 1);
 
-       for (base = 0, len = 0; base < xfer->len; base += len) {
+       for (base = 0; base < xfer->len; base += len) {
                /* Fetch next Tx DMA data chunk */
                if (!tx_len) {
                        tx_sg = !tx_sg ? &xfer->tx_sg.sgl[0] : sg_next(tx_sg);