ASoC: qcom: use int type to store negative error codes

Change the 'ret' variable from unsigned int to int to store negative error
codes or zero returned by regmap_field_write().

Storing the negative error codes in unsigned type, doesn't cause an issue
at runtime but it's ugly as pants. Additionally, assigning negative error
codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
flag is enabled.

No effect on runtime.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Message-ID: <20250828075406.386208-4-rongqianfeng@vivo.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/qcom/lpass-cdc-dma.c b/sound/soc/qcom/lpass-cdc-dma.c
index 8106c586f68a4ec456ae2be11f37b1c2c8cd806c..2dc8c75c4bf08ceab9f0bdb3810dcd0031762285 100644 (file)
--- a/sound/soc/qcom/lpass-cdc-dma.c
+++ b/sound/soc/qcom/lpass-cdc-dma.c
@@ -217,8 +217,9 @@ static int lpass_cdc_dma_daiops_hw_params(struct snd_pcm_substream *substream,
 {
        struct snd_soc_pcm_runtime *soc_runtime = snd_soc_substream_to_rtd(substream);
        struct lpaif_dmactl *dmactl = NULL;
-       unsigned int ret, regval;
+       unsigned int regval;
        unsigned int channels = params_channels(params);
+       int ret;
        int id;
 
        switch (channels) {

diff --git a/sound/soc/qcom/lpass-hdmi.c b/sound/soc/qcom/lpass-hdmi.c
index ce753ebc08945a49283cff0c01de7a084c3c9e15..6d9795306cfa91b2d69511f4c624c60c7a88b7da 100644 (file)
--- a/sound/soc/qcom/lpass-hdmi.c
+++ b/sound/soc/qcom/lpass-hdmi.c
@@ -23,7 +23,6 @@ static int lpass_hdmi_daiops_hw_params(struct snd_pcm_substream *substream,
        snd_pcm_format_t format = params_format(params);
        unsigned int rate = params_rate(params);
        unsigned int channels = params_channels(params);
-       unsigned int ret;
        int bitwidth;
        unsigned int word_length;
        unsigned int ch_sts_buf0;
@@ -33,6 +32,7 @@ static int lpass_hdmi_daiops_hw_params(struct snd_pcm_substream *substream,
        unsigned int ch = 0;
        struct lpass_dp_metadata_ctl *meta_ctl = drvdata->meta_ctl;
        struct lpass_sstream_ctl *sstream_ctl = drvdata->sstream_ctl;
+       int ret;
 
        bitwidth = snd_pcm_format_width(format);
        if (bitwidth < 0) {