configure.ac: improve validation of some --enable-xxx options

Catch an invalid option like "--enable-buspirate=rubbish".
Also mention all valid values in the help text for those options.

Change-Id: Ib0fb8904132d07cc5cde421aa816ca6971a08769
Signed-off-by: R. Diez <rdiezmail-openocd@yahoo.de>
Reviewed-on: https://review.openocd.org/c/openocd/+/8540
Reviewed-by: R. Diez <rdiez-2006@rd10.de>
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Tested-by: jenkins

diff --git a/configure.ac b/configure.ac
index 31e57a3cd06d8deb5dc7504ec6ac9d4836d9f1b9..567152b0a6dec8201970de6e30100324aea0247b 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -272,9 +272,13 @@ AC_ARG_ENABLE([dmem],
 m4_define([AC_ARG_ADAPTERS], [
   m4_foreach([adapter], [$1],
        [AC_ARG_ENABLE(ADAPTER_OPT([adapter]),
-               AS_HELP_STRING([--enable-ADAPTER_OPT([adapter])],
+               AS_HELP_STRING([--enable-ADAPTER_OPT([adapter])[[[=yes/no/auto]]]],
                        [Enable building support for the ]ADAPTER_DESC([adapter])[ (default is $2)]),
-               [], [ADAPTER_VAR([adapter])=$2])
+               [case "${enableval}" in
+                       yes|no|auto) ;;
+                       *) AC_MSG_ERROR([Option --enable-ADAPTER_OPT([adapter]) has invalid value "${enableval}".]) ;;
+                       esac],
+               [ADAPTER_VAR([adapter])=$2])
   ])
 ])