]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
RDS: IB: disable ib_cache purging to avoid memory leak in reconnect path
authorSantosh Shilimkar <santosh.shilimkar@oracle.com>
Tue, 17 May 2016 21:46:18 +0000 (14:46 -0700)
committerChuck Anderson <chuck.anderson@oracle.com>
Sun, 22 May 2016 21:59:39 +0000 (14:59 -0700)
RDS IB caches don't work in reconnect path and if used can lead to
memory leaks. These leaks have been there for long time but we didn't
hit them since caches are not teardown in reconnect path. For different
frag rolling upgrade/downgrade support, its needed to work in reconnect
path but needs additional fixes.

Since the leak is blocking rest of the testing, temporary the cache
purging is disabled. It will be added back once fully fixed.

Orabug: 23275911

The change doesn't impact any of the existing RDS functionality.

Tested-by: Hong Liu <hong.x.liu@oracle.com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
net/rds/ib_cm.c

index 83baf19f42758b457e2ba8524aaefa407e53a709..f06a241a7810344387d78072c0f5b0f9b1d3b194 100644 (file)
@@ -1394,9 +1394,6 @@ void rds_ib_conn_shutdown(struct rds_connection *conn)
 
        reinit_completion(&ic->i_last_wqe_complete);
 
-       /* Purge the ic->i_cache_frags */
-       rds_ib_recv_purge_frag_cache(ic);
-
        ic->i_active_side = 0;
 }