]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
regulator: tps65219: regulator: tps65219: Fix error codes in probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 19 Aug 2025 09:40:41 +0000 (12:40 +0300)
committerMark Brown <broonie@kernel.org>
Tue, 19 Aug 2025 15:51:03 +0000 (16:51 +0100)
There is a copy and paste error and we accidentally use "PTR_ERR(rdev)"
instead of "error".  The "rdev" pointer is valid at this point.

Also there is no need to print the error code in the error message
because dev_err_probe() already prints that.  So clean up the error
message a bit.

Fixes: 38c9f98db20a ("regulator: tps65219: Add support for TPS65215 Regulator IRQs")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aKRGmVdbvT1HBvm8@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/tps65219-regulator.c

index 5e67fdc88f49e65422821ba2dd68d3efb6ff55c7..d77ca486879fd610ce5de29999075dab9c36d93e 100644 (file)
@@ -454,9 +454,9 @@ static int tps65219_regulator_probe(struct platform_device *pdev)
                                                  irq_type->irq_name,
                                                  irq_data);
                if (error)
-                       return dev_err_probe(tps->dev, PTR_ERR(rdev),
-                                            "Failed to request %s IRQ %d: %d\n",
-                                            irq_type->irq_name, irq, error);
+                       return dev_err_probe(tps->dev, error,
+                                            "Failed to request %s IRQ %d\n",
+                                            irq_type->irq_name, irq);
        }
 
        for (i = 0; i < pmic->dev_irq_size; ++i) {
@@ -477,9 +477,9 @@ static int tps65219_regulator_probe(struct platform_device *pdev)
                                                  irq_type->irq_name,
                                                  irq_data);
                if (error)
-                       return dev_err_probe(tps->dev, PTR_ERR(rdev),
-                                            "Failed to request %s IRQ %d: %d\n",
-                                            irq_type->irq_name, irq, error);
+                       return dev_err_probe(tps->dev, error,
+                                            "Failed to request %s IRQ %d\n",
+                                            irq_type->irq_name, irq);
        }
 
        return 0;