projects
/
linux.git
/ commitdiff
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f040327
)
drm/xe/ct: drop irq usage of xa_erase()
author
Matthew Auld <matthew.auld@intel.com>
Tue, 1 Oct 2024 08:43:50 +0000
(09:43 +0100)
committer
Matthew Auld <matthew.auld@intel.com>
Thu, 3 Oct 2024 07:34:21 +0000
(08:34 +0100)
Unclear why disabling interrupts is needed here. Nothing seems to be
touching fence_lookup and its corresponding lock from an irq so there
should be no risk of deadlock.
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Badal Nilawar <badal.nilawar@intel.com>
Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>
Link:
https://patchwork.freedesktop.org/patch/msgid/20241001084346.98516-8-matthew.auld@intel.com
drivers/gpu/drm/xe/xe_guc_ct.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/xe/xe_guc_ct.c
b/drivers/gpu/drm/xe/xe_guc_ct.c
index d3de2e6d690ffc4b56d911b2a95cef61adcf511b..3fd1d4e97528b6ec431b84c984bb6675a802ab0c 100644
(file)
--- a/
drivers/gpu/drm/xe/xe_guc_ct.c
+++ b/
drivers/gpu/drm/xe/xe_guc_ct.c
@@
-890,7
+890,7
@@
retry_same_fence:
goto retry_same_fence;
if (!g2h_fence_needs_alloc(&g2h_fence))
- xa_erase
_irq
(&ct->fence_lookup, g2h_fence.seqno);
+ xa_erase(&ct->fence_lookup, g2h_fence.seqno);
return ret;
}
@@
-907,7
+907,7
@@
retry_same_fence:
if (!ret) {
xe_gt_err(gt, "Timed out wait for G2H, fence %u, action %04x, done %s",
g2h_fence.seqno, action[0], str_yes_no(g2h_fence.done));
- xa_erase
_irq
(&ct->fence_lookup, g2h_fence.seqno);
+ xa_erase(&ct->fence_lookup, g2h_fence.seqno);
mutex_unlock(&ct->lock);
return -ETIME;
}