net: simplify handling of dsa_ndo_eth_ioctl() return code

In the expression "x == 0 || x != -95", the term "x == 0" does not
change the expression's logical value, because 0 != -95, and so,
if x is 0, the expression would still be true by virtue of the second
term. If x is non-zero, the expression depends on the truth value of
the second term anyway. As such, the first term is redundant and can
be deleted.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c
index 1c0256ea522f9ed5d846bee4cf074a364b24c925..b299fb23fcfaa2d1d41ac60e7cf9192709faa2db 100644 (file)
--- a/net/core/dev_ioctl.c
+++ b/net/core/dev_ioctl.c
@@ -249,7 +249,7 @@ static int dev_eth_ioctl(struct net_device *dev,
        int err;
 
        err = dsa_ndo_eth_ioctl(dev, ifr, cmd);
-       if (err == 0 || err != -EOPNOTSUPP)
+       if (err != -EOPNOTSUPP)
                return err;
 
        if (ops->ndo_eth_ioctl) {