perf sched: Fix memory leaks for evsel->priv in timehist

It uses evsel->priv to save per-cpu timing information.  It should be
freed when the evsel is released.

Add the priv destructor for evsel same as thread to handle that.

Fixes: 49394a2a24c78ce0 ("perf sched timehist: Introduce timehist command")
Reviewed-by: Ian Rogers <irogers@google.com>
Tested-by: Ian Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/20250703014942.1369397-6-namhyung@kernel.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>

diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index 83b5a85a91b7ffbd96e951caf0554f952dc24039..a6eb0462dd5be20f7a71bec7f676a7404d3dd9e8 100644 (file)
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -2020,6 +2020,16 @@ static u64 evsel__get_time(struct evsel *evsel, u32 cpu)
        return r->last_time[cpu];
 }
 
+static void timehist__evsel_priv_destructor(void *priv)
+{
+       struct evsel_runtime *r = priv;
+
+       if (r) {
+               free(r->last_time);
+               free(r);
+       }
+}
+
 static int comm_width = 30;
 
 static char *timehist_get_commstr(struct thread *thread)
@@ -3314,6 +3324,8 @@ static int perf_sched__timehist(struct perf_sched *sched)
 
        setup_pager();
 
+       evsel__set_priv_destructor(timehist__evsel_priv_destructor);
+
        /* prefer sched_waking if it is captured */
        if (evlist__find_tracepoint_by_name(session->evlist, "sched:sched_waking"))
                handlers[1].handler = timehist_sched_wakeup_ignore;

diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 9c50c3960487feeecd3bf65932ad07e05ca779f5..3896a04d90af71f36bf3f6d1e357f83a1e5fdf83 100644 (file)
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -1657,6 +1657,15 @@ static void evsel__free_config_terms(struct evsel *evsel)
        free_config_terms(&evsel->config_terms);
 }
 
+static void (*evsel__priv_destructor)(void *priv);
+
+void evsel__set_priv_destructor(void (*destructor)(void *priv))
+{
+       assert(evsel__priv_destructor == NULL);
+
+       evsel__priv_destructor = destructor;
+}
+
 void evsel__exit(struct evsel *evsel)
 {
        assert(list_empty(&evsel->core.node));
@@ -1687,6 +1696,8 @@ void evsel__exit(struct evsel *evsel)
        hashmap__free(evsel->per_pkg_mask);
        evsel->per_pkg_mask = NULL;
        zfree(&evsel->metric_events);
+       if (evsel__priv_destructor)
+               evsel__priv_destructor(evsel->priv);
        perf_evsel__object.fini(evsel);
        if (evsel__tool_event(evsel) == TOOL_PMU__EVENT_SYSTEM_TIME ||
            evsel__tool_event(evsel) == TOOL_PMU__EVENT_USER_TIME)

diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
index 6dbc9690e0c9258c8cff0fc2971bae39077b0ea0..b84ee274602d7d2b62fc6e273edb4e2cb7782127 100644 (file)
--- a/tools/perf/util/evsel.h
+++ b/tools/perf/util/evsel.h
@@ -280,6 +280,8 @@ void evsel__init(struct evsel *evsel, struct perf_event_attr *attr, int idx);
 void evsel__exit(struct evsel *evsel);
 void evsel__delete(struct evsel *evsel);
 
+void evsel__set_priv_destructor(void (*destructor)(void *priv));
+
 struct callchain_param;
 
 void evsel__config(struct evsel *evsel, struct record_opts *opts,