]> www.infradead.org Git - users/hch/misc.git/commitdiff
hwmon: fix a NULL vs IS_ERR_OR_NULL() check in xgene_hwmon_probe()
authorXinghuo Chen <xinghuo.chen@foxmail.com>
Mon, 3 Mar 2025 12:57:33 +0000 (07:57 -0500)
committerGuenter Roeck <linux@roeck-us.net>
Mon, 3 Mar 2025 14:04:34 +0000 (06:04 -0800)
The devm_memremap() function returns error pointers on error,
it doesn't return NULL.

Fixes: c7cefce03e69 ("hwmon: (xgene) access mailbox as RAM")
Signed-off-by: Xinghuo Chen <xinghuo.chen@foxmail.com>
Link: https://lore.kernel.org/r/tencent_9AD8E7683EC29CAC97496B44F3F865BA070A@qq.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/xgene-hwmon.c

index 1e3bd129a922d25ff25142d864503377773304a8..7087197383c96cb97e4623f419afed01d4f3c716 100644 (file)
@@ -706,7 +706,7 @@ static int xgene_hwmon_probe(struct platform_device *pdev)
                        goto out;
                }
 
-               if (!ctx->pcc_comm_addr) {
+               if (IS_ERR_OR_NULL(ctx->pcc_comm_addr)) {
                        dev_err(&pdev->dev,
                                "Failed to ioremap PCC comm region\n");
                        rc = -ENOMEM;